From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mei: bus: type promotion bug in mei_nfc_if_version()
Date: Sat, 7 Jul 2018 17:32:55 +0200 [thread overview]
Message-ID: <20180707153255.GA29925@kroah.com> (raw)
In-Reply-To: <20180704093449.vryluk7khaudstgp@kili.mountain>
On Wed, Jul 04, 2018 at 12:34:49PM +0300, Dan Carpenter wrote:
> We accidentally removed the check for negative returns without
> considering the issue of type promotion. The "if_version_length"
> variable is type size_t so if __mei_cl_recv() returns a negative then
> "bytes_recv" is type promoted to a high positive value and treated as
> success.
>
> Fixes: 582ab27a063a ("mei: bus: fix received data size check in NFC fixup")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Didn't apply to my tree at all :(
next prev parent reply other threads:[~2018-07-07 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 9:34 [PATCH] mei: bus: type promotion bug in mei_nfc_if_version() Dan Carpenter
2018-07-04 11:59 ` Julia Lawall
2018-07-04 12:16 ` Dan Carpenter
2018-07-04 13:57 ` Winkler, Tomas
2018-07-04 14:15 ` Dan Carpenter
2018-07-04 14:25 ` Winkler, Tomas
2018-07-04 14:45 ` Julia Lawall
2018-07-07 15:32 ` Greg Kroah-Hartman [this message]
2018-07-09 11:36 ` Winkler, Tomas
2018-07-09 12:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707153255.GA29925@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).