From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mei: bus: type promotion bug in mei_nfc_if_version()
Date: Wed, 4 Jul 2018 13:59:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807041358580.4387@hadrien> (raw)
In-Reply-To: <20180704093449.vryluk7khaudstgp@kili.mountain>
On Wed, 4 Jul 2018, Dan Carpenter wrote:
> We accidentally removed the check for negative returns without
> considering the issue of type promotion. The "if_version_length"
> variable is type size_t so if __mei_cl_recv() returns a negative then
> "bytes_recv" is type promoted to a high positive value and treated as
> success.
>
> Fixes: 582ab27a063a ("mei: bus: fix received data size check in NFC fixup")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
> index 0208c4b027c5..fa0236a5e59a 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -267,7 +267,7 @@ static int mei_nfc_if_version(struct mei_cl *cl,
>
> ret = 0;
> bytes_recv = __mei_cl_recv(cl, (u8 *)reply, if_version_length, 0);
> - if (bytes_recv < if_version_length) {
> + if (bytes_recv < 0 || bytes_recv < if_version_length) {
Is this preferred to adding an int cast?
julia
> dev_err(bus->dev, "Could not read IF version\n");
> ret = -EIO;
> goto err;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2018-07-04 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 9:34 [PATCH] mei: bus: type promotion bug in mei_nfc_if_version() Dan Carpenter
2018-07-04 11:59 ` Julia Lawall [this message]
2018-07-04 12:16 ` Dan Carpenter
2018-07-04 13:57 ` Winkler, Tomas
2018-07-04 14:15 ` Dan Carpenter
2018-07-04 14:25 ` Winkler, Tomas
2018-07-04 14:45 ` Julia Lawall
2018-07-07 15:32 ` Greg Kroah-Hartman
2018-07-09 11:36 ` Winkler, Tomas
2018-07-09 12:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807041358580.4387@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).