linux-next: build warning after merge of the nand tree

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 4320 bytes --]

Hi Boris,

After merging the nand tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_hwcontrol':
drivers/mtd/nand/raw/davinci_nand.c:115:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   nand->IO_ADDR_W = (void __iomem __force *)addr;
                     ^
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_select_chip':
drivers/mtd/nand/raw/davinci_nand.c:132:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  info->chip.IO_ADDR_W = (void __iomem __force *)addr;
                         ^
In file included from arch/x86/include/asm/bug.h:83:0,
                 from include/linux/bug.h:5,
                 from include/linux/thread_info.h:12,
                 from arch/x86/include/asm/preempt.h:7,
                 from include/linux/preempt.h:81,
                 from include/linux/spinlock.h:51,
                 from include/linux/seqlock.h:36,
                 from include/linux/time.h:6,
                 from include/linux/stat.h:19,
                 from include/linux/module.h:10,
                 from drivers/mtd/nand/raw/davinci_nand.c:27:
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_correct_4bit':
drivers/mtd/nand/raw/davinci_nand.c:322:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (WARN_ON(0x01 & (unsigned) ecc_code))
                     ^
include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON'
  int __ret_warn_on = !!(condition);    \
                         ^~~~~~~~~
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_read_buf':
drivers/mtd/nand/raw/davinci_nand.c:444:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
               ^
drivers/mtd/nand/raw/davinci_nand.c:446:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
                    ^
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_write_buf':
drivers/mtd/nand/raw/davinci_nand.c:457:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
               ^
drivers/mtd/nand/raw/davinci_nand.c:459:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
                    ^
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_probe':
drivers/mtd/nand/raw/davinci_nand.c:683:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  info->ioaddr  = (uint32_t __force) vaddr;
                  ^
drivers/mtd/nand/raw/atmel/nand-controller.c: In function 'atmel_smc_nand_controller_init':
drivers/mtd/nand/raw/atmel/nand-controller.c:2053:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  nc->ebi_csa_offs = (unsigned int)match->data;
                     ^
drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_read_chunks_dma':
drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define NFC_PAGE_OP  (2 << 30)
                      ^
drivers/mtd/nand/raw/sunxi_nand.c:1040:9: note: in expansion of macro 'NFC_PAGE_OP'
  writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | NFC_DATA_TRANS,
         ^~~~~~~~~~~
drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_write_page_dma':
drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define NFC_PAGE_OP  (2 << 30)
                      ^
drivers/mtd/nand/raw/sunxi_nand.c:1406:9: note: in expansion of macro 'NFC_PAGE_OP'
  writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD |
         ^~~~~~~~~~~

Presumably exposed by commits

  347af8918e8a ("mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y")
  b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[Boris Brezillon]

Hi Stephen,

On Mon, 9 Jul 2018 11:51:15 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Boris,
> 
> After merging the nand tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_hwcontrol':
> drivers/mtd/nand/raw/davinci_nand.c:115:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    nand->IO_ADDR_W = (void __iomem __force *)addr;
>                      ^
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_select_chip':
> drivers/mtd/nand/raw/davinci_nand.c:132:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   info->chip.IO_ADDR_W = (void __iomem __force *)addr;
>                          ^
> In file included from arch/x86/include/asm/bug.h:83:0,
>                  from include/linux/bug.h:5,
>                  from include/linux/thread_info.h:12,
>                  from arch/x86/include/asm/preempt.h:7,
>                  from include/linux/preempt.h:81,
>                  from include/linux/spinlock.h:51,
>                  from include/linux/seqlock.h:36,
>                  from include/linux/time.h:6,
>                  from include/linux/stat.h:19,
>                  from include/linux/module.h:10,
>                  from drivers/mtd/nand/raw/davinci_nand.c:27:
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_correct_4bit':
> drivers/mtd/nand/raw/davinci_nand.c:322:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   if (WARN_ON(0x01 & (unsigned) ecc_code))
>                      ^
> include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON'
>   int __ret_warn_on = !!(condition);    \
>                          ^~~~~~~~~
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_read_buf':
> drivers/mtd/nand/raw/davinci_nand.c:444:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
>                ^
> drivers/mtd/nand/raw/davinci_nand.c:446:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
>                     ^
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_write_buf':
> drivers/mtd/nand/raw/davinci_nand.c:457:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
>                ^
> drivers/mtd/nand/raw/davinci_nand.c:459:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
>                     ^
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_probe':
> drivers/mtd/nand/raw/davinci_nand.c:683:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   info->ioaddr  = (uint32_t __force) vaddr;
>                   ^
> drivers/mtd/nand/raw/atmel/nand-controller.c: In function 'atmel_smc_nand_controller_init':
> drivers/mtd/nand/raw/atmel/nand-controller.c:2053:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   nc->ebi_csa_offs = (unsigned int)match->data;
>                      ^
> drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_read_chunks_dma':
> drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>  #define NFC_PAGE_OP  (2 << 30)
>                       ^
> drivers/mtd/nand/raw/sunxi_nand.c:1040:9: note: in expansion of macro 'NFC_PAGE_OP'
>   writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | NFC_DATA_TRANS,
>          ^~~~~~~~~~~
> drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_write_page_dma':
> drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>  #define NFC_PAGE_OP  (2 << 30)
>                       ^
> drivers/mtd/nand/raw/sunxi_nand.c:1406:9: note: in expansion of macro 'NFC_PAGE_OP'
>   writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD |
>          ^~~~~~~~~~~
> 
> Presumably exposed by commits
> 
>   347af8918e8a ("mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y")
>   b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y")
> 

Stephen, thanks for this report.

Miquel, can you drop those 2 commits from the nand tree? I'll resubmit a
series fixing that.

Thanks,

Boris

Re: linux-next: build warning after merge of the nand tree

[Miquel Raynal]

Hi Stephen, Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Mon, 9 Jul 2018
08:16:32 +0200:

> Hi Stephen,
> 
> On Mon, 9 Jul 2018 11:51:15 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi Boris,
> > 
> > After merging the nand tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_hwcontrol':
> > drivers/mtd/nand/raw/davinci_nand.c:115:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    nand->IO_ADDR_W = (void __iomem __force *)addr;
> >                      ^
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_select_chip':
> > drivers/mtd/nand/raw/davinci_nand.c:132:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >   info->chip.IO_ADDR_W = (void __iomem __force *)addr;
> >                          ^
> > In file included from arch/x86/include/asm/bug.h:83:0,
> >                  from include/linux/bug.h:5,
> >                  from include/linux/thread_info.h:12,
> >                  from arch/x86/include/asm/preempt.h:7,
> >                  from include/linux/preempt.h:81,
> >                  from include/linux/spinlock.h:51,
> >                  from include/linux/seqlock.h:36,
> >                  from include/linux/time.h:6,
> >                  from include/linux/stat.h:19,
> >                  from include/linux/module.h:10,
> >                  from drivers/mtd/nand/raw/davinci_nand.c:27:
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_correct_4bit':
> > drivers/mtd/nand/raw/davinci_nand.c:322:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   if (WARN_ON(0x01 & (unsigned) ecc_code))
> >                      ^
> > include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON'
> >   int __ret_warn_on = !!(condition);    \
> >                          ^~~~~~~~~
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_read_buf':
> > drivers/mtd/nand/raw/davinci_nand.c:444:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
> >                ^
> > drivers/mtd/nand/raw/davinci_nand.c:446:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
> >                     ^
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_write_buf':
> > drivers/mtd/nand/raw/davinci_nand.c:457:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
> >                ^
> > drivers/mtd/nand/raw/davinci_nand.c:459:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
> >                     ^
> > drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_probe':
> > drivers/mtd/nand/raw/davinci_nand.c:683:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   info->ioaddr  = (uint32_t __force) vaddr;
> >                   ^
> > drivers/mtd/nand/raw/atmel/nand-controller.c: In function 'atmel_smc_nand_controller_init':
> > drivers/mtd/nand/raw/atmel/nand-controller.c:2053:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >   nc->ebi_csa_offs = (unsigned int)match->data;
> >                      ^
> > drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_read_chunks_dma':
> > drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >  #define NFC_PAGE_OP  (2 << 30)
> >                       ^
> > drivers/mtd/nand/raw/sunxi_nand.c:1040:9: note: in expansion of macro 'NFC_PAGE_OP'
> >   writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | NFC_DATA_TRANS,
> >          ^~~~~~~~~~~
> > drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_write_page_dma':
> > drivers/mtd/nand/raw/sunxi_nand.c:130:22: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >  #define NFC_PAGE_OP  (2 << 30)
> >                       ^
> > drivers/mtd/nand/raw/sunxi_nand.c:1406:9: note: in expansion of macro 'NFC_PAGE_OP'
> >   writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD |
> >          ^~~~~~~~~~~
> > 
> > Presumably exposed by commits
> > 
> >   347af8918e8a ("mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y")
> >   b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y")
> >   
> 
> Stephen, thanks for this report.
> 
> Miquel, can you drop those 2 commits from the nand tree? I'll resubmit a
> series fixing that.

Both commits dropped from nand/next. The branch is clean, it should
build correctly now.

Thanks,
Miquèl

> 
> Thanks,
> 
> Boris



-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Hi Boris,

After merging the nand tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/platform_device.h:14:0,
                 from drivers/mtd/nand/raw/jz4740_nand.c:19:
drivers/mtd/nand/raw/jz4740_nand.c: In function 'jz_nand_detect_bank':
drivers/mtd/nand/raw/jz4740_nand.c:358:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=]
  dev_info(&pdev->dev, "Found chip %i on bank %i\n", chipnr, bank);
                       ^
include/linux/device.h:1397:51: note: in definition of macro 'dev_info'
 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                                   ^~~

Exposed by commit

  6968e07e8169 ("mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Hi Boris,

After merging the nand tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mtd/nand/raw/nand_toshiba.c: In function 'toshiba_nand_read_page_benand':
drivers/mtd/nand/raw/nand_toshiba.c:54:19: warning: unused variable 'mtd' [-Wunused-variable]
  struct mtd_info *mtd = nand_to_mtd(chip);
                   ^~~
drivers/mtd/nand/raw/nand_toshiba.c: In function 'toshiba_nand_read_subpage_benand':
drivers/mtd/nand/raw/nand_toshiba.c:68:19: warning: unused variable 'mtd' [-Wunused-variable]
  struct mtd_info *mtd = nand_to_mtd(chip);
                   ^~~

Introduced by commit

  fe8b76ec9886 ("mtd: rawnand: toshiba: Pass a single nand_chip object to the status helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[Miquel Raynal]

Hi Stephen,

Stephen Rothwell <sfr@canb.auug.org.au> wrote on Mon, 8 Oct 2018
11:38:42 +1100:

> Hi Boris,

Boris is still there but I'm in charge of the NAND tree these days (and
the one to blame too for this one :) ).

> 
> After merging the nand tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/mtd/nand/raw/nand_toshiba.c: In function 'toshiba_nand_read_page_benand':
> drivers/mtd/nand/raw/nand_toshiba.c:54:19: warning: unused variable 'mtd' [-Wunused-variable]
>   struct mtd_info *mtd = nand_to_mtd(chip);
>                    ^~~
> drivers/mtd/nand/raw/nand_toshiba.c: In function 'toshiba_nand_read_subpage_benand':
> drivers/mtd/nand/raw/nand_toshiba.c:68:19: warning: unused variable 'mtd' [-Wunused-variable]
>   struct mtd_info *mtd = nand_to_mtd(chip);
>                    ^~~
> 
> Introduced by commit
> 
>   fe8b76ec9886 ("mtd: rawnand: toshiba: Pass a single nand_chip object to the status helper")

Thanks for the warning, I'll correct it for tomorrow.

Kind regards,
Miquèl

Re: linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi Miquel,

On Mon, 8 Oct 2018 09:53:34 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote on Mon, 8 Oct 2018
> 11:38:42 +1100:
> 
> > Hi Boris,  
> 
> Boris is still there but I'm in charge of the NAND tree these days (and
> the one to blame too for this one :) ).

I'll add you as a contact for this tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/mtd/nand/raw/ingenic/jz4725b_bch.c: In function 'jz4725b_bch_read_parity':
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:147:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
   dest8[2] = (val >> 16) & 0xff;
   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:148:2: note: here
  case 2: /* fall-through */
  ^~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:149:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
   dest8[1] = (val >> 8) & 0xff;
   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:150:2: note: here
  case 1: /* fall-through */
  ^~~~

Introduced by commit

  acb29396f956 ("mtd: rawnand: ingenic: Add support for the JZ4725B")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (i.e. before the next case label).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[Miquel Raynal]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi Stephen,

Stephen Rothwell <sfr@canb.auug.org.au> wrote on Wed, 3 Apr 2019
10:22:39 +1100:

> Hi all,
> 
> After merging the nand tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/mtd/nand/raw/ingenic/jz4725b_bch.c: In function 'jz4725b_bch_read_parity':
> drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:147:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    dest8[2] = (val >> 16) & 0xff;
>    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
> drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:148:2: note: here
>   case 2: /* fall-through */
>   ^~~~
> drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:149:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    dest8[1] = (val >> 8) & 0xff;
>    ~~~~~~~~~^~~~~~~~~~~~~~~~~~~
> drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:150:2: note: here
>   case 1: /* fall-through */
>   ^~~~
> 
> Introduced by commit
> 
>   acb29396f956 ("mtd: rawnand: ingenic: Add support for the JZ4725B")
> 
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (i.e. before the next case label).
> 

Thanks for the warnings, I moved the fall-through comments so the
warnings are gone.

I also added -Wextra in my "mtd-builds" setup to catch these earlier.


Thanks,
Miquèl

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mtd/nand/raw/nand_macronix.c:301:13: warning: 'macronix_nand_deep_power_down_support' defined but not used [-Wunused-function]
  301 | static void macronix_nand_deep_power_down_support(struct nand_chip *chip)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  18870c34d1a8 ("mtd: rawnand: macronix: Add support for deep power down mode")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c: In function 'common_nfc_set_geometry':
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c:514:3: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  514 |   nanddev_get_ecc_requirements(&chip->base);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  950c7c7026ca ("mtd: rawnand: Use nanddev_get/set_ecc_requirements() when relevant")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (htmldocs)
produced these warnings:

Error: Cannot open file drivers/mtd/nand/raw/nand_ecc.c
Error: Cannot open file drivers/mtd/nand/raw/nand_ecc.c

Caused by commit

  5c859c18150b ("mtd: nand: ecc-hamming: Move Hamming code to the generic NAND layer")

Tha sbove file is referred to in:

Documentation/driver-api/mtd/nand_ecc.rst
Documentation/driver-api/mtdnand.rst

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

Hi all,

On Tue, 3 Nov 2020 17:37:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the nand tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> Error: Cannot open file drivers/mtd/nand/raw/nand_ecc.c
> Error: Cannot open file drivers/mtd/nand/raw/nand_ecc.c
> 
> Caused by commit
> 
>   5c859c18150b ("mtd: nand: ecc-hamming: Move Hamming code to the generic NAND layer")
> 
> Tha sbove file is referred to in:
> 
> Documentation/driver-api/mtd/nand_ecc.rst
> Documentation/driver-api/mtdnand.rst

I am still getting the above warnings.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_read':
drivers/mtd/maps/physmap-bt1-rom.c:39:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   39 |  shift = (unsigned int)src & 0x3;
      |          ^
drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_copy_from':
drivers/mtd/maps/physmap-bt1-rom.c:78:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   78 |  shift = (unsigned int)src & 0x3;
      |          ^

Introduced by commit

  69a75a1a47d8 ("mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[Miquel Raynal]

Hi Serge,

Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri, 20 Nov 2020
11:39:29 +1100:

> Hi all,
> 
> After merging the nand tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_read':
> drivers/mtd/maps/physmap-bt1-rom.c:39:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    39 |  shift = (unsigned int)src & 0x3;
>       |          ^
> drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_copy_from':
> drivers/mtd/maps/physmap-bt1-rom.c:78:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    78 |  shift = (unsigned int)src & 0x3;
>       |          ^
> 
> Introduced by commit
> 
>   69a75a1a47d8 ("mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning")
> 

Too bad :/ I'll drop this patch for now, let's look for another
solution...

Thanks,
Miquèl

Re: linux-next: build warning after merge of the nand tree

[Boris Brezillon]

On Fri, 20 Nov 2020 12:23:59 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Serge,
> 
> Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri, 20 Nov 2020
> 11:39:29 +1100:
> 
> > Hi all,
> > 
> > After merging the nand tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_read':
> > drivers/mtd/maps/physmap-bt1-rom.c:39:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >    39 |  shift = (unsigned int)src & 0x3;
> >       |          ^
> > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_copy_from':
> > drivers/mtd/maps/physmap-bt1-rom.c:78:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> >    78 |  shift = (unsigned int)src & 0x3;
> >       |          ^
> > 
> > Introduced by commit
> > 
> >   69a75a1a47d8 ("mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning")
> >   
> 
> Too bad :/ I'll drop this patch for now, let's look for another
> solution...

uintptr_t cast?

Re: linux-next: build warning after merge of the nand tree

[Serge Semin]

Hello Miquel, Boris

On Fri, Nov 20, 2020 at 01:01:23PM +0100, Boris Brezillon wrote:
> On Fri, 20 Nov 2020 12:23:59 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > Hi Serge,
> > 
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri, 20 Nov 2020
> > 11:39:29 +1100:
> > 
> > > Hi all,
> > > 
> > > After merging the nand tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_read':
> > > drivers/mtd/maps/physmap-bt1-rom.c:39:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >    39 |  shift = (unsigned int)src & 0x3;
> > >       |          ^
> > > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_copy_from':
> > > drivers/mtd/maps/physmap-bt1-rom.c:78:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >    78 |  shift = (unsigned int)src & 0x3;
> > >       |          ^
> > > 
> > > Introduced by commit
> > > 
> > >   69a75a1a47d8 ("mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning")
> > >   
> > 

> > Too bad :/ I'll drop this patch for now, let's look for another
> > solution...

that'd be great. I've forgotten that my arch is 32-bit and the
compiler just did print a warning for it.(

> 
> uintptr_t cast?

Yep, most likely that will be the best option in this case to make
sparse happy and not to cause the warning above.

I'll send v2 patch shortly.

-Sergey

Re: linux-next: build warning after merge of the nand tree

[Serge Semin]

On Fri, Nov 20, 2020 at 01:01:23PM +0100, Boris Brezillon wrote:
> On Fri, 20 Nov 2020 12:23:59 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > Hi Serge,
> > 
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri, 20 Nov 2020
> > 11:39:29 +1100:
> > 
> > > Hi all,
> > > 
> > > After merging the nand tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_read':
> > > drivers/mtd/maps/physmap-bt1-rom.c:39:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >    39 |  shift = (unsigned int)src & 0x3;
> > >       |          ^
> > > drivers/mtd/maps/physmap-bt1-rom.c: In function 'bt1_rom_map_copy_from':
> > > drivers/mtd/maps/physmap-bt1-rom.c:78:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> > >    78 |  shift = (unsigned int)src & 0x3;
> > >       |          ^
> > > 
> > > Introduced by commit
> > > 
> > >   69a75a1a47d8 ("mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning")
> > >   
> > 
> > Too bad :/ I'll drop this patch for now, let's look for another
> > solution...
> 
> uintptr_t cast?

unsigned long shall also work here...

-Sergey

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mtd/rawnand.h:1307: warning: Function parameter or member 'resume_wq' not described in 'nand_chip'

Introduced by commit

  0ff4eb01ffb9 ("mtd: rawnand: protect access to rawnand devices while in suspend")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mtd/rawnand.h:1325: warning: Function parameter or member 'cont_read' not described in 'nand_chip'

Introduced by commit

  003fe4b9545b ("mtd: rawnand: Support for sequential cache reads")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nand tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Hi all,

After merging the nand tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mtd/rawnand.h:1016: warning: Function parameter or member 'deassert_wp' not described in 'nand_operation'

Introduced by commit

  e82a5a014dd5 ("mtd: rawnand: Add destructive operation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nand tree

[David Regan]

Hi Stephen,

from this post:
https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717

Looks like this comment needs to be added:

* @deassert_wp: set to true when the operation requires the WP pin to be
*                         de-asserted (ERASE, PROG, ...)


What's the best way to go about doing this?

Thanks!

-Dave


On Thu, Nov 30, 2023 at 5:56 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the nand tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/mtd/rawnand.h:1016: warning: Function parameter or member 'deassert_wp' not described in 'nand_operation'
>
> Introduced by commit
>
>   e82a5a014dd5 ("mtd: rawnand: Add destructive operation")
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the nand tree

[Miquel Raynal]

Hi David,

dregan@broadcom.com wrote on Thu, 30 Nov 2023 21:03:00 -0800:

> Hi Stephen,
> 
> from this post:
> https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717
> 
> Looks like this comment needs to be added:
> 
> * @deassert_wp: set to true when the operation requires the WP pin to be
> *                         de-asserted (ERASE, PROG, ...)
> 
> 
> What's the best way to go about doing this?

Please send a normal patch and I will take care of this.

Thanks,
Miquèl