* [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
@ 2018-07-09 12:36 Jaya Durga
2018-07-09 12:56 ` Dan Carpenter
0 siblings, 1 reply; 10+ messages in thread
From: Jaya Durga @ 2018-07-09 12:36 UTC (permalink / raw)
To: gregkh; +Cc: quytelda, deanahn, devel, linux-kernel
From: root <root@boss.chennai.cdac.in>
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 12:36 [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse Jaya Durga
@ 2018-07-09 12:56 ` Dan Carpenter
2018-07-09 13:02 ` Jaya Durga
0 siblings, 1 reply; 10+ messages in thread
From: Dan Carpenter @ 2018-07-09 12:56 UTC (permalink / raw)
To: Jaya Durga; +Cc: gregkh, devel, deanahn, quytelda, linux-kernel
I don't understand why you have sent this patch four times.
Are you a script which has a bug? Please answer us so that we know you
are a human being.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 12:56 ` Dan Carpenter
@ 2018-07-09 13:02 ` Jaya Durga
0 siblings, 0 replies; 10+ messages in thread
From: Jaya Durga @ 2018-07-09 13:02 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, deanahn, quytelda, linux-kernel
Hi ,
I have updated the patch --subject-prefix="PATCH v3" and made the
commit as per your suggestion ,
i don't know why does the script doesn't update my changes,will try to
sort out the issue ,
sorry for the inconvenience.
Regards,
Jaya Durga
On Mon, Jul 9, 2018 at 6:26 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> I don't understand why you have sent this patch four times.
>
> Are you a script which has a bug? Please answer us so that we know you
> are a human being.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
@ 2018-07-09 10:57 Jaya Durga
2018-07-09 11:43 ` Dan Carpenter
2018-07-09 11:57 ` Greg KH
0 siblings, 2 replies; 10+ messages in thread
From: Jaya Durga @ 2018-07-09 10:57 UTC (permalink / raw)
To: gregkh; +Cc: quytelda, jonathankim, deanahn, devel, linux-kernel
From: root <root@boss.chennai.cdac.in>
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 10:57 Jaya Durga
@ 2018-07-09 11:43 ` Dan Carpenter
2018-07-09 11:57 ` Greg KH
1 sibling, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2018-07-09 11:43 UTC (permalink / raw)
To: Jaya Durga; +Cc: gregkh, devel, deanahn, jonathankim, quytelda, linux-kernel
Also, you really should be sending this as a [PATCH v3] with a note
under the --- cut off that says "V3: fix From header, and indenting"
Google for how to send a v2 patch.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 10:57 Jaya Durga
2018-07-09 11:43 ` Dan Carpenter
@ 2018-07-09 11:57 ` Greg KH
1 sibling, 0 replies; 10+ messages in thread
From: Greg KH @ 2018-07-09 11:57 UTC (permalink / raw)
To: Jaya Durga; +Cc: devel, deanahn, jonathankim, quytelda, linux-kernel
On Mon, Jul 09, 2018 at 04:27:58PM +0530, Jaya Durga wrote:
> From: root <root@boss.chennai.cdac.in>
Again, wrong address :(
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
@ 2018-07-09 10:00 Jaya Durga
2018-07-09 10:34 ` Dan Carpenter
0 siblings, 1 reply; 10+ messages in thread
From: Jaya Durga @ 2018-07-09 10:00 UTC (permalink / raw)
To: gregkh; +Cc: quytelda, jonathankim, deanahn, devel, linux-kernel
From: root <root@boss.chennai.cdac.in>
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 10:00 Jaya Durga
@ 2018-07-09 10:34 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2018-07-09 10:34 UTC (permalink / raw)
To: Jaya Durga; +Cc: gregkh, devel, deanahn, jonathankim, quytelda, linux-kernel
On Mon, Jul 09, 2018 at 03:30:20PM +0530, Jaya Durga wrote:
> From: root <root@boss.chennai.cdac.in>
Please send the patch to yourself first and make sure it's right. Then
resend to the list.
>
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
>
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fix checkpath check
>
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index bf554f7c56ca..5de1940c1f79 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -27,7 +27,11 @@
> #define MUX_TX_MAX_SIZE 2048
> -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> +static unsigned int gdm_tty_ready(struct gdm *gdm)
> +{
> +return (gdm && gdm->tty_dev && gdm->port.count);
This needs to be indented.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
@ 2018-07-09 8:44 Jaya Durga
2018-07-09 9:18 ` Greg KH
0 siblings, 1 reply; 10+ messages in thread
From: Jaya Durga @ 2018-07-09 8:44 UTC (permalink / raw)
To: gregkh
Cc: quytelda, jonathankim, deanahn, devel, linux-kernel, root, Jaya Durga
From: root <root@boss.chennai.cdac.in>
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index bf554f7c56ca..5de1940c1f79 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -27,7 +27,11 @@
#define MUX_TX_MAX_SIZE 2048
-#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
+static unsigned int gdm_tty_ready(struct gdm *gdm)
+{
+return (gdm && gdm->tty_dev && gdm->port.count);
+}
+
static struct tty_driver *gdm_driver[TTY_MAX_COUNT];
static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];
@@ -127,7 +131,7 @@ static int gdm_tty_recv_complete(void *data,
{
struct gdm *gdm = tty_dev->gdm[index];
- if (!GDM_TTY_READY(gdm)) {
+ if (!gdm_tty_ready(gdm)) {
if (complete == RECV_PACKET_PROCESS_COMPLETE)
gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev,
gdm_tty_recv_complete);
@@ -154,7 +158,7 @@ static void gdm_tty_send_complete(void *arg)
{
struct gdm *gdm = arg;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return;
tty_port_tty_wakeup(&gdm->port);
@@ -168,7 +172,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
int sent_len = 0;
int sending_len = 0;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
if (!len)
@@ -195,7 +199,7 @@ static int gdm_tty_write_room(struct tty_struct *tty)
{
struct gdm *gdm = tty->driver_data;
- if (!GDM_TTY_READY(gdm))
+ if (!gdm_tty_ready(gdm))
return -ENODEV;
return WRITE_SIZE;
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse
2018-07-09 8:44 Jaya Durga
@ 2018-07-09 9:18 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2018-07-09 9:18 UTC (permalink / raw)
To: Jaya Durga; +Cc: devel, jonathankim, linux-kernel, deanahn, root, quytelda
On Mon, Jul 09, 2018 at 02:14:06PM +0530, Jaya Durga wrote:
> From: root <root@boss.chennai.cdac.in>
That's an odd author name :)
>
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
>
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fix checkpath check
>
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
It doesn't match this one either :(
Please fix...
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-09 13:02 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 12:36 [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse Jaya Durga
2018-07-09 12:56 ` Dan Carpenter
2018-07-09 13:02 ` Jaya Durga
-- strict thread matches above, loose matches on Subject: below --
2018-07-09 10:57 Jaya Durga
2018-07-09 11:43 ` Dan Carpenter
2018-07-09 11:57 ` Greg KH
2018-07-09 10:00 Jaya Durga
2018-07-09 10:34 ` Dan Carpenter
2018-07-09 8:44 Jaya Durga
2018-07-09 9:18 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).