* [PATCH] drm/tinydrm: add backlight dependency for ili9341
@ 2018-07-09 15:20 Arnd Bergmann
2018-07-10 15:55 ` Noralf Trønnes
2018-07-12 17:13 ` David Lechner
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-07-09 15:20 UTC (permalink / raw)
To: Noralf Trønnes, David Airlie
Cc: Arnd Bergmann, David Lechner, Sean Paul, dri-devel, linux-kernel
This tinydrm driver fails to link without the backlight support:
drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe':
ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight'
Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver for ILI9341 display panels")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/tinydrm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
index 7a8008b0783f..16f4b5c91f1b 100644
--- a/drivers/gpu/drm/tinydrm/Kconfig
+++ b/drivers/gpu/drm/tinydrm/Kconfig
@@ -23,6 +23,7 @@ config TINYDRM_ILI9225
config TINYDRM_ILI9341
tristate "DRM support for ILI9341 display panels"
depends on DRM_TINYDRM && SPI
+ depends on BACKLIGHT_CLASS_DEVICE
select TINYDRM_MIPI_DBI
help
DRM driver for the following Ilitek ILI9341 panels:
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341
2018-07-09 15:20 [PATCH] drm/tinydrm: add backlight dependency for ili9341 Arnd Bergmann
@ 2018-07-10 15:55 ` Noralf Trønnes
2018-07-10 16:12 ` David Lechner
2018-07-12 17:13 ` David Lechner
1 sibling, 1 reply; 4+ messages in thread
From: Noralf Trønnes @ 2018-07-10 15:55 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie, David Lechner
Cc: Sean Paul, dri-devel, linux-kernel
Den 09.07.2018 17.20, skrev Arnd Bergmann:
> This tinydrm driver fails to link without the backlight support:
>
> drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe':
> ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight'
>
> Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver for ILI9341 display panels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tinydrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 7a8008b0783f..16f4b5c91f1b 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -23,6 +23,7 @@ config TINYDRM_ILI9225
> config TINYDRM_ILI9341
> tristate "DRM support for ILI9341 display panels"
> depends on DRM_TINYDRM && SPI
> + depends on BACKLIGHT_CLASS_DEVICE
> select TINYDRM_MIPI_DBI
> help
> DRM driver for the following Ilitek ILI9341 panels:
There was some work done to make backlight optional, but I see now that
it failed to take into account the possibility of the driver being
builtin and BACKLIGHT_CLASS_DEVICE being a module.
This is from include/linux/backlight.h:
#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
struct backlight_device *of_find_backlight(struct device *dev);
struct backlight_device *devm_of_find_backlight(struct device *dev);
#else
static inline struct backlight_device *of_find_backlight(struct device *dev)
{
return NULL;
}
static inline struct backlight_device *
devm_of_find_backlight(struct device *dev)
{
return NULL;
}
#endif
Anyways, thanks for fixing this:
Acked-by: Noralf Trønnes <noralf@tronnes.org>
David Lechner do you apply this?
Noralf.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341
2018-07-10 15:55 ` Noralf Trønnes
@ 2018-07-10 16:12 ` David Lechner
0 siblings, 0 replies; 4+ messages in thread
From: David Lechner @ 2018-07-10 16:12 UTC (permalink / raw)
To: Noralf Trønnes, Arnd Bergmann, David Airlie
Cc: Sean Paul, dri-devel, linux-kernel
On 07/10/2018 10:55 AM, Noralf Trønnes wrote:
>
> Anyways, thanks for fixing this:
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
>
> David Lechner do you apply this?
>
> Noralf.
>
Yes, I will pick it up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/tinydrm: add backlight dependency for ili9341
2018-07-09 15:20 [PATCH] drm/tinydrm: add backlight dependency for ili9341 Arnd Bergmann
2018-07-10 15:55 ` Noralf Trønnes
@ 2018-07-12 17:13 ` David Lechner
1 sibling, 0 replies; 4+ messages in thread
From: David Lechner @ 2018-07-12 17:13 UTC (permalink / raw)
To: Arnd Bergmann, Noralf Trønnes, David Airlie
Cc: Sean Paul, dri-devel, linux-kernel
On 07/09/2018 10:20 AM, Arnd Bergmann wrote:
> This tinydrm driver fails to link without the backlight support:
>
> drivers/gpu/drm/tinydrm/ili9341.o: In function `ili9341_probe':
> ili9341.c:(.text+0x578): undefined reference to `devm_of_find_backlight'
>
> Fixes: 3fa0e8f6f960 ("drm/tinydrm: new driver for ILI9341 display panels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
applied to drm-misc-next.
thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-12 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 15:20 [PATCH] drm/tinydrm: add backlight dependency for ili9341 Arnd Bergmann
2018-07-10 15:55 ` Noralf Trønnes
2018-07-10 16:12 ` David Lechner
2018-07-12 17:13 ` David Lechner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).