* [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit
@ 2018-07-09 15:57 Arnd Bergmann
2018-07-09 15:57 ` [PATCH 2/3] mtd: atmel nand: fix build warning " Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-07-09 15:57 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Sekhar Nori,
Gregory CLEMENT, Alexander Sverdlin, Bartosz Golaszewski,
linux-mtd, linux-kernel
Now that we can build this driver everywhere, we run into a couple
of warnings like:
drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_correct_4bit':
drivers/mtd/nand/raw/davinci_nand.c:322:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
In all cases, this is harmless and we just need to cast to an uintptr_t
rather than an unsigned 32-bit integer.
Fixes: 347af8918e8a ("mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/raw/davinci_nand.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
index cd12e5abafde..c638bd60eb0b 100644
--- a/drivers/mtd/nand/raw/davinci_nand.c
+++ b/drivers/mtd/nand/raw/davinci_nand.c
@@ -102,7 +102,7 @@ static void nand_davinci_hwcontrol(struct mtd_info *mtd, int cmd,
unsigned int ctrl)
{
struct davinci_nand_info *info = to_davinci_nand(mtd);
- uint32_t addr = info->current_cs;
+ uintptr_t addr = info->current_cs;
struct nand_chip *nand = mtd_to_nand(mtd);
/* Did the control lines change? */
@@ -122,7 +122,7 @@ static void nand_davinci_hwcontrol(struct mtd_info *mtd, int cmd,
static void nand_davinci_select_chip(struct mtd_info *mtd, int chip)
{
struct davinci_nand_info *info = to_davinci_nand(mtd);
- uint32_t addr = info->ioaddr;
+ uintptr_t addr = info->ioaddr;
/* maybe kick in a second chipselect */
if (chip > 0)
@@ -319,7 +319,7 @@ static int nand_davinci_correct_4bit(struct mtd_info *mtd,
/* Unpack ten bytes into eight 10 bit values. We know we're
* little-endian, and use type punning for less shifting/masking.
*/
- if (WARN_ON(0x01 & (unsigned) ecc_code))
+ if (WARN_ON(0x01 & (uintptr_t)ecc_code))
return -EINVAL;
ecc16 = (unsigned short *)ecc_code;
@@ -441,9 +441,9 @@ static void nand_davinci_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
{
struct nand_chip *chip = mtd_to_nand(mtd);
- if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
+ if ((0x03 & ((uintptr_t)buf)) == 0 && (0x03 & len) == 0)
ioread32_rep(chip->IO_ADDR_R, buf, len >> 2);
- else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
+ else if ((0x01 & ((uintptr_t)buf)) == 0 && (0x01 & len) == 0)
ioread16_rep(chip->IO_ADDR_R, buf, len >> 1);
else
ioread8_rep(chip->IO_ADDR_R, buf, len);
@@ -454,9 +454,9 @@ static void nand_davinci_write_buf(struct mtd_info *mtd,
{
struct nand_chip *chip = mtd_to_nand(mtd);
- if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
+ if ((0x03 & ((uintptr_t)buf)) == 0 && (0x03 & len) == 0)
iowrite32_rep(chip->IO_ADDR_R, buf, len >> 2);
- else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
+ else if ((0x01 & ((uintptr_t)buf)) == 0 && (0x01 & len) == 0)
iowrite16_rep(chip->IO_ADDR_R, buf, len >> 1);
else
iowrite8_rep(chip->IO_ADDR_R, buf, len);
@@ -680,7 +680,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
info->chip.bbt_md = pdata->bbt_md;
info->timing = pdata->timing;
- info->ioaddr = (uint32_t __force) vaddr;
+ info->ioaddr = (uintptr_t __force) vaddr;
info->current_cs = info->ioaddr;
info->core_chipsel = pdata->core_chipsel;
--
2.9.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-09 15:57 [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Arnd Bergmann
@ 2018-07-09 15:57 ` Arnd Bergmann
2018-07-13 9:56 ` Tudor Ambarus
2018-07-09 15:57 ` [PATCH 3/3] mtd: sunxi_nand: fix build warning Arnd Bergmann
2018-07-09 16:12 ` [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Boris Brezillon
2 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2018-07-09 15:57 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Wenyou Yang, Josh Wu, Miquel Raynal,
Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Nicolas Ferre, Alexandre Belloni, Masahiro Yamada,
Gregory CLEMENT, Peter Rosin, Romain Izard, linux-mtd,
linux-arm-kernel, linux-kernel
Build-testing this driver on a 64-bit architecture produces a
harmless warning:
drivers/mtd/nand/raw/atmel/nand-controller.c: In function 'atmel_smc_nand_controller_init':
drivers/mtd/nand/raw/atmel/nand-controller.c:2053:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
To cast the pointer correctly, the destination type should be
uintptr_t rather than a 32-bit int.
Fixes: c2f3d0b913a5 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index e686fe73159e..e8f7549d0354 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -2050,7 +2050,7 @@ atmel_smc_nand_controller_init(struct atmel_smc_nand_controller *nc)
return ret;
}
- nc->ebi_csa_offs = (unsigned int)match->data;
+ nc->ebi_csa_offs = (uintptr_t)match->data;
/*
* The at91sam9263 has 2 EBIs, if the NAND controller is under EBI1
--
2.9.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] mtd: sunxi_nand: fix build warning
2018-07-09 15:57 [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Arnd Bergmann
2018-07-09 15:57 ` [PATCH 2/3] mtd: atmel nand: fix build warning " Arnd Bergmann
@ 2018-07-09 15:57 ` Arnd Bergmann
2018-07-09 16:12 ` [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Boris Brezillon
2 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2018-07-09 15:57 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Maxime Ripard,
Chen-Yu Tsai, Masahiro Yamada, Vladimir Zapolskiy,
H Hartley Sweeten, Bryan O'Donoghue, Philipp Zabel,
linux-mtd, linux-arm-kernel, linux-kernel
build-testing this driver on x86 shows a new warning:
Fixes: b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y")
drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_read_chunks_dma':
drivers/mtd/nand/raw/sunxi_nand.c:130:22: error: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744071631273984' to '2216689664' [-Werror=overflow]
#define NFC_PAGE_OP (2 << 30)
drivers/mtd/nand/raw/sunxi_nand.c:1040:9: note: in expansion of macro 'NFC_PAGE_OP'
writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | NFC_DATA_TRANS,
^~~~~~~~~~~
drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_write_page_dma':
drivers/mtd/nand/raw/sunxi_nand.c:130:22: error: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744071632322560' to '2217738240' [-Werror=overflow]
#define NFC_PAGE_OP (2 << 30)
drivers/mtd/nand/raw/sunxi_nand.c:1406:9: note: in expansion of macro 'NFC_PAGE_OP'
writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD |
This is easy to avoid by ensuring that the constants are 'unsigned'.
Fixes: b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/raw/sunxi_nand.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index d831a141a196..fa5c48502fa8 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -125,9 +125,9 @@
#define NFC_SEND_CMD3 BIT(28)
#define NFC_SEND_CMD4 BIT(29)
#define NFC_CMD_TYPE_MSK GENMASK(31, 30)
-#define NFC_NORMAL_OP (0 << 30)
-#define NFC_ECC_OP (1 << 30)
-#define NFC_PAGE_OP (2 << 30)
+#define NFC_NORMAL_OP (0u << 30)
+#define NFC_ECC_OP (1u << 30)
+#define NFC_PAGE_OP (2u << 30)
/* define bit use in NFC_RCMD_SET */
#define NFC_READ_CMD_MSK GENMASK(7, 0)
--
2.9.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit
2018-07-09 15:57 [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Arnd Bergmann
2018-07-09 15:57 ` [PATCH 2/3] mtd: atmel nand: fix build warning " Arnd Bergmann
2018-07-09 15:57 ` [PATCH 3/3] mtd: sunxi_nand: fix build warning Arnd Bergmann
@ 2018-07-09 16:12 ` Boris Brezillon
2 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2018-07-09 16:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Sekhar Nori, Gregory CLEMENT, Alexander Sverdlin,
Bartosz Golaszewski, linux-mtd, linux-kernel
Hi Arnd,
On Mon, 9 Jul 2018 17:57:02 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> Now that we can build this driver everywhere, we run into a couple
> of warnings like:
>
> drivers/mtd/nand/raw/davinci_nand.c: In function 'nand_davinci_correct_4bit':
> drivers/mtd/nand/raw/davinci_nand.c:322:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>
> In all cases, this is harmless and we just need to cast to an uintptr_t
> rather than an unsigned 32-bit integer.
>
> Fixes: 347af8918e8a ("mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Actually, I have all those fixes in my nand/api-cleanup branch [1]. I
was planning on sending a v2 of my COMPILE_TEST series to address
those problems before activating COMPILE_TEST on those drivers (Miquel
already dropped the patches activating COMPILE_TEST on sunxi, davinci
and atmel).
Regards,
Boris
[1]https://github.com/bbrezillon/linux-0day/commits/nand/api-cleanup
> ---
> drivers/mtd/nand/raw/davinci_nand.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
> index cd12e5abafde..c638bd60eb0b 100644
> --- a/drivers/mtd/nand/raw/davinci_nand.c
> +++ b/drivers/mtd/nand/raw/davinci_nand.c
> @@ -102,7 +102,7 @@ static void nand_davinci_hwcontrol(struct mtd_info *mtd, int cmd,
> unsigned int ctrl)
> {
> struct davinci_nand_info *info = to_davinci_nand(mtd);
> - uint32_t addr = info->current_cs;
> + uintptr_t addr = info->current_cs;
> struct nand_chip *nand = mtd_to_nand(mtd);
>
> /* Did the control lines change? */
> @@ -122,7 +122,7 @@ static void nand_davinci_hwcontrol(struct mtd_info *mtd, int cmd,
> static void nand_davinci_select_chip(struct mtd_info *mtd, int chip)
> {
> struct davinci_nand_info *info = to_davinci_nand(mtd);
> - uint32_t addr = info->ioaddr;
> + uintptr_t addr = info->ioaddr;
>
> /* maybe kick in a second chipselect */
> if (chip > 0)
> @@ -319,7 +319,7 @@ static int nand_davinci_correct_4bit(struct mtd_info *mtd,
> /* Unpack ten bytes into eight 10 bit values. We know we're
> * little-endian, and use type punning for less shifting/masking.
> */
> - if (WARN_ON(0x01 & (unsigned) ecc_code))
> + if (WARN_ON(0x01 & (uintptr_t)ecc_code))
> return -EINVAL;
> ecc16 = (unsigned short *)ecc_code;
>
> @@ -441,9 +441,9 @@ static void nand_davinci_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
> {
> struct nand_chip *chip = mtd_to_nand(mtd);
>
> - if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
> + if ((0x03 & ((uintptr_t)buf)) == 0 && (0x03 & len) == 0)
> ioread32_rep(chip->IO_ADDR_R, buf, len >> 2);
> - else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
> + else if ((0x01 & ((uintptr_t)buf)) == 0 && (0x01 & len) == 0)
> ioread16_rep(chip->IO_ADDR_R, buf, len >> 1);
> else
> ioread8_rep(chip->IO_ADDR_R, buf, len);
> @@ -454,9 +454,9 @@ static void nand_davinci_write_buf(struct mtd_info *mtd,
> {
> struct nand_chip *chip = mtd_to_nand(mtd);
>
> - if ((0x03 & ((unsigned)buf)) == 0 && (0x03 & len) == 0)
> + if ((0x03 & ((uintptr_t)buf)) == 0 && (0x03 & len) == 0)
> iowrite32_rep(chip->IO_ADDR_R, buf, len >> 2);
> - else if ((0x01 & ((unsigned)buf)) == 0 && (0x01 & len) == 0)
> + else if ((0x01 & ((uintptr_t)buf)) == 0 && (0x01 & len) == 0)
> iowrite16_rep(chip->IO_ADDR_R, buf, len >> 1);
> else
> iowrite8_rep(chip->IO_ADDR_R, buf, len);
> @@ -680,7 +680,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
> info->chip.bbt_md = pdata->bbt_md;
> info->timing = pdata->timing;
>
> - info->ioaddr = (uint32_t __force) vaddr;
> + info->ioaddr = (uintptr_t __force) vaddr;
>
> info->current_cs = info->ioaddr;
> info->core_chipsel = pdata->core_chipsel;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-09 15:57 ` [PATCH 2/3] mtd: atmel nand: fix build warning " Arnd Bergmann
@ 2018-07-13 9:56 ` Tudor Ambarus
2018-07-13 10:16 ` Arnd Bergmann
0 siblings, 1 reply; 9+ messages in thread
From: Tudor Ambarus @ 2018-07-13 9:56 UTC (permalink / raw)
To: Arnd Bergmann, Boris Brezillon
Cc: Alexandre Belloni, Wenyou Yang, Masahiro Yamada,
Richard Weinberger, Gregory CLEMENT, Miquel Raynal, linux-kernel,
Marek Vasut, linux-mtd, Josh Wu, Romain Izard, Brian Norris,
David Woodhouse, Peter Rosin, linux-arm-kernel
Hi, Arnd,
On 07/09/2018 06:57 PM, Arnd Bergmann wrote:
> + nc->ebi_csa_offs = (uintptr_t)match->data;
I guess we should declare ebi_csa_offs as size_t, right?
Best,
ta
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-13 9:56 ` Tudor Ambarus
@ 2018-07-13 10:16 ` Arnd Bergmann
2018-07-17 21:05 ` Miquel Raynal
0 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2018-07-13 10:16 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Boris Brezillon, Alexandre Belloni, Wenyou Yang, Masahiro Yamada,
Richard Weinberger, Gregory CLEMENT, Miquel Raynal,
Linux Kernel Mailing List, Marek Vasut, linux-mtd, Josh Wu,
Romain Izard, Brian Norris, David Woodhouse, Peter Rosin,
Linux ARM
On Fri, Jul 13, 2018 at 11:56 AM, Tudor Ambarus
<tudor.ambarus@microchip.com> wrote:
> Hi, Arnd,
>
> On 07/09/2018 06:57 PM, Arnd Bergmann wrote:
>> + nc->ebi_csa_offs = (uintptr_t)match->data;
>
> I guess we should declare ebi_csa_offs as size_t, right?
Yes, that would make sense, though it doesn't change the behavior.
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-13 10:16 ` Arnd Bergmann
@ 2018-07-17 21:05 ` Miquel Raynal
2018-07-17 21:08 ` Boris Brezillon
0 siblings, 1 reply; 9+ messages in thread
From: Miquel Raynal @ 2018-07-17 21:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tudor Ambarus, Boris Brezillon, Alexandre Belloni, Wenyou Yang,
Masahiro Yamada, Richard Weinberger, Gregory CLEMENT,
Linux Kernel Mailing List, Marek Vasut, linux-mtd, Josh Wu,
Romain Izard, Brian Norris, David Woodhouse, Peter Rosin,
Linux ARM
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> wrote on Fri, 13 Jul 2018 12:16:09 +0200:
> On Fri, Jul 13, 2018 at 11:56 AM, Tudor Ambarus
> <tudor.ambarus@microchip.com> wrote:
> > Hi, Arnd,
> >
> > On 07/09/2018 06:57 PM, Arnd Bergmann wrote:
> >> + nc->ebi_csa_offs = (uintptr_t)match->data;
> >
> > I guess we should declare ebi_csa_offs as size_t, right?
>
> Yes, that would make sense, though it doesn't change the behavior.
>
Do you plan to send a new version? I don't want to mess with
improvised casts :)
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-17 21:05 ` Miquel Raynal
@ 2018-07-17 21:08 ` Boris Brezillon
2018-07-18 6:56 ` Miquel Raynal
0 siblings, 1 reply; 9+ messages in thread
From: Boris Brezillon @ 2018-07-17 21:08 UTC (permalink / raw)
To: Miquel Raynal
Cc: Arnd Bergmann, Tudor Ambarus, Alexandre Belloni, Wenyou Yang,
Masahiro Yamada, Richard Weinberger, Gregory CLEMENT,
Linux Kernel Mailing List, Marek Vasut, linux-mtd, Josh Wu,
Romain Izard, Brian Norris, David Woodhouse, Peter Rosin,
Linux ARM
On Tue, 17 Jul 2018 23:05:23 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Arnd,
>
> Arnd Bergmann <arnd@arndb.de> wrote on Fri, 13 Jul 2018 12:16:09 +0200:
>
> > On Fri, Jul 13, 2018 at 11:56 AM, Tudor Ambarus
> > <tudor.ambarus@microchip.com> wrote:
> > > Hi, Arnd,
> > >
> > > On 07/09/2018 06:57 PM, Arnd Bergmann wrote:
> > >> + nc->ebi_csa_offs = (uintptr_t)match->data;
> > >
> > > I guess we should declare ebi_csa_offs as size_t, right?
> >
> > Yes, that would make sense, though it doesn't change the behavior.
> >
>
> Do you plan to send a new version? I don't want to mess with
> improvised casts :)
This fix is already part of my COMPILE_TEST series (v2), and I don't
thing declaring ->ebi_csa_offs as a size_t is useful.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit
2018-07-17 21:08 ` Boris Brezillon
@ 2018-07-18 6:56 ` Miquel Raynal
0 siblings, 0 replies; 9+ messages in thread
From: Miquel Raynal @ 2018-07-18 6:56 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Tudor Ambarus, Alexandre Belloni, Wenyou Yang,
Masahiro Yamada, Richard Weinberger, Gregory CLEMENT,
Linux Kernel Mailing List, Marek Vasut, linux-mtd, Josh Wu,
Romain Izard, Brian Norris, David Woodhouse, Peter Rosin,
Linux ARM
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Tue, 17 Jul 2018
23:08:39 +0200:
> On Tue, 17 Jul 2018 23:05:23 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Hi Arnd,
> >
> > Arnd Bergmann <arnd@arndb.de> wrote on Fri, 13 Jul 2018 12:16:09 +0200:
> >
> > > On Fri, Jul 13, 2018 at 11:56 AM, Tudor Ambarus
> > > <tudor.ambarus@microchip.com> wrote:
> > > > Hi, Arnd,
> > > >
> > > > On 07/09/2018 06:57 PM, Arnd Bergmann wrote:
> > > >> + nc->ebi_csa_offs = (uintptr_t)match->data;
> > > >
> > > > I guess we should declare ebi_csa_offs as size_t, right?
> > >
> > > Yes, that would make sense, though it doesn't change the behavior.
> > >
> >
> > Do you plan to send a new version? I don't want to mess with
> > improvised casts :)
>
> This fix is already part of my COMPILE_TEST series (v2), and I don't
> thing declaring ->ebi_csa_offs as a size_t is useful.
I missed that, ok.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-18 6:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 15:57 [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Arnd Bergmann
2018-07-09 15:57 ` [PATCH 2/3] mtd: atmel nand: fix build warning " Arnd Bergmann
2018-07-13 9:56 ` Tudor Ambarus
2018-07-13 10:16 ` Arnd Bergmann
2018-07-17 21:05 ` Miquel Raynal
2018-07-17 21:08 ` Boris Brezillon
2018-07-18 6:56 ` Miquel Raynal
2018-07-09 15:57 ` [PATCH 3/3] mtd: sunxi_nand: fix build warning Arnd Bergmann
2018-07-09 16:12 ` [PATCH 1/3] mtd: rawnand: davinci: fix build testing on 64-bit Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).