From: kbuild test robot <lkp@intel.com>
To: Daniel Klamt <eleon@ele0n.de>
Cc: kbuild-all@01.org, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de,
Daniel Klamt <eleon@ele0n.de>, Bjoern Noetel <bjoern@br3ak3r.de>
Subject: Re: [PATCH] powerpc: Replaced msleep with usleep_range
Date: Tue, 10 Jul 2018 04:07:50 +0800 [thread overview]
Message-ID: <201807100423.0p0r9QGb%fengguang.wu@intel.com> (raw)
In-Reply-To: <1531144679-31675-1-git-send-email-eleon@ele0n.de>
[-- Attachment #1: Type: text/plain, Size: 2614 bytes --]
Hi Daniel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc4 next-20180709]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Daniel-Klamt/powerpc-Replaced-msleep-with-usleep_range/20180709-231913
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
arch/powerpc/sysdev/xive/native.c: In function 'xive_native_configure_irq':
>> arch/powerpc/sysdev/xive/native.c:113:2: error: expected ';' before '}' token
}
^
vim +113 arch/powerpc/sysdev/xive/native.c
243e2511 Benjamin Herrenschmidt 2017-04-05 103
243e2511 Benjamin Herrenschmidt 2017-04-05 104 int xive_native_configure_irq(u32 hw_irq, u32 target, u8 prio, u32 sw_irq)
243e2511 Benjamin Herrenschmidt 2017-04-05 105 {
243e2511 Benjamin Herrenschmidt 2017-04-05 106 s64 rc;
243e2511 Benjamin Herrenschmidt 2017-04-05 107
243e2511 Benjamin Herrenschmidt 2017-04-05 108 for (;;) {
243e2511 Benjamin Herrenschmidt 2017-04-05 109 rc = opal_xive_set_irq_config(hw_irq, target, prio, sw_irq);
243e2511 Benjamin Herrenschmidt 2017-04-05 110 if (rc != OPAL_BUSY)
243e2511 Benjamin Herrenschmidt 2017-04-05 111 break;
c332c793 Daniel Klamt 2018-07-09 112 usleep_range(1000, 1100)
243e2511 Benjamin Herrenschmidt 2017-04-05 @113 }
243e2511 Benjamin Herrenschmidt 2017-04-05 114 return rc == 0 ? 0 : -ENXIO;
243e2511 Benjamin Herrenschmidt 2017-04-05 115 }
5af50993 Benjamin Herrenschmidt 2017-04-05 116 EXPORT_SYMBOL_GPL(xive_native_configure_irq);
5af50993 Benjamin Herrenschmidt 2017-04-05 117
243e2511 Benjamin Herrenschmidt 2017-04-05 118
:::::: The code at line 113 was first introduced by commit
:::::: 243e25112d06b348f087a6f7aba4bbc288285bdd powerpc/xive: Native exploitation of the XIVE interrupt controller
:::::: TO: Benjamin Herrenschmidt <benh@kernel.crashing.org>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23386 bytes --]
next prev parent reply other threads:[~2018-07-09 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:57 [PATCH] powerpc: Replaced msleep with usleep_range Daniel Klamt
2018-07-09 20:07 ` kbuild test robot [this message]
2018-07-10 13:57 ` Michael Ellerman
2018-07-09 23:52 ` Benjamin Herrenschmidt
2018-07-11 14:13 ` Michael Ellerman
2018-07-11 22:03 ` [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS) Daniel Klamt
2018-07-12 5:46 ` Michael Ellerman
2018-07-12 7:58 ` Nicholas Piggin
2018-07-19 6:07 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807100423.0p0r9QGb%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=benh@kernel.crashing.org \
--cc=bjoern@br3ak3r.de \
--cc=eleon@ele0n.de \
--cc=kbuild-all@01.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).