From: Nicholas Piggin <npiggin@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Daniel Klamt <eleon@ele0n.de>,
benh@kernel.crashing.org, linux-kernel@i4.cs.fau.de,
linux-kernel@vger.kernel.org, paulus@samba.org,
Bjoern Noetel <bjoern@br3ak3r.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS)
Date: Thu, 12 Jul 2018 17:58:05 +1000 [thread overview]
Message-ID: <20180712175805.263898e2@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <87bmbd80rl.fsf@concordia.ellerman.id.au>
On Thu, 12 Jul 2018 15:46:06 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Daniel Klamt <eleon@ele0n.de> writes:
>
> > Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS)
> > to diocument these sleep is to wait for opal.
> >
> > Signed-off-by: Daniel Klamt <eleon@ele0n.de>
> > Signed-off-by: Bjoern Noetel <bjoern@br3ak3r.de>
>
> Thanks.
>
> Your change log should be in the imperative mood, see:
>
> https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133
>
>
> In this case that just means saying "Replace" rather than "Replaced".
>
> Also the prefix should be "powerpc/xive". You can guess that by doing:
>
> $ git log --oneline arch/powerpc/sysdev/xive/native.c
>
> And notice that the majority of commits use that prefix.
>
>
> I've fixed both of those things up for you.
Sorry, just noticed this. I've got a patch which changes the xive stuff
to the "standard" format this will clash with.
if (rc == OPAL_BUSY_EVENT) {
msleep(OPAL_BUSY_DELAY_MS);
opal_poll_events(NULL);
} else if (rc == OPAL_BUSY) {
msleep(OPAL_BUSY_DELAY_MS);
}
If it's already merged that's fine, I can rebase.
Thanks,
Nick
next prev parent reply other threads:[~2018-07-12 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:57 [PATCH] powerpc: Replaced msleep with usleep_range Daniel Klamt
2018-07-09 20:07 ` kbuild test robot
2018-07-10 13:57 ` Michael Ellerman
2018-07-09 23:52 ` Benjamin Herrenschmidt
2018-07-11 14:13 ` Michael Ellerman
2018-07-11 22:03 ` [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS) Daniel Klamt
2018-07-12 5:46 ` Michael Ellerman
2018-07-12 7:58 ` Nicholas Piggin [this message]
2018-07-19 6:07 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712175805.263898e2@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bjoern@br3ak3r.de \
--cc=eleon@ele0n.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).