From: Tiwei Bie <tiwei.bie@intel.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtio-dev@lists.oasis-open.org, wexu@redhat.com,
jfreimann@redhat.com
Subject: Re: [PATCH net-next v1 5/5] virtio_ring: enable packed ring
Date: Wed, 11 Jul 2018 09:07:30 +0800 [thread overview]
Message-ID: <20180711010730.GA28235@debian> (raw)
In-Reply-To: <27ae72ad-247b-e8f0-aa37-a75a719e0e01@redhat.com>
On Tue, Jul 10, 2018 at 01:51:20PM +0800, Jason Wang wrote:
> On 2018年07月09日 15:22, Tiwei Bie wrote:
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > drivers/s390/virtio/virtio_ccw.c | 8 ++++++++
> > drivers/virtio/virtio_ring.c | 2 ++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> > index 8f5c1d7f751a..ff5b85736d8d 100644
> > --- a/drivers/s390/virtio/virtio_ccw.c
> > +++ b/drivers/s390/virtio/virtio_ccw.c
> > @@ -765,6 +765,11 @@ static u64 virtio_ccw_get_features(struct virtio_device *vdev)
> > return rc;
> > }
> > +static void ccw_transport_features(struct virtio_device *vdev)
> > +{
> > + __virtio_clear_bit(vdev, VIRTIO_F_RING_PACKED);
> > +}
>
> I think we need a better comment to explain why it was disabled here.
Yeah, I'll do it!
Best regards,
Tiwei Bie
>
> Thanks
>
> > +
> > static int virtio_ccw_finalize_features(struct virtio_device *vdev)
> > {
> > struct virtio_ccw_device *vcdev = to_vc_device(vdev);
> > @@ -791,6 +796,9 @@ static int virtio_ccw_finalize_features(struct virtio_device *vdev)
> > /* Give virtio_ring a chance to accept features. */
> > vring_transport_features(vdev);
> > + /* Give virtio_ccw a chance to accept features. */
> > + ccw_transport_features(vdev);
> > +
> > features->index = 0;
> > features->features = cpu_to_le32((u32)vdev->features);
> > /* Write the first half of the feature bits to the host. */
> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> > index 4b3f9e1a3cab..64f20023f088 100644
> > --- a/drivers/virtio/virtio_ring.c
> > +++ b/drivers/virtio/virtio_ring.c
> > @@ -1968,6 +1968,8 @@ void vring_transport_features(struct virtio_device *vdev)
> > break;
> > case VIRTIO_F_IOMMU_PLATFORM:
> > break;
> > + case VIRTIO_F_RING_PACKED:
> > + break;
> > default:
> > /* We don't understand this bit. */
> > __virtio_clear_bit(vdev, i);
>
prev parent reply other threads:[~2018-07-11 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 7:22 [PATCH net-next v1 0/5] virtio: support packed ring Tiwei Bie
2018-07-09 7:22 ` [PATCH net-next v1 1/5] virtio: add packed ring definitions Tiwei Bie
2018-07-09 7:22 ` [PATCH net-next v1 2/5] virtio_ring: support creating packed ring Tiwei Bie
2018-07-09 7:22 ` [PATCH net-next v1 3/5] virtio_ring: add packed ring support Tiwei Bie
2018-07-09 7:22 ` [PATCH net-next v1 4/5] virtio_ring: add event idx support in packed ring Tiwei Bie
2018-07-10 5:50 ` Jason Wang
2018-07-11 1:09 ` [virtio-dev] " Tiwei Bie
2018-07-09 7:22 ` [PATCH net-next v1 5/5] virtio_ring: enable " Tiwei Bie
2018-07-10 5:51 ` Jason Wang
2018-07-11 1:07 ` Tiwei Bie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711010730.GA28235@debian \
--to=tiwei.bie@intel.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).