* [PATCH] printk: remove unused suppress_message_printing()
@ 2018-07-10 15:22 Arnd Bergmann
2018-07-11 1:54 ` Sergey Senozhatsky
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-10 15:22 UTC (permalink / raw)
To: Petr Mladek, Sergey Senozhatsky
Cc: Arnd Bergmann, Steven Rostedt, Dave Young, Namit Gupta,
Nikitas Angelinas, linux-kernel
Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK'
section means that the alternative definition is now unused when PRINTK is
disabled:
kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function]
This removes the stub function.
Fixes: 375899cddcbb ("printk: make sure to print log on console.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/printk/printk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 4ca0f9bca82c..e015ac4ee367 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2030,8 +2030,6 @@ static void call_console_drivers(const char *ext_text, size_t ext_len,
const char *text, size_t len) {}
static size_t msg_print_text(const struct printk_log *msg,
bool syslog, char *buf, size_t size) { return 0; }
-static bool suppress_message_printing(int level) { return false; }
-
#endif /* CONFIG_PRINTK */
#ifdef CONFIG_EARLY_PRINTK
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] printk: remove unused suppress_message_printing()
2018-07-10 15:22 [PATCH] printk: remove unused suppress_message_printing() Arnd Bergmann
@ 2018-07-11 1:54 ` Sergey Senozhatsky
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2018-07-11 1:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Petr Mladek, Sergey Senozhatsky, Steven Rostedt, Dave Young,
Namit Gupta, Nikitas Angelinas, linux-kernel
On (07/10/18 17:22), Arnd Bergmann wrote:
> Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK'
> section means that the alternative definition is now unused when PRINTK is
> disabled:
>
> kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function]
>
> This removes the stub function.
>
> Fixes: 375899cddcbb ("printk: make sure to print log on console.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Arnd, thanks for the patch. I think we got the same report yesterday
(0-day build bot) and Petr have addressed the warning already.
-ss
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-11 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10 15:22 [PATCH] printk: remove unused suppress_message_printing() Arnd Bergmann
2018-07-11 1:54 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).