From: Baoquan He <bhe@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, pasha.tatashin@oracle.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
Date: Wed, 11 Jul 2018 21:12:25 +0800 [thread overview]
Message-ID: <20180711131225.GI1969@MiWiFi-R3L-srv> (raw)
In-Reply-To: <87lgai9bt5.fsf@concordia.ellerman.id.au>
Hi Michael,
On 07/11/18 at 10:49pm, Michael Ellerman wrote:
> akpm@linux-foundation.org writes:
> > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> ...
>
> > * mm-sparse-add-a-static-variable-nr_present_sections.patch
> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch
> > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
> > * mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch
> > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch
> > * mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
>
> > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch
>
> This seems to be breaking my powerpc pseries qemu boots.
>
> The boot log with some extra debug shows eg:
>
> $ make pseries_le_defconfig
> $ qemu-system-ppc64 -nographic -vga none -M pseries -m 2G -kernel vmlinux
> vmemmap_populate f000000000000000..f000000000024000, node 0
> * f000000000000000..f000000001000000 allocated at c000000076000000
> hash__vmemmap_create_mapping: start 0xf000000000000000 size 0x1000000 phys 0x76000000
> hash__vmemmap_create_mapping: failed -1
>
> <repeated many times>
>
> Then there's lots of other warnings about bad page states and eventually
> a NULL deref and we panic().
>
>
> The problem seems to be that we're calling down into
> hash__vmemmap_create_mapping() for every call to vmemmap_populate(),
> whereas previously we would only call hash__vmemmap_create_mapping()
> once because our vmemmap_populated() would return true.
>
> There's actually a comment in sparse_init() that says:
>
> * powerpc need to call sparse_init_one_section right after each
> * sparse_early_mem_map_alloc, so allocate usemap_map at first.
>
> So changing that behaviour does seem to be the problem.
>
> I assume that comment is talking about the fact that we use pfn_valid()
> in vmemmap_populated().
>
> I'm not clear on how to fix it though.
Have you tried reverting that patch and building kernel to test again?
Does it work?
next prev parent reply other threads:[~2018-07-11 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 23:50 mmotm 2018-07-10-16-50 uploaded akpm
2018-07-11 12:49 ` Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded) Michael Ellerman
2018-07-11 13:12 ` Baoquan He [this message]
2018-07-12 4:29 ` Michael Ellerman
2018-07-11 13:37 ` Oscar Salvador
2018-07-11 13:55 ` Pavel Tatashin
2018-07-11 21:13 ` Andrew Morton
2018-07-11 23:47 ` Stephen Rothwell
2018-07-12 6:55 ` Stephen Rothwell
[not found] ` <CAOXBz7ixEK85S-029XrM4+g4fxtSY6_tke0gcQ-hOXFCb7wcZg@mail.gmail.com>
2018-07-12 5:24 ` Michael Ellerman
2018-07-12 9:50 ` Oscar Salvador
2018-07-12 15:09 ` Pavel Tatashin
2018-07-12 4:36 ` Michael Ellerman
2018-07-12 6:01 ` mmotm 2018-07-10-16-50 uploaded (gpio: gpio-mt721.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711131225.GI1969@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=broonie@kernel.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pasha.tatashin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).