From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: osalvador@techadventures.net
Cc: mpe@ellerman.id.au, osalvador.vilardaga@gmail.com,
Andrew Morton <akpm@linux-foundation.org>,
broonie@kernel.org, mhocko@suse.cz,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
mm-commits@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
bhe@redhat.com, aneesh.kumar@linux.ibm.com,
khandual@linux.vnet.ibm.com
Subject: Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded)
Date: Thu, 12 Jul 2018 11:09:20 -0400 [thread overview]
Message-ID: <CAGM2reb=KeLH7KKUP+7-u27nJxvTcBskhtS2cDH8SwiiEZ1jNQ@mail.gmail.com> (raw)
In-Reply-To: <20180712095002.GA5342@techadventures.net>
On Thu, Jul 12, 2018 at 5:50 AM Oscar Salvador
<osalvador@techadventures.net> wrote:
>
> > > I just roughly check, but if I checked the right place,
> > > vmemmap_populated() checks for the section to contain the flags we are
> > > setting in sparse_init_one_section().
> >
> > Yes.
> >
> > > But with this patch, we populate first everything, and then we call
> > > sparse_init_one_section() in sparse_init().
> > > As I said I could be mistaken because I just checked the surface.
Yes, this is right, sparse_init_one_section() is needed after every
populate call on ppc64. I am adding this to my sparse_init re-write,
and it actually simplifies code, as it avoids one extra loop, and
makes ppc64 to work.
Pavel
next prev parent reply other threads:[~2018-07-12 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 23:50 mmotm 2018-07-10-16-50 uploaded akpm
2018-07-11 12:49 ` Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded) Michael Ellerman
2018-07-11 13:12 ` Baoquan He
2018-07-12 4:29 ` Michael Ellerman
2018-07-11 13:37 ` Oscar Salvador
2018-07-11 13:55 ` Pavel Tatashin
2018-07-11 21:13 ` Andrew Morton
2018-07-11 23:47 ` Stephen Rothwell
2018-07-12 6:55 ` Stephen Rothwell
[not found] ` <CAOXBz7ixEK85S-029XrM4+g4fxtSY6_tke0gcQ-hOXFCb7wcZg@mail.gmail.com>
2018-07-12 5:24 ` Michael Ellerman
2018-07-12 9:50 ` Oscar Salvador
2018-07-12 15:09 ` Pavel Tatashin [this message]
2018-07-12 4:36 ` Michael Ellerman
2018-07-12 6:01 ` mmotm 2018-07-10-16-50 uploaded (gpio: gpio-mt721.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reb=KeLH7KKUP+7-u27nJxvTcBskhtS2cDH8SwiiEZ1jNQ@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bhe@redhat.com \
--cc=broonie@kernel.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=osalvador.vilardaga@gmail.com \
--cc=osalvador@techadventures.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).