linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx
@ 2018-07-11  0:58 Anson Huang
  2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Anson Huang @ 2018-07-11  0:58 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
	mturquette, sboyd, shengjiu.wang, linux-arm-kernel, devicetree,
	linux-kernel, linux-clk
  Cc: Linux-imx

i.MX6SX has a 16KB always-on ocram bank called
ocram_s, and its clock gate in CCM CCGR1 CG14
needs to be enabled before access, add it to
clock tree.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	remove redefinition of IMX6SX_CLK_OCRAM_S to avoid build warning
 drivers/clk/imx/clk-imx6sx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c
index 10c771b..691db26 100644
--- a/drivers/clk/imx/clk-imx6sx.c
+++ b/drivers/clk/imx/clk-imx6sx.c
@@ -411,6 +411,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
 	clks[IMX6SX_CLK_GPT_BUS]      = imx_clk_gate2("gpt_bus",       "perclk",            base + 0x6c, 20);
 	clks[IMX6SX_CLK_GPT_SERIAL]   = imx_clk_gate2("gpt_serial",    "perclk",            base + 0x6c, 22);
 	clks[IMX6SX_CLK_GPU]          = imx_clk_gate2("gpu",           "gpu_core_podf",     base + 0x6c, 26);
+	clks[IMX6SX_CLK_OCRAM_S]      = imx_clk_gate2("ocram_s",       "ahb",               base + 0x6c, 28);
 	clks[IMX6SX_CLK_CANFD]        = imx_clk_gate2("canfd",         "can_podf",          base + 0x6c, 30);
 
 	/* CCGR2 */
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support
  2018-07-11  0:58 [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Anson Huang
@ 2018-07-11  0:58 ` Anson Huang
  2018-07-11  2:18   ` Fabio Estevam
  2018-07-11 13:14   ` Shawn Guo
  2018-07-11  2:17 ` [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Fabio Estevam
  2018-07-25 16:46 ` Stephen Boyd
  2 siblings, 2 replies; 6+ messages in thread
From: Anson Huang @ 2018-07-11  0:58 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
	mturquette, sboyd, shengjiu.wang, linux-arm-kernel, devicetree,
	linux-kernel, linux-clk
  Cc: Linux-imx

i.MX6SX has a 16KB always-on ocram bank called
ocram_s, enable it as another mmio sram.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	resort the ocram_s and ocram node by address from low to high.
 arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 596763c..f4d982c 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -166,6 +166,12 @@
 		interrupt-parent = <&gpc>;
 		ranges;
 
+		ocram_s: sram@8f8000 {
+			compatible = "mmio-sram";
+			reg = <0x008f8000 0x4000>;
+			clocks = <&clks IMX6SX_CLK_OCRAM_S>;
+		};
+
 		ocram: sram@900000 {
 			compatible = "mmio-sram";
 			reg = <0x00900000 0x20000>;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx
  2018-07-11  0:58 [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Anson Huang
  2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
@ 2018-07-11  2:17 ` Fabio Estevam
  2018-07-25 16:46 ` Stephen Boyd
  2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-07-11  2:17 UTC (permalink / raw)
  To: Anson Huang
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland, Michael Turquette, Stephen Boyd,
	S.j. Wang,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, linux-clk, NXP Linux Team

On Tue, Jul 10, 2018 at 9:58 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> i.MX6SX has a 16KB always-on ocram bank called
> ocram_s, and its clock gate in CCM CCGR1 CG14
> needs to be enabled before access, add it to
> clock tree.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support
  2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
@ 2018-07-11  2:18   ` Fabio Estevam
  2018-07-11 13:14   ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-07-11  2:18 UTC (permalink / raw)
  To: Anson Huang
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland, Michael Turquette, Stephen Boyd,
	S.j. Wang,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, linux-clk, NXP Linux Team

On Tue, Jul 10, 2018 at 9:58 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> i.MX6SX has a 16KB always-on ocram bank called
> ocram_s, enable it as another mmio sram.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support
  2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
  2018-07-11  2:18   ` Fabio Estevam
@ 2018-07-11 13:14   ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-07-11 13:14 UTC (permalink / raw)
  To: Anson Huang
  Cc: s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
	mturquette, sboyd, shengjiu.wang, linux-arm-kernel, devicetree,
	linux-kernel, linux-clk, Linux-imx

On Wed, Jul 11, 2018 at 08:58:59AM +0800, Anson Huang wrote:
> i.MX6SX has a 16KB always-on ocram bank called
> ocram_s, enable it as another mmio sram.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Since the clock ID has already been defined before, this dts patch can
be applied independently to clock driver one.

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx
  2018-07-11  0:58 [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Anson Huang
  2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
  2018-07-11  2:17 ` [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Fabio Estevam
@ 2018-07-25 16:46 ` Stephen Boyd
  2 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2018-07-25 16:46 UTC (permalink / raw)
  To: Anson Huang, devicetree, fabio.estevam, kernel, linux-arm-kernel,
	linux-clk, linux-kernel, mark.rutland, mturquette, robh+dt,
	s.hauer, shawnguo, shengjiu.wang
  Cc: Linux-imx

Quoting Anson Huang (2018-07-10 17:58:58)
> i.MX6SX has a 16KB always-on ocram bank called
> ocram_s, and its clock gate in CCM CCGR1 CG14
> needs to be enabled before access, add it to
> clock tree.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---

Applied to clk-next


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-25 16:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11  0:58 [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Anson Huang
2018-07-11  0:58 ` [PATCH V2 2/2] ARM: dts: imx6sx: add ocram_s support Anson Huang
2018-07-11  2:18   ` Fabio Estevam
2018-07-11 13:14   ` Shawn Guo
2018-07-11  2:17 ` [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx Fabio Estevam
2018-07-25 16:46 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).