* [PATCH] time: hrtimer: Improve kernel message printing
@ 2018-07-12 14:41 Geert Uytterhoeven
2018-07-12 19:33 ` [tip:timers/core] " tip-bot for Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-07-12 14:41 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, Geert Uytterhoeven
- Join split message for easier grepping,
- Use pr_*() instead of printk*(),
- Use %u to format unsigned cpu numbers.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
kernel/time/hrtimer.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 3e93c54bd3a16b7f..e1a549c9e3991830 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -718,8 +718,8 @@ static void hrtimer_switch_to_hres(void)
struct hrtimer_cpu_base *base = this_cpu_ptr(&hrtimer_bases);
if (tick_init_highres()) {
- printk(KERN_WARNING "Could not switch to high resolution "
- "mode on CPU %d\n", base->cpu);
+ pr_warn("Could not switch to high resolution mode on CPU %u\n",
+ base->cpu);
return;
}
base->hres_active = 1;
@@ -1573,8 +1573,7 @@ void hrtimer_interrupt(struct clock_event_device *dev)
else
expires_next = ktime_add(now, delta);
tick_program_event(expires_next, 1);
- printk_once(KERN_WARNING "hrtimer: interrupt took %llu ns\n",
- ktime_to_ns(delta));
+ pr_warn_once("hrtimer: interrupt took %llu ns\n", ktime_to_ns(delta));
}
/* called with interrupts disabled */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:timers/core] hrtimer: Improve kernel message printing
2018-07-12 14:41 [PATCH] time: hrtimer: Improve kernel message printing Geert Uytterhoeven
@ 2018-07-12 19:33 ` tip-bot for Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Geert Uytterhoeven @ 2018-07-12 19:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, tglx, geert+renesas, hpa, linux-kernel
Commit-ID: 7a6e55375d5c584c7c11cfdcaa8ad9d6cccb419d
Gitweb: https://git.kernel.org/tip/7a6e55375d5c584c7c11cfdcaa8ad9d6cccb419d
Author: Geert Uytterhoeven <geert+renesas@glider.be>
AuthorDate: Thu, 12 Jul 2018 16:41:18 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 12 Jul 2018 21:29:30 +0200
hrtimer: Improve kernel message printing
- Join split message for easier grepping,
- Use pr_*() instead of printk*(),
- Use %u to format unsigned cpu numbers.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20180712144118.8819-1-geert+renesas@glider.be
---
kernel/time/hrtimer.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 055a4a728c00..5c2af16c7c14 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -718,8 +718,8 @@ static void hrtimer_switch_to_hres(void)
struct hrtimer_cpu_base *base = this_cpu_ptr(&hrtimer_bases);
if (tick_init_highres()) {
- printk(KERN_WARNING "Could not switch to high resolution "
- "mode on CPU %d\n", base->cpu);
+ pr_warn("Could not switch to high resolution mode on CPU %u\n",
+ base->cpu);
return;
}
base->hres_active = 1;
@@ -1573,8 +1573,7 @@ retry:
else
expires_next = ktime_add(now, delta);
tick_program_event(expires_next, 1);
- printk_once(KERN_WARNING "hrtimer: interrupt took %llu ns\n",
- ktime_to_ns(delta));
+ pr_warn_once("hrtimer: interrupt took %llu ns\n", ktime_to_ns(delta));
}
/* called with interrupts disabled */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-12 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 14:41 [PATCH] time: hrtimer: Improve kernel message printing Geert Uytterhoeven
2018-07-12 19:33 ` [tip:timers/core] " tip-bot for Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).