linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [linux-sunxi] Re: [PATCH 1/2] ARM: sun8i: h3: enable HDMI output on Banana Pi M2 Zero
Date: Fri, 13 Jul 2018 09:45:50 +0200	[thread overview]
Message-ID: <20180713074550.mna4nqbjringf2xn@flea.home> (raw)
In-Reply-To: <82CD0BCE-9DE4-45D7-8DF4-FCCFBC70BECF@aosc.io>

[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]

On Fri, Jul 13, 2018 at 10:28:08AM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2018年7月12日 GMT+08:00 下午10:53:06, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
> >On Thu, Jul 12, 2018 at 03:09:55PM +0800, Icenowy Zheng wrote:
> >> 于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard
> ><maxime.ripard@bootlin.com> 写到:
> >> >On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
> >> >> 
> >> >> 
> >> >> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
> >> ><maxime.ripard@bootlin.com> 写到:
> >> >> >Hi,
> >> >> >
> >> >> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> >> >> >> Banana Pi M2 Zero board has a miniHDMI port connected to the
> >HDMI
> >> >> >> controller of Allwinner H3 SoC.
> >> >> >> 
> >> >> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
> >> >> >> 
> >> >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> >> >> ---
> >> >> >>  .../dts/sun8i-h2-plus-bananapi-m2-zero.dts    | 25
> >> >> >+++++++++++++++++++
> >> >> >>  1 file changed, 25 insertions(+)
> >> >> >> 
> >> >> >> diff --git
> >a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> index 7d01f9322658..eb61dcf32797 100644
> >> >> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> @@ -26,6 +26,17 @@
> >> >> >>  		stdout-path = "serial0:115200n8";
> >> >> >>  	};
> >> >> >>  
> >> >> >> +	hdmi-connector {
> >> >> >> +		compatible = "hdmi-connector";
> >> >> >> +		type = "c";
> >> >> >
> >> >> >This is not one of the connector type declared in DRM, how is it
> >> >> >exposed to the userspace?
> >> >> 
> >> >> So just use "A" here (because of single link)?
> >> >
> >> >If the connector type is C, it should be C, and DRM / driver
> >adjusted
> >> >to handle it.
> >> 
> >> Okay I won't change this property, if there's any further revisions.
> >> 
> >> For DRM driver, I think it can be an independent patchset.
> >
> >Not really, since it's going to break userspace as soon as you merge
> >that other patchset.
> 
> Should we bother the DRM maintainer to ask for any advice?

You can if you want.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-07-13  7:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 13:22 [PATCH 0/2] Misc function enhance to Banana Pi M2 Zero board Icenowy Zheng
2018-07-11 13:22 ` [PATCH 1/2] ARM: sun8i: h3: enable HDMI output on Banana Pi M2 Zero Icenowy Zheng
2018-07-11 15:05   ` Maxime Ripard
2018-07-11 15:14     ` [linux-sunxi] " Jernej Škrabec
2018-07-11 15:19       ` Icenowy Zheng
2018-07-11 15:15     ` Icenowy Zheng
2018-07-12  6:46       ` Maxime Ripard
2018-07-12  7:09         ` Icenowy Zheng
2018-07-12 14:53           ` Maxime Ripard
2018-07-13  2:28             ` Icenowy Zheng
2018-07-13  7:45               ` Maxime Ripard [this message]
2018-07-18 22:13   ` [linux-sunxi] " Julian Calaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713074550.mna4nqbjringf2xn@flea.home \
    --to=maxime.ripard@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).