* [PATCH resend] staging: gasket: gasket_open use container_of()
@ 2018-07-15 18:37 Todd Poynor
0 siblings, 0 replies; only message in thread
From: Todd Poynor @ 2018-07-15 18:37 UTC (permalink / raw)
To: Rob Springer, John Joseph, Ben Chan, Greg Kroah-Hartman
Cc: Zhongze Hu, Simon Que, Dmitry Torokhov, Guenter Roeck, devel,
linux-kernel, Todd Poynor
From: Todd Poynor <toddpoynor@google.com>
Use container_of(), drop unnecessary NULL check.
Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
drivers/staging/gasket/gasket_core.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index 20da6bdb7a73..4ac239c33ea3 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1088,12 +1088,9 @@ static int gasket_open(struct inode *inode, struct file *filp)
const struct gasket_driver_desc *driver_desc;
struct gasket_ownership *ownership;
char task_name[TASK_COMM_LEN];
- struct gasket_cdev_info *dev_info = gasket_cdev_get_info(inode->i_cdev);
+ struct gasket_cdev_info *dev_info =
+ container_of(inode->i_cdev, struct gasket_cdev_info, cdev);
- if (!dev_info) {
- gasket_nodev_error("Unable to retrieve device data");
- return -EINVAL;
- }
gasket_dev = dev_info->gasket_dev_ptr;
driver_desc = gasket_dev->internal_desc->driver_desc;
ownership = &dev_info->ownership;
--
2.18.0.203.gfac676dfb9-goog
Resending, extracted from the previous stack of patches that needs
other cleanups.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-15 18:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-15 18:37 [PATCH resend] staging: gasket: gasket_open use container_of() Todd Poynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).