* [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation
@ 2018-07-13 3:02 YueHaibing
2018-07-13 5:42 ` Michael Chan
2018-07-16 20:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-07-13 3:02 UTC (permalink / raw)
To: michael.chan; +Cc: linux-kernel, netdev, davem, YueHaibing
hwrm_dbg_resp_addr and hwrm_dbg_resp_dma_addr are never used
and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 -------------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 4394c11..4db3180 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -3012,13 +3012,6 @@ static void bnxt_free_hwrm_resources(struct bnxt *bp)
bp->hwrm_cmd_resp_dma_addr);
bp->hwrm_cmd_resp_addr = NULL;
- if (bp->hwrm_dbg_resp_addr) {
- dma_free_coherent(&pdev->dev, HWRM_DBG_REG_BUF_SIZE,
- bp->hwrm_dbg_resp_addr,
- bp->hwrm_dbg_resp_dma_addr);
-
- bp->hwrm_dbg_resp_addr = NULL;
- }
}
static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
@@ -3030,12 +3023,6 @@ static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
GFP_KERNEL);
if (!bp->hwrm_cmd_resp_addr)
return -ENOMEM;
- bp->hwrm_dbg_resp_addr = dma_alloc_coherent(&pdev->dev,
- HWRM_DBG_REG_BUF_SIZE,
- &bp->hwrm_dbg_resp_dma_addr,
- GFP_KERNEL);
- if (!bp->hwrm_dbg_resp_addr)
- netdev_warn(bp->dev, "fail to alloc debug register dma mem\n");
return 0;
}
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 91575ef..934aa11 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -1287,9 +1287,6 @@ struct bnxt {
dma_addr_t hwrm_short_cmd_req_dma_addr;
void *hwrm_cmd_resp_addr;
dma_addr_t hwrm_cmd_resp_dma_addr;
- void *hwrm_dbg_resp_addr;
- dma_addr_t hwrm_dbg_resp_dma_addr;
-#define HWRM_DBG_REG_BUF_SIZE 128
struct rx_port_stats *hw_rx_port_stats;
struct tx_port_stats *hw_tx_port_stats;
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation
2018-07-13 3:02 [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation YueHaibing
@ 2018-07-13 5:42 ` Michael Chan
2018-07-16 20:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michael Chan @ 2018-07-13 5:42 UTC (permalink / raw)
To: YueHaibing; +Cc: open list, Netdev, David Miller
On Thu, Jul 12, 2018 at 8:02 PM, YueHaibing <yuehaibing@huawei.com> wrote:
> hwrm_dbg_resp_addr and hwrm_dbg_resp_dma_addr are never used
> and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks.
Acked-by: Michael Chan <michael.chan@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation
2018-07-13 3:02 [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation YueHaibing
2018-07-13 5:42 ` Michael Chan
@ 2018-07-16 20:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-16 20:38 UTC (permalink / raw)
To: yuehaibing; +Cc: michael.chan, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 13 Jul 2018 11:02:04 +0800
> hwrm_dbg_resp_addr and hwrm_dbg_resp_dma_addr are never used
> and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-16 20:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 3:02 [PATCH net-next] bnxt_en: remove redundant debug register dma mem allocation YueHaibing
2018-07-13 5:42 ` Michael Chan
2018-07-16 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).