From: David Rivshin <drivshin@awxrd.com>
To: Pavel Machek <pavel@ucw.cz>, Thierry Reding <thierry.reding@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Sebastian Reichel <sre@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net,
merlijn@wizzup.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm-omap: handle timers not ready in probe
Date: Mon, 16 Jul 2018 11:47:58 -0400 [thread overview]
Message-ID: <20180716114758.60a6a6cb.drivshin@awxrd.com> (raw)
In-Reply-To: <20180716083720.GA3047@amd>
On Mon, 16 Jul 2018 10:37:20 +0200
Pavel Machek <pavel@ucw.cz> wrote:
> On Mon 2018-07-16 00:57:40, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [180716 07:16]:
> > >
> > > When all the drivers are built-in, timers are not ready and probing
> > > fails. Fix that with -EPROBE_DEFFER.
> > >
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > >
> > > diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
> > > index 665da3c..debeb70 100644
> > > --- a/drivers/pwm/pwm-omap-dmtimer.c
> > > +++ b/drivers/pwm/pwm-omap-dmtimer.c
> > > @@ -265,7 +271,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
> > > timer_pdata = dev_get_platdata(&timer_pdev->dev);
> > > if (!timer_pdata) {
> > > dev_err(&pdev->dev, "dmtimer pdata structure NULL\n");
> > > - ret = -EINVAL;
> > > + ret = -EPROBE_DEFER;
> > > goto put;
> > > }
> >
> > There seems to be an earlier similar patch, care to take a look
> > at "[PATCH] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no
> > dmtimer platform data"?
>
> Yes, that one is equivalent.
>
> You can add
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Tested-by: Pavel Machek <pavel@ucw.cz>
>
> on it.
>
> Thanks,
> Pavel
Thanks Pavel. I hadn't been watching the Droid 4 threads, so I didn't
see you were hitting the same problem. I'm assuming the patch will go
through the PWM tree, so copying in Thierry.
next prev parent reply other threads:[~2018-07-16 15:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:15 Vibrations on Droid 4? Pavel Machek
2018-07-09 21:49 ` Sebastian Reichel
2018-07-09 22:02 ` Pavel Machek
2018-07-10 10:11 ` Sebastian Reichel
2018-07-10 13:30 ` Pavel Machek
2018-07-10 16:11 ` Sebastian Reichel
2018-07-11 8:02 ` Pavel Machek
2018-07-11 13:27 ` Tony Lindgren
2018-07-11 14:25 ` Sebastian Reichel
2018-07-16 7:10 ` [PATCH] dts/droid4: fix dts w.r.t. pwm Pavel Machek
2018-07-16 10:11 ` Sebastian Reichel
2018-07-17 6:48 ` Tony Lindgren
2018-07-16 7:13 ` [PATCH] pwm-omap: handle timers not ready in probe Pavel Machek
2018-07-16 7:57 ` Tony Lindgren
2018-07-16 8:37 ` Pavel Machek
2018-07-16 15:47 ` David Rivshin [this message]
2018-07-15 20:17 ` Vibrations on Droid 4? Pavel Machek
2018-07-16 7:59 ` Tony Lindgren
2018-08-01 18:58 ` Pavel Machek
2018-08-02 11:07 ` Sebastian Reichel
2018-08-08 17:09 ` Pavel Machek
2018-08-01 20:26 ` Pavel Machek
2018-08-01 20:28 ` [PATCH] fix vibrations on Droid 4 Pavel Machek
2018-08-02 10:55 ` Sebastian Reichel
2018-08-17 14:26 ` Tony Lindgren
2018-07-11 8:25 ` Vibrations on Droid 4? Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716114758.60a6a6cb.drivshin@awxrd.com \
--to=drivshin@awxrd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).