From: Sebastian Reichel <sre@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
j-keerthy@ti.com, narmstrong@baylibre.com,
claudiu.beznea@microchip.com,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net,
merlijn@wizzup.org
Subject: Re: Vibrations on Droid 4?
Date: Thu, 2 Aug 2018 13:07:01 +0200 [thread overview]
Message-ID: <20180802110701.3b4voigegy67h4p5@earth.universe> (raw)
In-Reply-To: <20180801185823.GC26087@amd>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
Hi,
On Wed, Aug 01, 2018 at 08:58:24PM +0200, Pavel Machek wrote:
> > > Yep, so I have two patches that make the device appear, but vibrations
> > > still do not work for me.
> > >
> > > a) any ideas how to debug that / get them to work?
> >
> > Hmm no new ideas except I wonder if there is also some other
> > regression with the timer pdata not being passed properly now.
>
> I checked vibrations work in original Motorola Android; my hardware is
> not broken.
You got it working, but this information might still be interesting
in case of future problems:
The Android "driver" is very different from the one I wrote from
scratch and upstreamed. The mainline driver is less lines of code
(iirc 25%), less complicated (Android vibration support is spread
over multiple drivers/arch code), more efficient (Android drivers
does GPIO bitbanging instead of PWM) and provides more features
(Android driver does not allow all strength settings). Also it uses
normal input device API instead of a custom one.
P.S.: Sorry, I don't have much time to work on D4 at the moment :(
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-08-02 11:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:15 Vibrations on Droid 4? Pavel Machek
2018-07-09 21:49 ` Sebastian Reichel
2018-07-09 22:02 ` Pavel Machek
2018-07-10 10:11 ` Sebastian Reichel
2018-07-10 13:30 ` Pavel Machek
2018-07-10 16:11 ` Sebastian Reichel
2018-07-11 8:02 ` Pavel Machek
2018-07-11 13:27 ` Tony Lindgren
2018-07-11 14:25 ` Sebastian Reichel
2018-07-16 7:10 ` [PATCH] dts/droid4: fix dts w.r.t. pwm Pavel Machek
2018-07-16 10:11 ` Sebastian Reichel
2018-07-17 6:48 ` Tony Lindgren
2018-07-16 7:13 ` [PATCH] pwm-omap: handle timers not ready in probe Pavel Machek
2018-07-16 7:57 ` Tony Lindgren
2018-07-16 8:37 ` Pavel Machek
2018-07-16 15:47 ` David Rivshin
2018-07-15 20:17 ` Vibrations on Droid 4? Pavel Machek
2018-07-16 7:59 ` Tony Lindgren
2018-08-01 18:58 ` Pavel Machek
2018-08-02 11:07 ` Sebastian Reichel [this message]
2018-08-08 17:09 ` Pavel Machek
2018-08-01 20:26 ` Pavel Machek
2018-08-01 20:28 ` [PATCH] fix vibrations on Droid 4 Pavel Machek
2018-08-02 10:55 ` Sebastian Reichel
2018-08-17 14:26 ` Tony Lindgren
2018-07-11 8:25 ` Vibrations on Droid 4? Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802110701.3b4voigegy67h4p5@earth.universe \
--to=sre@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=narmstrong@baylibre.com \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).