From: Rob Herring <robh@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: hdegoede@redhat.com, linux@armlinux.org.uk, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, tj@kernel.org, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com, thierry.reding@gmail.com,
icenowy@aosc.io
Subject: Re: [PATCH v3 7/9] dt-bindings: ata: ahci-platform: document port-supply
Date: Mon, 16 Jul 2018 09:59:38 -0600 [thread overview]
Message-ID: <20180716155938.GA6947@rob-hp-laptop> (raw)
In-Reply-To: <1531479786-4911-8-git-send-email-clabbe@baylibre.com>
On Fri, Jul 13, 2018 at 11:03:04AM +0000, Corentin Labbe wrote:
> This patch document the new optional port-supply
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index 47652521a6ed..40a636b9851e 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -31,6 +31,7 @@ Optional properties:
> - dma-coherent : Present if dma operations are coherent
> - clocks : a list of phandle + clock specifier pairs
> - target-supply : regulator for SATA target power
> +- port-supply : regulator for SATA port
Humm, I'm pretty sure that's what target-supply was supposed to be. If
anything, need to clearly define what is what.
How does this work with multiple ports?
> - phys : reference to the SATA PHY node
> - phy-names : must be "sata-phy"
> - ahci-supply : regulator for AHCI controller
Also, please group all the supplies together.
> @@ -51,6 +52,7 @@ Sub-nodes required properties:
> And at least one of the following properties:
> - phys : reference to the SATA PHY node
> - target-supply : regulator for SATA target power
> +- port-supply : regulator for SATA port
>
> Examples:
> sata@ffe08000 {
> --
> 2.16.4
>
next prev parent reply other threads:[~2018-07-16 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 11:02 [PATCH v3 0/9] ata: ahci_platform: support allwinner R40 AHCI Corentin Labbe
2018-07-13 11:02 ` [PATCH v3 1/9] ata: ahci_platform: add support for AHCI controller regulator Corentin Labbe
2018-07-13 11:02 ` [PATCH v3 2/9] dt-bindings: ata: ahci-platform: document ahci-supply Corentin Labbe
2018-07-16 15:49 ` Rob Herring
2018-07-13 11:03 ` [PATCH v3 3/9] ata: ahci_platform: add support for AHCI controller reset Corentin Labbe
2018-07-13 11:03 ` [PATCH v3 4/9] dt-bindings: ata: ahci-platform: document AHCI reset Corentin Labbe
2018-07-13 12:44 ` Maxime Ripard
2018-07-16 15:54 ` Rob Herring
2018-07-17 11:16 ` LABBE Corentin
2018-07-13 11:03 ` [PATCH v3 5/9] dt-bindings: ata: ahci-platform: fix indentation of target-supply Corentin Labbe
2018-07-16 15:55 ` Rob Herring
2018-07-13 11:03 ` [PATCH v3 6/9] ata: ahci_platform: add support for port regulator Corentin Labbe
2018-07-13 11:07 ` Icenowy Zheng
2018-07-13 11:03 ` [PATCH v3 7/9] dt-bindings: ata: ahci-platform: document port-supply Corentin Labbe
2018-07-16 15:59 ` Rob Herring [this message]
2018-07-16 16:02 ` Icenowy Zheng
2018-07-13 11:03 ` [PATCH v3 8/9] ARM: dts: sun8i: r40: add sata node Corentin Labbe
2018-07-13 11:03 ` [PATCH v3 9/9] ARM: dts: sun8i: sun8i-r40-bananapi-m2-ultra: enable AHCI Corentin Labbe
2018-07-19 0:16 ` [PATCH v3 0/9] ata: ahci_platform: support allwinner R40 AHCI Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716155938.GA6947@rob-hp-laptop \
--to=robh@kernel.org \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).