* [PATCH] drm/nouveau: Fix bogus indenting in nouveau_hwmon.c
@ 2018-07-17 0:07 Lyude Paul
2018-07-17 10:25 ` [Nouveau] " Karol Herbst
0 siblings, 1 reply; 3+ messages in thread
From: Lyude Paul @ 2018-07-17 0:07 UTC (permalink / raw)
To: nouveau; +Cc: Ben Skeggs, David Airlie, dri-devel, linux-kernel
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
index 44178b4c3599..d556f24c6c48 100644
--- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
@@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr,
static int
nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
- int channel, long *val)
+ int channel, long *val)
{
switch (type) {
case hwmon_chip:
@@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
static int
nouveau_write(struct device *dev, enum hwmon_sensor_types type, u32 attr,
- int channel, long val)
+ int channel, long val)
{
switch (type) {
case hwmon_temp:
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau: Fix bogus indenting in nouveau_hwmon.c
2018-07-17 0:07 [PATCH] drm/nouveau: Fix bogus indenting in nouveau_hwmon.c Lyude Paul
@ 2018-07-17 10:25 ` Karol Herbst
2018-07-18 21:37 ` Lyude Paul
0 siblings, 1 reply; 3+ messages in thread
From: Karol Herbst @ 2018-07-17 10:25 UTC (permalink / raw)
To: Lyude Paul; +Cc: nouveau, David Airlie, Ben Skeggs, dri-devel, LKML
isn't there like 1 space missing for each change? Or maybe my client
is messed up, but please align it with the first letter of the
parameters not the "(".
With that fixed: Reviewed-by: Karol Herbst <karolherbst@gmail.com>
On Tue, Jul 17, 2018 at 2:07 AM, Lyude Paul <lyude@redhat.com> wrote:
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> index 44178b4c3599..d556f24c6c48 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> @@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>
> static int
> nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
> - int channel, long *val)
> + int channel, long *val)
> {
> switch (type) {
> case hwmon_chip:
> @@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>
> static int
> nouveau_write(struct device *dev, enum hwmon_sensor_types type, u32 attr,
> - int channel, long val)
> + int channel, long val)
> {
> switch (type) {
> case hwmon_temp:
> --
> 2.17.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau: Fix bogus indenting in nouveau_hwmon.c
2018-07-17 10:25 ` [Nouveau] " Karol Herbst
@ 2018-07-18 21:37 ` Lyude Paul
0 siblings, 0 replies; 3+ messages in thread
From: Lyude Paul @ 2018-07-18 21:37 UTC (permalink / raw)
To: Karol Herbst; +Cc: nouveau, David Airlie, Ben Skeggs, dri-devel, LKML
I think that is an issue with your client? It seems to come up fine if I apply
it locally and look at it with gvim
On Tue, 2018-07-17 at 12:25 +0200, Karol Herbst wrote:
> isn't there like 1 space missing for each change? Or maybe my client
> is messed up, but please align it with the first letter of the
> parameters not the "(".
>
> With that fixed: Reviewed-by: Karol Herbst <karolherbst@gmail.com>
>
> On Tue, Jul 17, 2018 at 2:07 AM, Lyude Paul <lyude@redhat.com> wrote:
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > ---
> > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> > b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> > index 44178b4c3599..d556f24c6c48 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
> > @@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum
> > hwmon_sensor_types type, u32 attr,
> >
> > static int
> > nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
> > - int channel, long
> > *val)
> > + int channel, long *val)
> > {
> > switch (type) {
> > case hwmon_chip:
> > @@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum
> > hwmon_sensor_types type, u32 attr,
> >
> > static int
> > nouveau_write(struct device *dev, enum hwmon_sensor_types type, u32 attr,
> > - int channel, long
> > val)
> > + int channel, long val)
> > {
> > switch (type) {
> > case hwmon_temp:
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Nouveau mailing list
> > Nouveau@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/nouveau
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 0:07 [PATCH] drm/nouveau: Fix bogus indenting in nouveau_hwmon.c Lyude Paul
2018-07-17 10:25 ` [Nouveau] " Karol Herbst
2018-07-18 21:37 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).