* [PATCH 4.17 0/1] 4.17.8-stable review
@ 2018-07-17 11:47 Greg Kroah-Hartman
2018-07-17 11:48 ` [PATCH 4.17 1/1] mm: dont do zero_resv_unavail if memmap is not allocated Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-17 11:47 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah, patches,
ben.hutchings, lkft-triage, stable
This is the start of the stable review cycle for the 4.17.8 release.
There are 1 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu Jul 19 11:47:15 UTC 2018.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.17.8-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.17.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linux 4.17.8-rc1
Pavel Tatashin <pasha.tatashin@oracle.com>
mm: don't do zero_resv_unavail if memmap is not allocated
-------------
Diffstat:
Makefile | 4 ++--
include/linux/mm.h | 2 +-
mm/page_alloc.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 4.17 1/1] mm: dont do zero_resv_unavail if memmap is not allocated
2018-07-17 11:47 [PATCH 4.17 0/1] 4.17.8-stable review Greg Kroah-Hartman
@ 2018-07-17 11:48 ` Greg Kroah-Hartman
2018-07-17 15:50 ` [PATCH 4.17 0/1] 4.17.8-stable review Guenter Roeck
2018-07-18 10:01 ` Naresh Kamboju
2 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-17 11:48 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Pavel Tatashin, Matt Hart,
Michal Hocko, Linus Torvalds
4.17-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pavel Tatashin <pasha.tatashin@oracle.com>
commit d1b47a7c9efcf3c3384b70f6e3c8f1423b44d8c7 upstream.
Moving zero_resv_unavail before memmap_init_zone(), caused a regression on
x86-32.
The cause is that we access struct pages before they are allocated when
CONFIG_FLAT_NODE_MEM_MAP is used.
free_area_init_nodes()
zero_resv_unavail()
mm_zero_struct_page(pfn_to_page(pfn)); <- struct page is not alloced
free_area_init_node()
if CONFIG_FLAT_NODE_MEM_MAP
alloc_node_mem_map()
memblock_virt_alloc_node_nopanic() <- struct page alloced here
On the other hand memblock_virt_alloc_node_nopanic() zeroes all the memory
that it returns, so we do not need to do zero_resv_unavail() here.
Fixes: e181ae0c5db9 ("mm: zero unavailable pages before memmap init")
Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Tested-by: Matt Hart <matt@mattface.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/linux/mm.h | 2 +-
mm/page_alloc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2081,7 +2081,7 @@ extern int __meminit __early_pfn_to_nid(
struct mminit_pfnnid_cache *state);
#endif
-#ifdef CONFIG_HAVE_MEMBLOCK
+#if defined(CONFIG_HAVE_MEMBLOCK) && !defined(CONFIG_FLAT_NODE_MEM_MAP)
void zero_resv_unavail(void);
#else
static inline void zero_resv_unavail(void) {}
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6377,7 +6377,7 @@ void __paginginit free_area_init_node(in
free_area_init_core(pgdat);
}
-#ifdef CONFIG_HAVE_MEMBLOCK
+#if defined(CONFIG_HAVE_MEMBLOCK) && !defined(CONFIG_FLAT_NODE_MEM_MAP)
/*
* Only struct pages that are backed by physical memory are zeroed and
* initialized by going through __init_single_page(). But, there are some
@@ -6415,7 +6415,7 @@ void __paginginit zero_resv_unavail(void
if (pgcnt)
pr_info("Reserved but unavailable: %lld pages", pgcnt);
}
-#endif /* CONFIG_HAVE_MEMBLOCK */
+#endif /* CONFIG_HAVE_MEMBLOCK && !CONFIG_FLAT_NODE_MEM_MAP */
#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 4.17 0/1] 4.17.8-stable review
2018-07-17 11:47 [PATCH 4.17 0/1] 4.17.8-stable review Greg Kroah-Hartman
2018-07-17 11:48 ` [PATCH 4.17 1/1] mm: dont do zero_resv_unavail if memmap is not allocated Greg Kroah-Hartman
@ 2018-07-17 15:50 ` Guenter Roeck
2018-07-18 6:30 ` Greg Kroah-Hartman
2018-07-18 10:01 ` Naresh Kamboju
2 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2018-07-17 15:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings,
lkft-triage, stable
On Tue, Jul 17, 2018 at 01:47:59PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.17.8 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu Jul 19 11:47:15 UTC 2018.
> Anything received after that time might be too late.
>
Build results:
total: 134 pass: 134 fail: 0
Qemu test results:
total: 172 pass: 172 fail: 0
Details are available at http://kerneltests.org/builders.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.17 0/1] 4.17.8-stable review
2018-07-17 15:50 ` [PATCH 4.17 0/1] 4.17.8-stable review Guenter Roeck
@ 2018-07-18 6:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-18 6:30 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-kernel, torvalds, akpm, shuah, patches, ben.hutchings,
lkft-triage, stable
On Tue, Jul 17, 2018 at 08:50:11AM -0700, Guenter Roeck wrote:
> On Tue, Jul 17, 2018 at 01:47:59PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.17.8 release.
> > There are 1 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu Jul 19 11:47:15 UTC 2018.
> > Anything received after that time might be too late.
> >
>
> Build results:
> total: 134 pass: 134 fail: 0
> Qemu test results:
> total: 172 pass: 172 fail: 0
>
> Details are available at http://kerneltests.org/builders.
Great, thanks for letting me know.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.17 0/1] 4.17.8-stable review
2018-07-17 11:47 [PATCH 4.17 0/1] 4.17.8-stable review Greg Kroah-Hartman
2018-07-17 11:48 ` [PATCH 4.17 1/1] mm: dont do zero_resv_unavail if memmap is not allocated Greg Kroah-Hartman
2018-07-17 15:50 ` [PATCH 4.17 0/1] 4.17.8-stable review Guenter Roeck
@ 2018-07-18 10:01 ` Naresh Kamboju
2018-07-18 10:14 ` Greg Kroah-Hartman
2 siblings, 1 reply; 6+ messages in thread
From: Naresh Kamboju @ 2018-07-18 10:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: open list, Linus Torvalds, Andrew Morton, Guenter Roeck,
Shuah Khan, patches, Ben Hutchings, lkft-triage, linux- stable
On 17 July 2018 at 17:17, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> This is the start of the stable review cycle for the 4.17.8 release.
> There are 1 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu Jul 19 11:47:15 UTC 2018.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.17.8-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.17.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm and x86_64.
Summary
------------------------------------------------------------------------
kernel: 4.17.8
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.17.y
git commit: 5606f577a707aa4ccc391714dca815933aeba508
git describe: v4.17.8
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.17-oe/build/v4.17.8
No regressions (compared to build v4.17.7-2-g5173c2ef2046)
Ran 13864 total tests in the following environments and test suites.
Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* boot
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-containers-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-hugetlb-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* ltp-fsx-tests
* ltp-io-tests
* ltp-open-posix-tests
* kselftest-vsyscall-mode-native
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.17 0/1] 4.17.8-stable review
2018-07-18 10:01 ` Naresh Kamboju
@ 2018-07-18 10:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-18 10:14 UTC (permalink / raw)
To: Naresh Kamboju
Cc: open list, Linus Torvalds, Andrew Morton, Guenter Roeck,
Shuah Khan, patches, Ben Hutchings, lkft-triage, linux- stable
On Wed, Jul 18, 2018 at 03:31:50PM +0530, Naresh Kamboju wrote:
> On 17 July 2018 at 17:17, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > This is the start of the stable review cycle for the 4.17.8 release.
> > There are 1 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu Jul 19 11:47:15 UTC 2018.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.17.8-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.17.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Results from Linaro’s test farm.
> No regressions on arm64, arm and x86_64.
Thanks, glad it all still works, it should have only affected i386
systems :)
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-18 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 11:47 [PATCH 4.17 0/1] 4.17.8-stable review Greg Kroah-Hartman
2018-07-17 11:48 ` [PATCH 4.17 1/1] mm: dont do zero_resv_unavail if memmap is not allocated Greg Kroah-Hartman
2018-07-17 15:50 ` [PATCH 4.17 0/1] 4.17.8-stable review Guenter Roeck
2018-07-18 6:30 ` Greg Kroah-Hartman
2018-07-18 10:01 ` Naresh Kamboju
2018-07-18 10:14 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).