* [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER
@ 2018-07-17 20:48 Niklas Cassel
2018-07-18 4:44 ` Viresh Kumar
2018-07-18 10:21 ` Amit Kucheria
0 siblings, 2 replies; 4+ messages in thread
From: Niklas Cassel @ 2018-07-17 20:48 UTC (permalink / raw)
To: Ilia Lin, Rafael J. Wysocki, Viresh Kumar
Cc: linux-arm-msm, Niklas Cassel, linux-pm, linux-kernel
If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
error message. Just be silent in this case.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
index 29389accf3e9..b8d1e6875f16 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -109,8 +109,9 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
speedbin_nvmem = of_nvmem_cell_get(np, NULL);
of_node_put(np);
if (IS_ERR(speedbin_nvmem)) {
- dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
- PTR_ERR(speedbin_nvmem));
+ if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
+ dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
+ PTR_ERR(speedbin_nvmem));
return PTR_ERR(speedbin_nvmem);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER
2018-07-17 20:48 [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER Niklas Cassel
@ 2018-07-18 4:44 ` Viresh Kumar
2018-07-19 10:45 ` Rafael J. Wysocki
2018-07-18 10:21 ` Amit Kucheria
1 sibling, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2018-07-18 4:44 UTC (permalink / raw)
To: Niklas Cassel
Cc: Ilia Lin, Rafael J. Wysocki, linux-arm-msm, linux-pm, linux-kernel
On 17-07-18, 22:48, Niklas Cassel wrote:
> If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
> error message. Just be silent in this case.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 29389accf3e9..b8d1e6875f16 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -109,8 +109,9 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> speedbin_nvmem = of_nvmem_cell_get(np, NULL);
> of_node_put(np);
> if (IS_ERR(speedbin_nvmem)) {
> - dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> - PTR_ERR(speedbin_nvmem));
> + if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
> + dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> + PTR_ERR(speedbin_nvmem));
> return PTR_ERR(speedbin_nvmem);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER
2018-07-17 20:48 [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER Niklas Cassel
2018-07-18 4:44 ` Viresh Kumar
@ 2018-07-18 10:21 ` Amit Kucheria
1 sibling, 0 replies; 4+ messages in thread
From: Amit Kucheria @ 2018-07-18 10:21 UTC (permalink / raw)
To: Niklas Cassel
Cc: Ilia Lin, Rafael J. Wysocki, Viresh Kumar, linux-arm-msm,
Linux PM list, LKML
On Wed, Jul 18, 2018 at 2:18 AM, Niklas Cassel <niklas.cassel@linaro.org> wrote:
> If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
> error message. Just be silent in this case.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 29389accf3e9..b8d1e6875f16 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -109,8 +109,9 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> speedbin_nvmem = of_nvmem_cell_get(np, NULL);
> of_node_put(np);
> if (IS_ERR(speedbin_nvmem)) {
> - dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> - PTR_ERR(speedbin_nvmem));
> + if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
> + dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> + PTR_ERR(speedbin_nvmem));
> return PTR_ERR(speedbin_nvmem);
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER
2018-07-18 4:44 ` Viresh Kumar
@ 2018-07-19 10:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-07-19 10:45 UTC (permalink / raw)
To: Viresh Kumar, Niklas Cassel
Cc: Ilia Lin, linux-arm-msm, linux-pm, linux-kernel
On Wednesday, July 18, 2018 6:44:22 AM CEST Viresh Kumar wrote:
> On 17-07-18, 22:48, Niklas Cassel wrote:
> > If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
> > error message. Just be silent in this case.
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> > ---
> > drivers/cpufreq/qcom-cpufreq-kryo.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 29389accf3e9..b8d1e6875f16 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -109,8 +109,9 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > speedbin_nvmem = of_nvmem_cell_get(np, NULL);
> > of_node_put(np);
> > if (IS_ERR(speedbin_nvmem)) {
> > - dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> > - PTR_ERR(speedbin_nvmem));
> > + if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
> > + dev_err(cpu_dev, "Could not get nvmem cell: %ld\n",
> > + PTR_ERR(speedbin_nvmem));
> > return PTR_ERR(speedbin_nvmem);
> > }
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-19 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 20:48 [PATCH] cpufreq: qcom-kryo: Silently error out on EPROBE_DEFER Niklas Cassel
2018-07-18 4:44 ` Viresh Kumar
2018-07-19 10:45 ` Rafael J. Wysocki
2018-07-18 10:21 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).