linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: James Hogan <jhogan@kernel.org>,
	Paul Burton <paul.burton@mips.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Allan Nielsen <allan.nielsen@microsemi.com>
Subject: Re: [PATCH 1/5] spi: dw: fix possible race condition
Date: Wed, 18 Jul 2018 11:51:12 +0100	[thread overview]
Message-ID: <20180718105112.GF5700@sirena.org.uk> (raw)
In-Reply-To: <20180717142314.32337-2-alexandre.belloni@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Tue, Jul 17, 2018 at 04:23:10PM +0200, Alexandre Belloni wrote:
> It is possible to get an interrupt as soon as it is requested.  dw_spi_irq
> does spi_controller_get_devdata(master) and expects it to be different than
> NULL. However, spi_controller_set_devdata() is called after request_irq(),
> resulting in the following crash:
> 
> CPU 0 Unable to handle kernel paging request at virtual address 00000030, epc == 8058e09c, ra == 8018ff90
> [...]
> Call Trace:
> [<8058e09c>] dw_spi_irq+0x8/0x64
> [<8018ff90>] __handle_irq_event_percpu+0x70/0x1d4
> [<80190128>] handle_irq_event_percpu+0x34/0x8c
> [<801901c4>] handle_irq_event+0x44/0x80
> [<801951a8>] handle_level_irq+0xdc/0x194
> [<8018f580>] generic_handle_irq+0x38/0x50
> [<804c6924>] ocelot_irq_handler+0x104/0x1c0
> [<8018f580>] generic_handle_irq+0x38/0x50

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative then it's
usually better to pull out the relevant sections.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2018-07-18 10:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 14:23 [PATCH 0/5] Add support for MSCC Ocelot SPI Alexandre Belloni
2018-07-17 14:23 ` [PATCH 1/5] spi: dw: fix possible race condition Alexandre Belloni
2018-07-17 21:30   ` Andy Shevchenko
2018-07-17 21:30     ` Andy Shevchenko
2018-07-17 21:42       ` Alexandre Belloni
2018-07-17 21:54         ` Andy Shevchenko
2018-07-17 22:13           ` Alexandre Belloni
2018-07-18 10:33             ` Andy Shevchenko
2018-07-18 10:51   ` Mark Brown [this message]
2018-07-18 12:29   ` Applied "spi: dw: fix possible race condition" to the spi tree Mark Brown
2018-07-17 14:23 ` [PATCH 2/5] spi: dw: allow providing own set_cs callback Alexandre Belloni
2018-07-18 12:24   ` Mark Brown
2018-07-18 12:29   ` Applied "spi: dw: allow providing own set_cs callback" to the spi tree Mark Brown
2018-07-17 14:23 ` [PATCH 3/5] spi: dw-mmio: add MSCC Ocelot support Alexandre Belloni
2018-07-17 21:34   ` Andy Shevchenko
2018-07-17 21:40     ` Alexandre Belloni
2018-07-17 14:23 ` [PATCH 4/5] mips: dts: mscc: Add spi on Ocelot Alexandre Belloni
2018-07-17 14:23 ` [PATCH 5/5] mips: dts: mscc: enable spi and NOR flash support on ocelot PCB123 Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718105112.GF5700@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microsemi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).