From: David Miller <davem@davemloft.net>
To: zhaochen6@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
aviad.krawczyk@huawei.com, tony.qu@huawei.com,
yin.yinshi@huawei.com, luoshaokai@huawei.com
Subject: Re: [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame()
Date: Thu, 19 Jul 2018 23:28:24 -0700 (PDT) [thread overview]
Message-ID: <20180719.232824.2267856623115325271.davem@davemloft.net> (raw)
In-Reply-To: <20180718043318.3211-1-zhaochen6@huawei.com>
From: Zhao Chen <zhaochen6@huawei.com>
Date: Wed, 18 Jul 2018 00:33:18 -0400
> The calculation of "wqe_size" is not correct when the tx queue is busy in
> hinic_xmit_frame().
>
> When there are no free WQEs, the tx flow will unmap the skb buffer, then
> ring the doobell for the pending packets. But the "wqe_size" which used
> to calculate the doorbell address is not correct. The wqe size should be
> cleared to 0, otherwise, it will cause a doorbell error.
>
> This patch fixes the problem.
>
> Reported-by: Zhou Wang <wangzhou1@hisilicon.com>
> Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-07-20 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 4:33 [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame() Zhao Chen
2018-07-20 6:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719.232824.2267856623115325271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviad.krawczyk@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luoshaokai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=tony.qu@huawei.com \
--cc=yin.yinshi@huawei.com \
--cc=zhaochen6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).