* [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame()
@ 2018-07-18 4:33 Zhao Chen
2018-07-20 6:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zhao Chen @ 2018-07-18 4:33 UTC (permalink / raw)
To: davem
Cc: linux-kernel, netdev, aviad.krawczyk, zhaochen6, tony.qu,
yin.yinshi, luoshaokai
The calculation of "wqe_size" is not correct when the tx queue is busy in
hinic_xmit_frame().
When there are no free WQEs, the tx flow will unmap the skb buffer, then
ring the doobell for the pending packets. But the "wqe_size" which used
to calculate the doorbell address is not correct. The wqe size should be
cleared to 0, otherwise, it will cause a doorbell error.
This patch fixes the problem.
Reported-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_tx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
index 9128858479c4..2353ec829c04 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
@@ -229,6 +229,7 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
txq->txq_stats.tx_busy++;
u64_stats_update_end(&txq->txq_stats.syncp);
err = NETDEV_TX_BUSY;
+ wqe_size = 0;
goto flush_skbs;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame()
2018-07-18 4:33 [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame() Zhao Chen
@ 2018-07-20 6:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-20 6:28 UTC (permalink / raw)
To: zhaochen6
Cc: linux-kernel, netdev, aviad.krawczyk, tony.qu, yin.yinshi, luoshaokai
From: Zhao Chen <zhaochen6@huawei.com>
Date: Wed, 18 Jul 2018 00:33:18 -0400
> The calculation of "wqe_size" is not correct when the tx queue is busy in
> hinic_xmit_frame().
>
> When there are no free WQEs, the tx flow will unmap the skb buffer, then
> ring the doobell for the pending packets. But the "wqe_size" which used
> to calculate the doorbell address is not correct. The wqe size should be
> cleared to 0, otherwise, it will cause a doorbell error.
>
> This patch fixes the problem.
>
> Reported-by: Zhou Wang <wangzhou1@hisilicon.com>
> Signed-off-by: Zhao Chen <zhaochen6@huawei.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-20 6:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 4:33 [PATCH 1/1] net-next/hinic: fix a problem in hinic_xmit_frame() Zhao Chen
2018-07-20 6:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).