* [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
@ 2018-07-17 4:06 Andrey Smirnov
2018-07-17 14:46 ` Andrew Lunn
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Andrey Smirnov @ 2018-07-17 4:06 UTC (permalink / raw)
To: Shawn Guo
Cc: Andrey Smirnov, Fabio Estevam, cphealy, linux-arm-kernel,
devicetree, linux-kernel, Andrew Lunn
Add support for Zodiac Inflight Innovations SSMB SPU3
board (VF610-based).
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: cphealy@gmail.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/Makefile | 3 +-
arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 343 ++++++++++++++++++++++
2 files changed, 345 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index bea41b129493..e331b2c16539 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -570,7 +570,8 @@ dtb-$(CONFIG_SOC_VF610) += \
vf610m4-cosmic.dtb \
vf610-twr.dtb \
vf610-zii-dev-rev-b.dtb \
- vf610-zii-dev-rev-c.dtb
+ vf610-zii-dev-rev-c.dtb \
+ vf610-zii-ssmb-spu3.dtb
dtb-$(CONFIG_ARCH_MXS) += \
imx23-evk.dtb \
imx23-olinuxino.dtb \
diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
new file mode 100644
index 000000000000..b692117d7839
--- /dev/null
+++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
@@ -0,0 +1,343 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+
+/*
+ * Device tree file for ZII's SSMB SPU3 board
+ *
+ * SSMB - SPU3 Switch Management Board
+ * SPU - Seat Power Unit
+ *
+ * Copyright (C) 2015, 2016 Zodiac Inflight Innovations
+ *
+ * Based on an original 'vf610-twr.dts' which is Copyright 2015,
+ * Freescale Semiconductor, Inc.
+ */
+
+/dts-v1/;
+#include "vf610.dtsi"
+
+/ {
+ model = "ZII VF610 SSMB SPU3 Board";
+ compatible = "zii,vf610spu3", "zii,vf610dev", "fsl,vf610";
+
+ chosen {
+ stdout-path = &uart0;
+ };
+
+ memory {
+ reg = <0x80000000 0x20000000>;
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&pinctrl_leds_debug>;
+ pinctrl-names = "default";
+
+ led-debug {
+ label = "zii:green:debug1";
+ gpios = <&gpio2 18 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ max-brightness = <1>;
+ };
+ };
+
+ reg_vcc_3v3_mcu: regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_mcu";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+};
+
+&adc0 {
+ vref-supply = <®_vcc_3v3_mcu>;
+ status = "okay";
+};
+
+&adc1 {
+ vref-supply = <®_vcc_3v3_mcu>;
+ status = "okay";
+};
+
+&dspi1 {
+ bus-num = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_dspi1>;
+ /*
+ * Some SPU3s come with SPI-NOR chip DNPed, so we leave this
+ * node disabled by default and rely on bootloader to enable
+ * it when appropriate.
+ */
+ status = "disabled";
+
+ m25p128@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "m25p128", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <50000000>;
+
+ partition@0 {
+ label = "m25p128-0";
+ reg = <0x0 0x01000000>;
+ };
+ };
+};
+
+&edma0 {
+ status = "okay";
+};
+
+&edma1 {
+ status = "okay";
+};
+
+&esdhc0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_esdhc0>;
+ bus-width = <8>;
+ non-removable;
+ no-1-8-v;
+ keep-power-in-suspend;
+ status = "okay";
+};
+
+&esdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_esdhc1>;
+ bus-width = <4>;
+ status = "okay";
+};
+
+&fec1 {
+ phy-mode = "rmii";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_fec1>;
+ status = "okay";
+
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+
+ mdio1: mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ switch0: switch0@0 {
+ compatible = "marvell,mv88e6190";
+ pinctrl-0 = <&pinctrl_gpio_switch0>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ eeprom-length = <65536>;
+ reset-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "cpu";
+ ethernet = <&fec1>;
+
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "eth_cu_1000_1";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "eth_cu_1000_2";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "eth_cu_1000_3";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "eth_cu_1000_4";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "eth_cu_1000_5";
+ };
+
+ port@6 {
+ reg = <6>;
+ label = "eth_cu_1000_6";
+ };
+ };
+ };
+ };
+};
+
+&i2c0 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c0>;
+ status = "okay";
+
+ gpio6: pca9505@22 {
+ compatible = "nxp,pca9554";
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ lm75@48 {
+ compatible = "national,lm75";
+ reg = <0x48>;
+ };
+
+ at24c04@50 {
+ compatible = "atmel,24c04";
+ reg = <0x50>;
+ label = "nameplate";
+ };
+
+ at24c04@52 {
+ compatible = "atmel,24c04";
+ reg = <0x52>;
+ };
+};
+
+&uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart0>;
+ status = "okay";
+};
+
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart1>;
+ status = "okay";
+
+ rave-sp {
+ compatible = "zii,rave-sp-rdu2";
+ current-speed = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ watchdog {
+ compatible = "zii,rave-sp-watchdog";
+ };
+
+ eeprom@a3 {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xa3 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ zii,eeprom-name = "main-eeprom";
+ };
+ };
+};
+
+&iomuxc {
+ pinctrl_dspi1: dspi1grp {
+ fsl,pins = <
+ VF610_PAD_PTD5__DSPI1_CS0 0x1182
+ VF610_PAD_PTD4__DSPI1_CS1 0x1182
+ VF610_PAD_PTC6__DSPI1_SIN 0x1181
+ VF610_PAD_PTC7__DSPI1_SOUT 0x1182
+ VF610_PAD_PTC8__DSPI1_SCK 0x1182
+ >;
+ };
+
+ pinctrl_esdhc0: esdhc0grp {
+ fsl,pins = <
+ VF610_PAD_PTC0__ESDHC0_CLK 0x31ef
+ VF610_PAD_PTC1__ESDHC0_CMD 0x31ef
+ VF610_PAD_PTC2__ESDHC0_DAT0 0x31ef
+ VF610_PAD_PTC3__ESDHC0_DAT1 0x31ef
+ VF610_PAD_PTC4__ESDHC0_DAT2 0x31ef
+ VF610_PAD_PTC5__ESDHC0_DAT3 0x31ef
+ VF610_PAD_PTD23__ESDHC0_DAT4 0x31ef
+ VF610_PAD_PTD22__ESDHC0_DAT5 0x31ef
+ VF610_PAD_PTD21__ESDHC0_DAT6 0x31ef
+ VF610_PAD_PTD20__ESDHC0_DAT7 0x31ef
+ >;
+ };
+
+ pinctrl_esdhc1: esdhc1grp {
+ fsl,pins = <
+ VF610_PAD_PTA24__ESDHC1_CLK 0x31ef
+ VF610_PAD_PTA25__ESDHC1_CMD 0x31ef
+ VF610_PAD_PTA26__ESDHC1_DAT0 0x31ef
+ VF610_PAD_PTA27__ESDHC1_DAT1 0x31ef
+ VF610_PAD_PTA28__ESDHC1_DATA2 0x31ef
+ VF610_PAD_PTA29__ESDHC1_DAT3 0x31ef
+ >;
+ };
+
+ pinctrl_fec1: fec1grp {
+ fsl,pins = <
+ VF610_PAD_PTA6__RMII_CLKIN 0x30d1
+ VF610_PAD_PTC9__ENET_RMII1_MDC 0x30d2
+ VF610_PAD_PTC10__ENET_RMII1_MDIO 0x30d3
+ VF610_PAD_PTC11__ENET_RMII1_CRS 0x30d1
+ VF610_PAD_PTC12__ENET_RMII1_RXD1 0x30d1
+ VF610_PAD_PTC13__ENET_RMII1_RXD0 0x30d1
+ VF610_PAD_PTC14__ENET_RMII1_RXER 0x30d1
+ VF610_PAD_PTC15__ENET_RMII1_TXD1 0x30d2
+ VF610_PAD_PTC16__ENET_RMII1_TXD0 0x30d2
+ VF610_PAD_PTC17__ENET_RMII1_TXEN 0x30d2
+ >;
+ };
+
+ pinctrl_gpio_switch0: pinctrl-gpio-switch0 {
+ fsl,pins = <
+ VF610_PAD_PTE2__GPIO_107 0x31c2
+ VF610_PAD_PTB28__GPIO_98 0x219d
+ >;
+ };
+
+ pinctrl_i2c0: i2c0grp {
+ fsl,pins = <
+ VF610_PAD_PTB14__I2C0_SCL 0x37ff
+ VF610_PAD_PTB15__I2C0_SDA 0x37ff
+ >;
+ };
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ VF610_PAD_PTB16__I2C1_SCL 0x37ff
+ VF610_PAD_PTB17__I2C1_SDA 0x37ff
+ >;
+ };
+
+ pinctrl_leds_debug: pinctrl-leds-debug {
+ fsl,pins = <
+ VF610_PAD_PTD3__GPIO_82 0x31c2
+ >;
+ };
+
+ pinctrl_uart0: uart0grp {
+ fsl,pins = <
+ VF610_PAD_PTB10__UART0_TX 0x21a2
+ VF610_PAD_PTB11__UART0_RX 0x21a1
+ >;
+ };
+
+ pinctrl_uart1: uart1grp {
+ fsl,pins = <
+ VF610_PAD_PTB23__UART1_TX 0x21a2
+ VF610_PAD_PTB24__UART1_RX 0x21a1
+ >;
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 4:06 [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board Andrey Smirnov
@ 2018-07-17 14:46 ` Andrew Lunn
2018-07-17 14:55 ` Chris Healy
2018-07-17 15:08 ` Chris Healy
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2018-07-17 14:46 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Shawn Guo, devicetree, linux-kernel, cphealy, Fabio Estevam,
linux-arm-kernel
On Mon, Jul 16, 2018 at 09:06:51PM -0700, Andrey Smirnov wrote:
> Add support for Zodiac Inflight Innovations SSMB SPU3
> board (VF610-based).
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: cphealy@gmail.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 3 +-
> arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 343 ++++++++++++++++++++++
> 2 files changed, 345 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index bea41b129493..e331b2c16539 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -570,7 +570,8 @@ dtb-$(CONFIG_SOC_VF610) += \
> vf610m4-cosmic.dtb \
> vf610-twr.dtb \
> vf610-zii-dev-rev-b.dtb \
> - vf610-zii-dev-rev-c.dtb
> + vf610-zii-dev-rev-c.dtb \
> + vf610-zii-ssmb-spu3.dtb
> dtb-$(CONFIG_ARCH_MXS) += \
> imx23-evk.dtb \
> imx23-olinuxino.dtb \
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> new file mode 100644
> index 000000000000..b692117d7839
> --- /dev/null
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -0,0 +1,343 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/*
> + * Device tree file for ZII's SSMB SPU3 board
> + *
> + * SSMB - SPU3 Switch Management Board
> + * SPU - Seat Power Unit
I think this is the first Zodiac board with mutually recursive
acronyms.
Probably a question for Chris: Does SSMB specifically refer to version
3 of the SPU?
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 14:46 ` Andrew Lunn
@ 2018-07-17 14:55 ` Chris Healy
2018-07-17 15:20 ` Andrew Lunn
0 siblings, 1 reply; 10+ messages in thread
From: Chris Healy @ 2018-07-17 14:55 UTC (permalink / raw)
To: Andrew Lunn
Cc: Andrey Smirnov, Shawn Guo, devicetree, linux-kernel,
Fabio Estevam, linux ARM
On Tue, Jul 17, 2018 at 7:46 AM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, Jul 16, 2018 at 09:06:51PM -0700, Andrey Smirnov wrote:
>> Add support for Zodiac Inflight Innovations SSMB SPU3
>> board (VF610-based).
>>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: cphealy@gmail.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>> arch/arm/boot/dts/Makefile | 3 +-
>> arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 343 ++++++++++++++++++++++
>> 2 files changed, 345 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index bea41b129493..e331b2c16539 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -570,7 +570,8 @@ dtb-$(CONFIG_SOC_VF610) += \
>> vf610m4-cosmic.dtb \
>> vf610-twr.dtb \
>> vf610-zii-dev-rev-b.dtb \
>> - vf610-zii-dev-rev-c.dtb
>> + vf610-zii-dev-rev-c.dtb \
>> + vf610-zii-ssmb-spu3.dtb
>> dtb-$(CONFIG_ARCH_MXS) += \
>> imx23-evk.dtb \
>> imx23-olinuxino.dtb \
>> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>> new file mode 100644
>> index 000000000000..b692117d7839
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>> @@ -0,0 +1,343 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +
>> +/*
>> + * Device tree file for ZII's SSMB SPU3 board
>> + *
>> + * SSMB - SPU3 Switch Management Board
>> + * SPU - Seat Power Unit
>
> I think this is the first Zodiac board with mutually recursive
> acronyms.
>
> Probably a question for Chris: Does SSMB specifically refer to version
> 3 of the SPU?
>
> Andrew
SPU3 is the third generation of seat power unit.
SSMB is the SPU3 Switch Management Board.
So, SSMB is a backronym. This naming scheme breaks down a bit though
when follow on designs (that are not the SPU3) also use the SSMB, but
that's what it is... ;-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 4:06 [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board Andrey Smirnov
2018-07-17 14:46 ` Andrew Lunn
@ 2018-07-17 15:08 ` Chris Healy
2018-07-18 22:50 ` Fabio Estevam
2018-07-19 2:40 ` Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Chris Healy @ 2018-07-17 15:08 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Shawn Guo, Fabio Estevam, linux ARM, devicetree, linux-kernel,
Andrew Lunn
On Mon, Jul 16, 2018 at 9:06 PM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> Add support for Zodiac Inflight Innovations SSMB SPU3
> board (VF610-based).
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: cphealy@gmail.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 3 +-
> arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 343 ++++++++++++++++++++++
> 2 files changed, 345 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index bea41b129493..e331b2c16539 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -570,7 +570,8 @@ dtb-$(CONFIG_SOC_VF610) += \
> vf610m4-cosmic.dtb \
> vf610-twr.dtb \
> vf610-zii-dev-rev-b.dtb \
> - vf610-zii-dev-rev-c.dtb
> + vf610-zii-dev-rev-c.dtb \
> + vf610-zii-ssmb-spu3.dtb
Tested-by: Chris Healy <cphealy@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 14:55 ` Chris Healy
@ 2018-07-17 15:20 ` Andrew Lunn
2018-07-17 15:22 ` Chris Healy
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2018-07-17 15:20 UTC (permalink / raw)
To: Chris Healy
Cc: Andrey Smirnov, Shawn Guo, devicetree, linux-kernel,
Fabio Estevam, linux ARM
> >> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> >> @@ -0,0 +1,343 @@
> >> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> >> +
> >> +/*
> >> + * Device tree file for ZII's SSMB SPU3 board
> >> + *
> >> + * SSMB - SPU3 Switch Management Board
> >> + * SPU - Seat Power Unit
> >
> > I think this is the first Zodiac board with mutually recursive
> > acronyms.
> >
> > Probably a question for Chris: Does SSMB specifically refer to version
> > 3 of the SPU?
> >
> > Andrew
>
> SPU3 is the third generation of seat power unit.
> SSMB is the SPU3 Switch Management Board.
>
> So, SSMB is a backronym. This naming scheme breaks down a bit though
> when follow on designs (that are not the SPU3) also use the SSMB, but
> that's what it is... ;-)
O.K, i was just wondering if the 3 was in the wrong place. More
logically, it would be
* SSMB - SPU Switch Management Board
* SPU 3 - Seat Power Unit, version 3.
But you are saying the Marketing guys messed up the naming and
engineering is now stuck with it.
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 15:20 ` Andrew Lunn
@ 2018-07-17 15:22 ` Chris Healy
0 siblings, 0 replies; 10+ messages in thread
From: Chris Healy @ 2018-07-17 15:22 UTC (permalink / raw)
To: Andrew Lunn
Cc: Andrey Smirnov, Shawn Guo, devicetree, linux-kernel,
Fabio Estevam, linux ARM
On Tue, Jul 17, 2018 at 8:20 AM, Andrew Lunn <andrew@lunn.ch> wrote:
>> >> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
>> >> @@ -0,0 +1,343 @@
>> >> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> >> +
>> >> +/*
>> >> + * Device tree file for ZII's SSMB SPU3 board
>> >> + *
>> >> + * SSMB - SPU3 Switch Management Board
>> >> + * SPU - Seat Power Unit
>> >
>> > I think this is the first Zodiac board with mutually recursive
>> > acronyms.
>> >
>> > Probably a question for Chris: Does SSMB specifically refer to version
>> > 3 of the SPU?
>> >
>> > Andrew
>>
>> SPU3 is the third generation of seat power unit.
>> SSMB is the SPU3 Switch Management Board.
>>
>> So, SSMB is a backronym. This naming scheme breaks down a bit though
>> when follow on designs (that are not the SPU3) also use the SSMB, but
>> that's what it is... ;-)
>
> O.K, i was just wondering if the 3 was in the wrong place. More
> logically, it would be
>
> * SSMB - SPU Switch Management Board
> * SPU 3 - Seat Power Unit, version 3.
>
> But you are saying the Marketing guys messed up the naming and
> engineering is now stuck with it.
>
Yep
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 4:06 [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board Andrey Smirnov
2018-07-17 14:46 ` Andrew Lunn
2018-07-17 15:08 ` Chris Healy
@ 2018-07-18 22:50 ` Fabio Estevam
2018-07-19 0:51 ` Andrey Smirnov
2018-07-19 2:40 ` Shawn Guo
3 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2018-07-18 22:50 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Shawn Guo,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Andrew Lunn, linux-kernel, Chris Healy, Fabio Estevam,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Andrey,
On Tue, Jul 17, 2018 at 1:06 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> +/dts-v1/;
> +#include "vf610.dtsi"
> +
> +/ {
> + model = "ZII VF610 SSMB SPU3 Board";
> + compatible = "zii,vf610spu3", "zii,vf610dev", "fsl,vf610";
Looks good to me.
Just a minor comment: Is " "zii,vf610dev" really needed here?
Anyway:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-18 22:50 ` Fabio Estevam
@ 2018-07-19 0:51 ` Andrey Smirnov
2018-07-19 0:52 ` Fabio Estevam
0 siblings, 1 reply; 10+ messages in thread
From: Andrey Smirnov @ 2018-07-19 0:51 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Andrew Lunn, linux-kernel, Chris Healy, Fabio Estevam,
linux-arm-kernel
On Wed, Jul 18, 2018 at 3:50 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Andrey,
>
> On Tue, Jul 17, 2018 at 1:06 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>
> > +/dts-v1/;
> > +#include "vf610.dtsi"
> > +
> > +/ {
> > + model = "ZII VF610 SSMB SPU3 Board";
> > + compatible = "zii,vf610spu3", "zii,vf610dev", "fsl,vf610";
>
> Looks good to me.
>
> Just a minor comment: Is " "zii,vf610dev" really needed here?
>
It's not used in Linux, but I do rely on it in Barebox here:
https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n94
and here:
https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n137
so it's pretty handy to have. I can remove it if it is too much of an eyesore.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-19 0:51 ` Andrey Smirnov
@ 2018-07-19 0:52 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-19 0:52 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Shawn Guo,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Andrew Lunn, linux-kernel, Chris Healy, Fabio Estevam,
linux-arm-kernel
Hi Andrey,
On Wed, Jul 18, 2018 at 9:51 PM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> It's not used in Linux, but I do rely on it in Barebox here:
>
> https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n94
>
> and here:
>
> https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n137
>
> so it's pretty handy to have. I can remove it if it is too much of an eyesore.
Thanks for the clarification. If you use it in Barebox, then it's fine
to keep it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board
2018-07-17 4:06 [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board Andrey Smirnov
` (2 preceding siblings ...)
2018-07-18 22:50 ` Fabio Estevam
@ 2018-07-19 2:40 ` Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2018-07-19 2:40 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Fabio Estevam, cphealy, linux-arm-kernel, devicetree,
linux-kernel, Andrew Lunn
On Mon, Jul 16, 2018 at 09:06:51PM -0700, Andrey Smirnov wrote:
> Add support for Zodiac Inflight Innovations SSMB SPU3
> board (VF610-based).
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: cphealy@gmail.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-19 2:40 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 4:06 [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board Andrey Smirnov
2018-07-17 14:46 ` Andrew Lunn
2018-07-17 14:55 ` Chris Healy
2018-07-17 15:20 ` Andrew Lunn
2018-07-17 15:22 ` Chris Healy
2018-07-17 15:08 ` Chris Healy
2018-07-18 22:50 ` Fabio Estevam
2018-07-19 0:51 ` Andrey Smirnov
2018-07-19 0:52 ` Fabio Estevam
2018-07-19 2:40 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).