* [PATCH] Staging: pi433: rf69: fixed a multi line comment issue
@ 2018-07-19 21:43 Mark Railton
2018-07-21 6:53 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Mark Railton @ 2018-07-19 21:43 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Mark Railton
Fixed a coding style issue
Signed-off-by: Mark Railton <mark@markrailton.com>
---
drivers/staging/pi433/rf69.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 90280e9b006d..14826fb505dd 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
case fifo_full:
return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
/* case fifo_not_empty:
- * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
+ * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+ */
case fifo_empty:
return !(rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
case fifo_level_below_threshold:
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: pi433: rf69: fixed a multi line comment issue
2018-07-19 21:43 [PATCH] Staging: pi433: rf69: fixed a multi line comment issue Mark Railton
@ 2018-07-21 6:53 ` Greg KH
2018-07-21 12:26 ` Mark Railton
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2018-07-21 6:53 UTC (permalink / raw)
To: Mark Railton; +Cc: devel, linux-kernel
On Thu, Jul 19, 2018 at 10:43:18PM +0100, Mark Railton wrote:
> Fixed a coding style issue
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 90280e9b006d..14826fb505dd 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
> case fifo_full:
> return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
> /* case fifo_not_empty:
> - * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
> + * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
> + */
Ick, just delete this whole thing if it isn't being used, don't make it
prettier :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: pi433: rf69: fixed a multi line comment issue
2018-07-21 6:53 ` Greg KH
@ 2018-07-21 12:26 ` Mark Railton
0 siblings, 0 replies; 3+ messages in thread
From: Mark Railton @ 2018-07-21 12:26 UTC (permalink / raw)
To: Greg KH; +Cc: devel, linux-kernel
On Sat, Jul 21, 2018 at 08:53:21AM +0200, Greg KH wrote:
> On Thu, Jul 19, 2018 at 10:43:18PM +0100, Mark Railton wrote:
> > Fixed a coding style issue
> >
> > Signed-off-by: Mark Railton <mark@markrailton.com>
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> > index 90280e9b006d..14826fb505dd 100644
> > --- a/drivers/staging/pi433/rf69.c
> > +++ b/drivers/staging/pi433/rf69.c
> > @@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
> > case fifo_full:
> > return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
> > /* case fifo_not_empty:
> > - * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
> > + * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
> > + */
>
> Ick, just delete this whole thing if it isn't being used, don't make it
> prettier :)
>
> thanks,
>
> greg k-h
Apologies, should have realised that to begin with. Have sent a new
patch with the correct change.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-21 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 21:43 [PATCH] Staging: pi433: rf69: fixed a multi line comment issue Mark Railton
2018-07-21 6:53 ` Greg KH
2018-07-21 12:26 ` Mark Railton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).