From: kbuild test robot <lkp@intel.com>
To: Dilip Kota <dkota@codeaurora.org>
Cc: kbuild-all@01.org, timur@codeaurora.org, swboyd@chromium.org,
broonie@kernel.org, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Girish Mahadevan <girishm@codeaurora.org>,
Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>,
Dilip Kota <dkota@codeaurora.org>
Subject: Re: [PATCH V2] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Date: Sat, 21 Jul 2018 06:45:36 +0800 [thread overview]
Message-ID: <201807210656.0f8kSDbq%fengguang.wu@intel.com> (raw)
In-Reply-To: <1532087461-3474-2-git-send-email-dkota@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 2883 bytes --]
Hi Girish,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on spi/for-next]
[also build test WARNING on v4.18-rc5 next-20180720]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dilip-Kota/spi-spi-geni-qcom-Add-SPI-driver-support-for-GENI-based-QUP/20180721-034916
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from drivers/spi/spi-geni-qcom.c:11:0:
drivers/spi/spi-geni-qcom.c: In function 'spi_geni_prepare_transfer_hardware':
include/linux/qcom-geni-se.h:238:9: error: 'version' undeclared (first use in this function); did you mean 'vm_region'?
step = version & HW_VER_STEP_MASK; \
^
>> drivers/spi/spi-geni-qcom.c:256:3: note: in expansion of macro 'geni_se_get_wrapper_version'
geni_se_get_wrapper_version(se, major, minor, step);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/qcom-geni-se.h:238:9: note: each undeclared identifier is reported only once for each function it appears in
step = version & HW_VER_STEP_MASK; \
^
>> drivers/spi/spi-geni-qcom.c:256:3: note: in expansion of macro 'geni_se_get_wrapper_version'
geni_se_get_wrapper_version(se, major, minor, step);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/geni_se_get_wrapper_version +256 drivers/spi/spi-geni-qcom.c
233
234 static int spi_geni_prepare_transfer_hardware(struct spi_master *spi)
235 {
236 struct spi_geni_master *mas = spi_master_get_devdata(spi);
237 struct geni_se *se = &mas->se;
238
239 if (!mas->setup) {
240 int proto = geni_se_read_proto(se);
241 unsigned int major;
242 unsigned int minor;
243 unsigned int step;
244
245 if (proto != GENI_SE_SPI) {
246 dev_err(mas->dev, "Invalid proto %d\n", proto);
247 return -ENXIO;
248 }
249 mas->tx_fifo_depth = geni_se_get_tx_fifo_depth(se);
250 mas->rx_fifo_depth = geni_se_get_rx_fifo_depth(se);
251 mas->tx_fifo_width = geni_se_get_tx_fifo_width(se);
252 geni_se_init(se, 0x0, (mas->tx_fifo_depth - 2));
253 mas->oversampling = 1;
254 /* Transmit an entire FIFO worth of data per IRQ */
255 mas->tx_wm = 1;
> 256 geni_se_get_wrapper_version(se, major, minor, step);
257 if ((major == 1) && (minor == 0))
258 mas->oversampling = 2;
259 mas->setup = 1;
260 }
261 return 0;
262 }
263
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64141 bytes --]
next prev parent reply other threads:[~2018-07-20 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 11:50 [PATCH V2] Add SPI driver support for GENI based QUP Dilip Kota
2018-07-20 11:50 ` [PATCH V2] spi: spi-geni-qcom: " Dilip Kota
2018-07-20 22:45 ` kbuild test robot [this message]
2018-07-20 22:53 ` Doug Anderson
2018-07-20 23:32 ` Doug Anderson
2018-07-20 23:37 ` kbuild test robot
2018-07-23 10:27 ` dkota
2018-07-20 11:51 ` [PATCH V2] dt-bindings: soc: qcom: Add device tree binding for GENI SE Dilip Kota
2018-07-20 20:35 ` Doug Anderson
2018-07-20 21:13 ` [PATCH V2] Add SPI driver support for GENI based QUP Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807210656.0f8kSDbq%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=dkota@codeaurora.org \
--cc=girishm@codeaurora.org \
--cc=kbuild-all@01.org \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sdharia@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).