From: Doug Anderson <dianders@chromium.org>
To: Dilip Kota <dkota@codeaurora.org>
Cc: Timur Tabi <timur@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Mark Brown <broonie@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Girish Mahadevan <girishm@codeaurora.org>,
Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
Sagar Dharia <sdharia@codeaurora.org>
Subject: Re: [PATCH V2] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Date: Fri, 20 Jul 2018 16:32:47 -0700 [thread overview]
Message-ID: <CAD=FV=WMAyg8Z+uamOyQ4iBs_SgTG3VTuw1t5u++FZtEpRWH8w@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=VEQwudhCU0h7muB6ZM1WPETW0h4-=wo_=jgk0gyqfhBA@mail.gmail.com>
Hi,
On Fri, Jul 20, 2018 at 3:53 PM, Doug Anderson <dianders@chromium.org> wrote:
>> + mas->oversampling = 1;
>> + /* Transmit an entire FIFO worth of data per IRQ */
>> + mas->tx_wm = 1;
>> + geni_se_get_wrapper_version(se, major, minor, step);
>
> In v1 Stephen said:
>
>> Drop extra parenthesis.
>
> I'll further add that I'd prefer it if you based your series atop
> <https://patchwork.kernel.org/patch/10412417/> which changes the
> prototype here.
Whoops. Extra parenthesis was actually referring to the line below
this one, AKA:
> + if ((major == 1) && (minor == 0))
> + mas->oversampling = 2;
...that still applies. ...but then ignore my comment suggesting that
you base your series atop Stephen's. You already did that. Certainly
you should mention somewhere in your email that your patch is based on
his.
-Doug
next prev parent reply other threads:[~2018-07-20 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 11:50 [PATCH V2] Add SPI driver support for GENI based QUP Dilip Kota
2018-07-20 11:50 ` [PATCH V2] spi: spi-geni-qcom: " Dilip Kota
2018-07-20 22:45 ` kbuild test robot
2018-07-20 22:53 ` Doug Anderson
2018-07-20 23:32 ` Doug Anderson [this message]
2018-07-20 23:37 ` kbuild test robot
2018-07-23 10:27 ` dkota
2018-07-20 11:51 ` [PATCH V2] dt-bindings: soc: qcom: Add device tree binding for GENI SE Dilip Kota
2018-07-20 20:35 ` Doug Anderson
2018-07-20 21:13 ` [PATCH V2] Add SPI driver support for GENI based QUP Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WMAyg8Z+uamOyQ4iBs_SgTG3VTuw1t5u++FZtEpRWH8w@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=broonie@kernel.org \
--cc=dkota@codeaurora.org \
--cc=girishm@codeaurora.org \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sdharia@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).