linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver
@ 2018-07-18 14:52 Niklas Cassel
  2018-07-19 10:53 ` Nicolas Dechesne
  0 siblings, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2018-07-18 14:52 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

Drop legacy suffix for clocks used by MSM DRM driver.
Fixes the following warnings:

msm_dsi_phy 1a98300.dsi-phy: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
msm 1a00000.mdss: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
msm 1a00000.mdss: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
msm 1a00000.mdss: Using legacy clk name binding.  Use "vsync" instead of "vsync_clk"
msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "core" instead of "core_clk"
msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "vsync" instead of "vsync_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "mdp_core" instead of "mdp_core_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "byte" instead of "byte_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "pixel" instead of "pixel_clk"
msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "core" instead of "core_clk"

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 +++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index c2625d15a8c0..7b32b8990d62 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -858,9 +858,9 @@
 			clocks = <&gcc GCC_MDSS_AHB_CLK>,
 				 <&gcc GCC_MDSS_AXI_CLK>,
 				 <&gcc GCC_MDSS_VSYNC_CLK>;
-			clock-names = "iface_clk",
-				      "bus_clk",
-				      "vsync_clk";
+			clock-names = "iface",
+				      "bus",
+				      "vsync";
 
 			interrupts = <0 72 IRQ_TYPE_LEVEL_HIGH>;
 
@@ -883,10 +883,10 @@
 					 <&gcc GCC_MDSS_AXI_CLK>,
 					 <&gcc GCC_MDSS_MDP_CLK>,
 					 <&gcc GCC_MDSS_VSYNC_CLK>;
-				clock-names = "iface_clk",
-					      "bus_clk",
-					      "core_clk",
-					      "vsync_clk";
+				clock-names = "iface",
+					      "bus",
+					      "core",
+					      "vsync";
 
 				iommus = <&apps_iommu 4>;
 
@@ -922,12 +922,12 @@
 					 <&gcc GCC_MDSS_BYTE0_CLK>,
 					 <&gcc GCC_MDSS_PCLK0_CLK>,
 					 <&gcc GCC_MDSS_ESC0_CLK>;
-				clock-names = "mdp_core_clk",
-					      "iface_clk",
-					      "bus_clk",
-					      "byte_clk",
-					      "pixel_clk",
-					      "core_clk";
+				clock-names = "mdp_core",
+					      "iface",
+					      "bus",
+					      "byte",
+					      "pixel",
+					      "core";
 				phys = <&dsi_phy0>;
 				phy-names = "dsi-phy";
 
@@ -963,7 +963,7 @@
 				#phy-cells = <0>;
 
 				clocks = <&gcc GCC_MDSS_AHB_CLK>;
-				clock-names = "iface_clk";
+				clock-names = "iface";
 			};
 		};
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver
  2018-07-18 14:52 [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver Niklas Cassel
@ 2018-07-19 10:53 ` Nicolas Dechesne
  2018-07-21 18:51   ` Andy Gross
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dechesne @ 2018-07-19 10:53 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Andy Gross, David Brown, robh+dt, Mark Rutland, linux-arm-msm,
	linux-soc, devicetree, lkml

hi Niklas,

On Wed, Jul 18, 2018 at 4:53 PM Niklas Cassel <niklas.cassel@linaro.org> wrote:
>
> Drop legacy suffix for clocks used by MSM DRM driver.

I had the same patch locally, which I forgot to send.. so thanks for
sending it ;)

you might want to add in the commit log:

    Since "720c3bb80235 (drm/msm: drop _clk suffix from clk names)",
we can see such
    messages when booting:

> Fixes the following warnings:
>
> msm_dsi_phy 1a98300.dsi-phy: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
> msm 1a00000.mdss: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
> msm 1a00000.mdss: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
> msm 1a00000.mdss: Using legacy clk name binding.  Use "vsync" instead of "vsync_clk"
> msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
> msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
> msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "core" instead of "core_clk"
> msm_mdp 1a01000.mdp: Using legacy clk name binding.  Use "vsync" instead of "vsync_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "mdp_core" instead of "mdp_core_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "iface" instead of "iface_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "bus" instead of "bus_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "byte" instead of "byte_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "pixel" instead of "pixel_clk"
> msm_dsi 1a98000.dsi: Using legacy clk name binding.  Use "core" instead of "core_clk"
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 +++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index c2625d15a8c0..7b32b8990d62 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -858,9 +858,9 @@
>                         clocks = <&gcc GCC_MDSS_AHB_CLK>,
>                                  <&gcc GCC_MDSS_AXI_CLK>,
>                                  <&gcc GCC_MDSS_VSYNC_CLK>;
> -                       clock-names = "iface_clk",
> -                                     "bus_clk",
> -                                     "vsync_clk";
> +                       clock-names = "iface",
> +                                     "bus",
> +                                     "vsync";
>
>                         interrupts = <0 72 IRQ_TYPE_LEVEL_HIGH>;
>
> @@ -883,10 +883,10 @@
>                                          <&gcc GCC_MDSS_AXI_CLK>,
>                                          <&gcc GCC_MDSS_MDP_CLK>,
>                                          <&gcc GCC_MDSS_VSYNC_CLK>;
> -                               clock-names = "iface_clk",
> -                                             "bus_clk",
> -                                             "core_clk",
> -                                             "vsync_clk";
> +                               clock-names = "iface",
> +                                             "bus",
> +                                             "core",
> +                                             "vsync";
>
>                                 iommus = <&apps_iommu 4>;
>
> @@ -922,12 +922,12 @@
>                                          <&gcc GCC_MDSS_BYTE0_CLK>,
>                                          <&gcc GCC_MDSS_PCLK0_CLK>,
>                                          <&gcc GCC_MDSS_ESC0_CLK>;
> -                               clock-names = "mdp_core_clk",
> -                                             "iface_clk",
> -                                             "bus_clk",
> -                                             "byte_clk",
> -                                             "pixel_clk",
> -                                             "core_clk";
> +                               clock-names = "mdp_core",
> +                                             "iface",
> +                                             "bus",
> +                                             "byte",
> +                                             "pixel",
> +                                             "core";
>                                 phys = <&dsi_phy0>;
>                                 phy-names = "dsi-phy";
>
> @@ -963,7 +963,7 @@
>                                 #phy-cells = <0>;
>
>                                 clocks = <&gcc GCC_MDSS_AHB_CLK>;
> -                               clock-names = "iface_clk";
> +                               clock-names = "iface";
>                         };
>                 };
>
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver
  2018-07-19 10:53 ` Nicolas Dechesne
@ 2018-07-21 18:51   ` Andy Gross
  2018-07-21 18:55     ` Niklas Cassel
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Gross @ 2018-07-21 18:51 UTC (permalink / raw)
  To: Nicolas Dechesne
  Cc: Niklas Cassel, David Brown, robh+dt, Mark Rutland, linux-arm-msm,
	linux-soc, devicetree, lkml

On Thu, Jul 19, 2018 at 12:53:04PM +0200, Nicolas Dechesne wrote:
> hi Niklas,
> 
> On Wed, Jul 18, 2018 at 4:53 PM Niklas Cassel <niklas.cassel@linaro.org> wrote:
> >
> > Drop legacy suffix for clocks used by MSM DRM driver.
> 
> I had the same patch locally, which I forgot to send.. so thanks for
> sending it ;)
> 
> you might want to add in the commit log:
> 
>     Since "720c3bb80235 (drm/msm: drop _clk suffix from clk names)",
> we can see such
>     messages when booting:
> 

I'll amend the log to contain that info Nicolas.

Thanks,

Andy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver
  2018-07-21 18:51   ` Andy Gross
@ 2018-07-21 18:55     ` Niklas Cassel
  0 siblings, 0 replies; 4+ messages in thread
From: Niklas Cassel @ 2018-07-21 18:55 UTC (permalink / raw)
  To: Andy Gross
  Cc: Nicolas Dechesne, David Brown, robh+dt, Mark Rutland,
	linux-arm-msm, linux-soc, devicetree, lkml

On Sat, Jul 21, 2018 at 01:51:47PM -0500, Andy Gross wrote:
> On Thu, Jul 19, 2018 at 12:53:04PM +0200, Nicolas Dechesne wrote:
> > hi Niklas,
> > 
> > On Wed, Jul 18, 2018 at 4:53 PM Niklas Cassel <niklas.cassel@linaro.org> wrote:
> > >
> > > Drop legacy suffix for clocks used by MSM DRM driver.
> > 
> > I had the same patch locally, which I forgot to send.. so thanks for
> > sending it ;)
> > 
> > you might want to add in the commit log:
> > 
> >     Since "720c3bb80235 (drm/msm: drop _clk suffix from clk names)",
> > we can see such
> >     messages when booting:
> > 
> 
> I'll amend the log to contain that info Nicolas.

Hello Andy,

There is a V2 of this patch with that info added :)

Kind regards,
Niklas

> 
> Thanks,
> 
> Andy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-21 18:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 14:52 [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver Niklas Cassel
2018-07-19 10:53 ` Nicolas Dechesne
2018-07-21 18:51   ` Andy Gross
2018-07-21 18:55     ` Niklas Cassel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).