* [PATCH] hinic: Link the logical network device to the pci device in sysfs
@ 2018-07-23 22:55 dann frazier
2018-07-25 21:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: dann frazier @ 2018-07-23 22:55 UTC (permalink / raw)
To: Aviad Krawczyk, David S. Miller; +Cc: Zhao Chen, netdev, linux-kernel
Otherwise interfaces get exposed under /sys/devices/virtual, which
doesn't give udev the context it needs for PCI-based predictable
interface names.
Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
drivers/net/ethernet/huawei/hinic/hinic_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
index 5b122728dcb47..09e9da10b7865 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_main.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c
@@ -983,6 +983,7 @@ static int nic_dev_init(struct pci_dev *pdev)
hinic_hwdev_cb_register(nic_dev->hwdev, HINIC_MGMT_MSG_CMD_LINK_STATUS,
nic_dev, link_status_event_handler);
+ SET_NETDEV_DEV(netdev, &pdev->dev);
err = register_netdev(netdev);
if (err) {
dev_err(&pdev->dev, "Failed to register netdev\n");
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hinic: Link the logical network device to the pci device in sysfs
2018-07-23 22:55 [PATCH] hinic: Link the logical network device to the pci device in sysfs dann frazier
@ 2018-07-25 21:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-25 21:01 UTC (permalink / raw)
To: dann.frazier; +Cc: aviad.krawczyk, zhaochen6, netdev, linux-kernel
From: dann frazier <dann.frazier@canonical.com>
Date: Mon, 23 Jul 2018 16:55:40 -0600
> Otherwise interfaces get exposed under /sys/devices/virtual, which
> doesn't give udev the context it needs for PCI-based predictable
> interface names.
>
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-25 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 22:55 [PATCH] hinic: Link the logical network device to the pci device in sysfs dann frazier
2018-07-25 21:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).