From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Alexei Colin <acolin@isi.edu>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Alex Bounine <alex.bou9@gmail.com>,
Barry Wood <barry.wood@idt.com>,
John Paul Walters <jwalters@isi.edu>
Subject: Re: [PATCH] arm: enable RapidIO config options in Kconfig
Date: Tue, 24 Jul 2018 15:02:04 +0100 [thread overview]
Message-ID: <20180724140203.GV17271@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180724134122.86718-1-acolin@isi.edu>
On Tue, Jul 24, 2018 at 09:41:26AM -0400, Alexei Colin wrote:
> ARM SoCs with a PCI bus offer the RapiodIO config menu; SoCs with
> RapidIO IP blocks but without a PCI bus, need to add "select
> HAS_RAPIDIO" to the Kconfig entry for that SoC (e.g. ARCH_*).
>
> HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
> other architectures which already define this flag (powerpc).
Is there any reason we can't have the RAPIDIO and HAS_RAPIDIO config
blocks in drivers/rapidio/Kconfig (maybe without the || PCI - see
below), and then have architecture Kconfig files do:
config (ARM or PPC)
select HAS_RAPIDIO if PCI
or in the case of MIPS:
config MIPS
...
select HAS_RAPIDIO
That would avoid duplicating almost identical RAPIDIO and HAS_RAPIDIO
config blocks in architecture Kconfig files.
Why should rapidio be available just because we have PCI selected? If
it behaves as a PCI add-in card, then why isn't this available for any
architecture with PCI?
What about build coverage - shouldn't RAPIDIO be selectable for (eg)
other architectures via COMPILE_TEST if it's supposed to be generic?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
prev parent reply other threads:[~2018-07-24 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:41 [PATCH] arm: enable RapidIO config options in Kconfig Alexei Colin
2018-07-24 13:48 ` Arnd Bergmann
2018-07-24 14:02 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724140203.GV17271@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=acolin@isi.edu \
--cc=alex.bou9@gmail.com \
--cc=arnd@arndb.de \
--cc=barry.wood@idt.com \
--cc=jwalters@isi.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).