[PATCH] arm: enable RapidIO config options in Kconfig

[PATCH] arm: enable RapidIO config options in Kconfig

[Alexei Colin]

ARM SoCs with a PCI bus offer the RapiodIO config menu; SoCs with
RapidIO IP blocks but without a PCI bus, need to add "select
HAS_RAPIDIO" to the Kconfig entry for that SoC (e.g. ARCH_*).

HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
other architectures which already define this flag (powerpc).

Signed-off-by: Alexei Colin <acolin@isi.edu>
---

Tested that kernel builds with RapidIO subsystem and switch drivers enabled.
Maintainers for RapidIO subsystem CCed.
Sending a similar patch to ARM64 maintainers shortly.

 arch/arm/Kconfig | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 843edfd000be..d6267ab33cb5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1274,6 +1274,22 @@ config PCI_HOST_ITE8152
 
 source "drivers/pci/Kconfig"
 
+config HAS_RAPIDIO
+	bool
+	default n
+
+config RAPIDIO
+	tristate "RapidIO support"
+	depends on HAS_RAPIDIO || PCI
+	help
+	  This feature enables support for RapidIO high-performance
+	  packet-switched interconnect.
+
+	  If you say Y here, the kernel will include drivers and
+	  infrastructure code to support RapidIO interconnect devices.
+
+source "drivers/rapidio/Kconfig"
+
 source "drivers/pcmcia/Kconfig"
 
 endmenu
-- 
2.18.0

Re: [PATCH] arm: enable RapidIO config options in Kconfig

[Arnd Bergmann]

On Tue, Jul 24, 2018 at 3:41 PM, Alexei Colin <acolin@isi.edu> wrote:
> ARM SoCs with a PCI bus offer the RapiodIO config menu; SoCs with
> RapidIO IP blocks but without a PCI bus, need to add "select
> HAS_RAPIDIO" to the Kconfig entry for that SoC (e.g. ARCH_*).
>
> HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
> other architectures which already define this flag (powerpc).
>
> Signed-off-by: Alexei Colin <acolin@isi.edu>
> ---
>
> Tested that kernel builds with RapidIO subsystem and switch drivers enabled.
> Maintainers for RapidIO subsystem CCed.
> Sending a similar patch to ARM64 maintainers shortly.


Could you move CONFIG_RAPIDIO to drivers/rapidio? That
would avoid repeating it for each of the five architectures, and
make it more consistent with other subsystems.

       Arnd

Re: [PATCH] arm: enable RapidIO config options in Kconfig

[Russell King - ARM Linux]

On Tue, Jul 24, 2018 at 09:41:26AM -0400, Alexei Colin wrote:
> ARM SoCs with a PCI bus offer the RapiodIO config menu; SoCs with
> RapidIO IP blocks but without a PCI bus, need to add "select
> HAS_RAPIDIO" to the Kconfig entry for that SoC (e.g. ARCH_*).
> 
> HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
> other architectures which already define this flag (powerpc).

Is there any reason we can't have the RAPIDIO and HAS_RAPIDIO config
blocks in drivers/rapidio/Kconfig (maybe without the || PCI - see
below), and then have architecture Kconfig files do:

config (ARM or PPC)
	select HAS_RAPIDIO if PCI

or in the case of MIPS:

config MIPS
	...
	select HAS_RAPIDIO

That would avoid duplicating almost identical RAPIDIO and HAS_RAPIDIO
config blocks in architecture Kconfig files.

Why should rapidio be available just because we have PCI selected?  If
it behaves as a PCI add-in card, then why isn't this available for any
architecture with PCI?

What about build coverage - shouldn't RAPIDIO be selectable for (eg)
other architectures via COMPILE_TEST if it's supposed to be generic?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up