From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Staging subsystem List <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes
Date: Tue, 24 Jul 2018 15:39:23 -0300 [thread overview]
Message-ID: <20180724153923.0f1b9f56@coco.lan> (raw)
In-Reply-To: <CA+55aFyV=5QNJXn+t_ZDCigGi+HjM6N94DRb_E50_xUsk+VTFA@mail.gmail.com>
Em Tue, 24 Jul 2018 10:37:56 -0700
Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Mon, Jul 23, 2018 at 8:41 PM Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org> wrote:
> >
> > While I won't be against merging it, IMHO a better fix would be to
> > add the includes asm/cacheflush.h needs inside it, e. g. something
> > like adding:
>
> No. The <asm/*> includes really should come after <linux/*>.
>
> This is a media driver bug, plain and simple.
Works for me. Do you intend to apply it directly? Otherwise I'll
add on my tree - and likely send you during the merge window - this is
just Kconfig random COMPILE_TEST build noise, as this driver
is ARM-only (for an OMAP4 specific IP block). So, probably not worth
sending a pull request just due to that.
> We should strive to avoid adding more header includes, it's one of the
> major causes of kernel build slowdown.
Yeah, some time ago mailing lists got flooded with some janitorial's
patchset adding includes (some claiming to be needed on some archs or
under some random Kconfigs)... Compile-test ended by adding more such
stuff (for a good reason, IMHO). I wonder if are there a better way to
handle includes without slowing builds.
Thanks,
Mauro
next prev parent reply other threads:[~2018-07-24 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 21:39 [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes Guenter Roeck
2018-07-23 21:52 ` David Miller
2018-07-24 3:41 ` Mauro Carvalho Chehab
2018-07-24 17:37 ` Linus Torvalds
2018-07-24 18:39 ` Mauro Carvalho Chehab [this message]
2018-07-24 18:48 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724153923.0f1b9f56@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).