From: Linus Torvalds <torvalds@linux-foundation.org>
To: mchehab+samsung@kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Staging subsystem List <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes
Date: Tue, 24 Jul 2018 11:48:19 -0700 [thread overview]
Message-ID: <CA+55aFwVVQcbpH=3Qf8hfGhx_Dz-Xp0N+gbAoaFhqLkVD-+WtA@mail.gmail.com> (raw)
In-Reply-To: <20180724153923.0f1b9f56@coco.lan>
On Tue, Jul 24, 2018 at 11:39 AM Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> wrote:
>
> Works for me. Do you intend to apply it directly?
Yes, I took it and it should be pushed out.
> Yeah, some time ago mailing lists got flooded with some janitorial's
> patchset adding includes (some claiming to be needed on some archs or
> under some random Kconfigs)... Compile-test ended by adding more such
> stuff (for a good reason, IMHO). I wonder if are there a better way to
> handle includes without slowing builds.
It's a nightmare to do by hand, with all the different architectures
having slightly different header file requirements.
The scheduler people did it last year (roughly Feb-2017 timeframe),
and it was painful and involved a lot of build testing. Basically some
<linux/sched.h> was split up into <linux/sched/*.h>
I wouldn't encourage people to do that again without some tooling to
actually look at "what symbols might get defined by header file
collection XYZ, what symbols might I need with any config option" kind
of logic.
But it would be lovely if somebody *could* do tooling like that.
Just having something you can run on C files that says "these headers
are completely unused under all possibly config options and
architectures" might be interesting.
Because right now, most people tend to just copy a big set of headers,
whether they need it or not. And they almost never shrink, but new
ones get added as people add uses.
Linus
prev parent reply other threads:[~2018-07-24 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 21:39 [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes Guenter Roeck
2018-07-23 21:52 ` David Miller
2018-07-24 3:41 ` Mauro Carvalho Chehab
2018-07-24 17:37 ` Linus Torvalds
2018-07-24 18:39 ` Mauro Carvalho Chehab
2018-07-24 18:48 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwVVQcbpH=3Qf8hfGhx_Dz-Xp0N+gbAoaFhqLkVD-+WtA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).