From: Michal Hocko <mhocko@kernel.org>
To: John Allen <jallen@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kamezawa.hiroyu@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com,
mgorman@suse.de
Subject: Re: Infinite looping observed in __offline_pages
Date: Wed, 25 Jul 2018 22:03:36 +0200 [thread overview]
Message-ID: <20180725200336.GP28386@dhcp22.suse.cz> (raw)
In-Reply-To: <20180725181115.hmlyd3tmnu3mn3sf@p50.austin.ibm.com>
On Wed 25-07-18 13:11:15, John Allen wrote:
[...]
> Does a failure in do_migrate_range indicate that the range is unmigratable
> and the loop in __offline_pages should terminate and goto failed_removal? Or
> should we allow a certain number of retrys before we
> give up on migrating the range?
Unfortunatelly not. Migration code doesn't tell a difference between
ephemeral and permanent failures. We are relying on
start_isolate_page_range to tell us this. So the question is, what kind
of page is not migratable and for what reason.
Are you able to add some debugging to give us more information. The
current debugging code in the hotplug/migration sucks...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-25 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 18:11 Infinite looping observed in __offline_pages John Allen
2018-07-25 20:03 ` Michal Hocko [this message]
2018-07-27 17:32 ` John Allen
2018-07-30 9:16 ` Michal Hocko
2018-08-01 11:09 ` Michael Ellerman
2018-08-01 11:20 ` Michal Hocko
2018-08-22 9:30 ` Aneesh Kumar K.V
2018-08-22 10:53 ` Michal Hocko
2018-08-22 18:58 ` Mike Kravetz
2018-08-23 3:01 ` Aneesh Kumar K.V
2018-08-23 7:25 ` Michal Hocko
2018-08-01 1:37 ` Rashmica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725200336.GP28386@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=jallen@linux.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).