From: Michal Hocko <mhocko@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: John Allen <jallen@linux.ibm.com>,
n-horiguchi@ah.jp.nec.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
mgorman@suse.de
Subject: Re: Infinite looping observed in __offline_pages
Date: Wed, 1 Aug 2018 13:20:39 +0200 [thread overview]
Message-ID: <20180801112039.GJ16767@dhcp22.suse.cz> (raw)
In-Reply-To: <87r2jifimk.fsf@concordia.ellerman.id.au>
On Wed 01-08-18 21:09:39, Michael Ellerman wrote:
> Michal Hocko <mhocko@kernel.org> writes:
> > On Wed 25-07-18 13:11:15, John Allen wrote:
> > [...]
> >> Does a failure in do_migrate_range indicate that the range is unmigratable
> >> and the loop in __offline_pages should terminate and goto failed_removal? Or
> >> should we allow a certain number of retrys before we
> >> give up on migrating the range?
> >
> > Unfortunatelly not. Migration code doesn't tell a difference between
> > ephemeral and permanent failures.
>
> What's to stop an ephemeral failure happening repeatedly?
If there is a short term pin on the page that prevents the migration
then the holder of the pin should realease it and the next retry will
succeed the migration. If the page gets freed on the way then it will
not be reallocated because they are isolated already. I can only see
complete OOM to be the reason to fail allocation of the target place
as the migration failure and that is highly unlikely and sooner or later
trigger the oom killer and release some memory.
The biggest problem here is that we cannot tell ephemeral and long term
pins...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-08-01 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 18:11 Infinite looping observed in __offline_pages John Allen
2018-07-25 20:03 ` Michal Hocko
2018-07-27 17:32 ` John Allen
2018-07-30 9:16 ` Michal Hocko
2018-08-01 11:09 ` Michael Ellerman
2018-08-01 11:20 ` Michal Hocko [this message]
2018-08-22 9:30 ` Aneesh Kumar K.V
2018-08-22 10:53 ` Michal Hocko
2018-08-22 18:58 ` Mike Kravetz
2018-08-23 3:01 ` Aneesh Kumar K.V
2018-08-23 7:25 ` Michal Hocko
2018-08-01 1:37 ` Rashmica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801112039.GJ16767@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=jallen@linux.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mpe@ellerman.id.au \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).