linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 08/10] staging:rtl8192u: Refactor enum dm_dig_pd_th_e - Style
Date: Sat, 28 Jul 2018 00:28:24 +0100	[thread overview]
Message-ID: <20180727232826.28014-9-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180727232826.28014-1-johnfwhitmore@gmail.com>

The enumerated type dm_dig_pd_th_e is never actually used as
the type for the two variables which use the constants, which the
enumeration defines. This omission removes the possibility of taking
advantage of compiler type checking.

To correct this the two member variables, (curpd_thstate & prepd_thstate)
have been changed to use the type enum dm_dig_pd_th_e rather then u8.

Additionally the enum's declaration has been moved above the dig
structure, where the type is used, the 'typedef' has been removed to
clear the checkpatch issue with defining new types, and the value
'DIG_PD_MAX' has been removed from the enumeration, since it is never
used in code.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_dm.h | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
index 825df06e17a8..41b08211e958 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.h
+++ b/drivers/staging/rtl8192u/r8192U_dm.h
@@ -81,6 +81,12 @@ enum dm_dig_connect_e {
 	DIG_CONNECT = 1,
 };
 
+enum dm_dig_pd_th_e {
+	DIG_PD_AT_LOW_POWER = 0,
+	DIG_PD_AT_NORMAL_POWER = 1,
+	DIG_PD_AT_HIGH_POWER = 2,
+};
+
 /* 2007/10/04 MH Define upper and lower threshold of DIG enable or disable. */
 struct dig {
 	u8		dig_enable_flag;
@@ -99,8 +105,8 @@ struct dig {
 	enum dm_dig_connect_e		cur_connect_state;
 	enum dm_dig_connect_e		pre_connect_state;
 
-	u8		curpd_thstate;
-	u8		prepd_thstate;
+	enum dm_dig_pd_th_e		curpd_thstate;
+	enum dm_dig_pd_th_e		prepd_thstate;
 	u8		curcs_ratio_state;
 	u8		precs_ratio_state;
 
@@ -115,13 +121,6 @@ struct dig {
 	long		rssi_val;
 };
 
-typedef enum tag_dig_packetdetection_threshold_definition {
-	DIG_PD_AT_LOW_POWER = 0,
-	DIG_PD_AT_NORMAL_POWER = 1,
-	DIG_PD_AT_HIGH_POWER = 2,
-	DIG_PD_MAX
-} dm_dig_pd_th_e;
-
 typedef enum tag_dig_cck_cs_ratio_state_definition {
 	DIG_CS_RATIO_LOWER = 0,
 	DIG_CS_RATIO_HIGHER = 1,
-- 
2.18.0


  parent reply	other threads:[~2018-07-27 23:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 23:28 [PATCH 00/10] staging:rtl8192u: Refactor enums r8192U_dm.h -Style John Whitmore
2018-07-27 23:28 ` [PATCH 01/10] staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Style John Whitmore
2018-07-27 23:28 ` [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e " John Whitmore
2018-07-29  8:17   ` Greg KH
2018-07-29  9:50     ` John Whitmore
2018-07-27 23:28 ` [PATCH 03/10] staging:rtl8192u: Refactor enum dm_ratr_sta_e usage " John Whitmore
2018-07-27 23:28 ` [PATCH 04/10] staging:rtl8192u: Remove enum dm_dig_op_e John Whitmore
2018-07-27 23:28 ` [PATCH 05/10] staging:rtl8192u: Refactor enum dm_dig_alg_e - Style John Whitmore
2018-07-27 23:28 ` [PATCH 06/10] staging:rtl8192u: Remove unused enum dm_dig_dbg_e " John Whitmore
2018-07-27 23:28 ` [PATCH 07/10] staging:rtl8192u: Refactor dm_dig_connect_e " John Whitmore
2018-07-27 23:28 ` John Whitmore [this message]
2018-07-27 23:28 ` [PATCH 09/10] staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e " John Whitmore
2018-07-27 23:28 ` [PATCH 10/10] staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727232826.28014-9-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).