* [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue
@ 2018-07-28 9:02 Sohil Ladhani
2018-07-29 20:17 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sohil Ladhani @ 2018-07-28 9:02 UTC (permalink / raw)
To: davem; +Cc: nic_swsd, netdev, linux-kernel, Sohil Ladhani
Fixed a coding style issue
Signed-off-by: Sohil Ladhani <supertakumi86@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index f4cae2be0fda..e4754f336c34 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -61,7 +61,7 @@
#define assert(expr) \
if (!(expr)) { \
printk( "Assertion failed! %s,%s,%s,line=%d\n", \
- #expr,__FILE__,__func__,__LINE__); \
+ #expr, __FILE__, __func__, __LINE__); \
}
#define dprintk(fmt, args...) \
do { printk(KERN_DEBUG PFX fmt, ## args); } while (0)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue
2018-07-28 9:02 [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue Sohil Ladhani
@ 2018-07-29 20:17 ` David Miller
2018-07-31 9:43 ` Sohil Ladhani
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2018-07-29 20:17 UTC (permalink / raw)
To: supertakumi86; +Cc: nic_swsd, netdev, linux-kernel
From: Sohil Ladhani <supertakumi86@gmail.com>
Date: Sat, 28 Jul 2018 14:32:21 +0530
> Fixed a coding style issue
>
> Signed-off-by: Sohil Ladhani <supertakumi86@gmail.com>
This doesn't apply to the current net-next tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue
2018-07-29 20:17 ` David Miller
@ 2018-07-31 9:43 ` Sohil Ladhani
0 siblings, 0 replies; 3+ messages in thread
From: Sohil Ladhani @ 2018-07-31 9:43 UTC (permalink / raw)
To: David Miller; +Cc: nic_swsd, netdev, linux-kernel
Hi David. Thanks for your inputs. I'm a kernel newbie and was just
following Greg's FOSDEM talk to submit my first patch. Will submit
further patches to net-next tree.
On Mon, Jul 30, 2018 at 1:47 AM, David Miller <davem@davemloft.net> wrote:
> From: Sohil Ladhani <supertakumi86@gmail.com>
> Date: Sat, 28 Jul 2018 14:32:21 +0530
>
>> Fixed a coding style issue
>>
>> Signed-off-by: Sohil Ladhani <supertakumi86@gmail.com>
>
> This doesn't apply to the current net-next tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-31 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-28 9:02 [PATCH] net: ethernet: realtek: r8169: Add spaces after commas coding style issue Sohil Ladhani
2018-07-29 20:17 ` David Miller
2018-07-31 9:43 ` Sohil Ladhani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).