* [PATCH net-next] sysfs: Fix regression when adding a file to an existing group
@ 2018-07-27 21:33 Tyler Hicks
2018-07-28 15:47 ` Heiner Kallweit
2018-07-29 20:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Tyler Hicks @ 2018-07-27 21:33 UTC (permalink / raw)
To: David S. Miller
Cc: Greg Kroah-Hartman, Heiner Kallweit, Dmitry Torokhov,
linux-kernel, netdev
Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging
to arbitrary users") incorrectly changed the argument passed as the
parent parameter when calling sysfs_add_file_mode_ns(). This caused some
sysfs attribute files to not be added correctly to certain groups.
Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users")
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
---
Note, this was a regression exclusively in linux-next and never made it to
Linus' tree. There's no need to queue it up for linux-stable.
fs/sysfs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index fa46216523cf..052e5ad9a4d2 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -373,7 +373,7 @@ int sysfs_add_file_to_group(struct kobject *kobj,
return -ENOENT;
kobject_get_ownership(kobj, &uid, &gid);
- error = sysfs_add_file_mode_ns(kobj->sd, attr, false,
+ error = sysfs_add_file_mode_ns(parent, attr, false,
attr->mode, uid, gid, NULL);
kernfs_put(parent);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sysfs: Fix regression when adding a file to an existing group
2018-07-27 21:33 [PATCH net-next] sysfs: Fix regression when adding a file to an existing group Tyler Hicks
@ 2018-07-28 15:47 ` Heiner Kallweit
2018-07-29 20:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2018-07-28 15:47 UTC (permalink / raw)
To: Tyler Hicks, David S. Miller
Cc: Greg Kroah-Hartman, Dmitry Torokhov, linux-kernel, netdev
On 27.07.2018 23:33, Tyler Hicks wrote:
> Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging
> to arbitrary users") incorrectly changed the argument passed as the
> parent parameter when calling sysfs_add_file_mode_ns(). This caused some
> sysfs attribute files to not be added correctly to certain groups.
>
> Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users")
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>
> Note, this was a regression exclusively in linux-next and never made it to
> Linus' tree. There's no need to queue it up for linux-stable.
>
> fs/sysfs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index fa46216523cf..052e5ad9a4d2 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -373,7 +373,7 @@ int sysfs_add_file_to_group(struct kobject *kobj,
> return -ENOENT;
>
> kobject_get_ownership(kobj, &uid, &gid);
> - error = sysfs_add_file_mode_ns(kobj->sd, attr, false,
> + error = sysfs_add_file_mode_ns(parent, attr, false,
> attr->mode, uid, gid, NULL);
> kernfs_put(parent);
>
>
Tested-by: Heiner Kallweit <hkallweit1@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sysfs: Fix regression when adding a file to an existing group
2018-07-27 21:33 [PATCH net-next] sysfs: Fix regression when adding a file to an existing group Tyler Hicks
2018-07-28 15:47 ` Heiner Kallweit
@ 2018-07-29 20:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-29 20:11 UTC (permalink / raw)
To: tyhicks; +Cc: gregkh, hkallweit1, dmitry.torokhov, linux-kernel, netdev
From: Tyler Hicks <tyhicks@canonical.com>
Date: Fri, 27 Jul 2018 21:33:27 +0000
> Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging
> to arbitrary users") incorrectly changed the argument passed as the
> parent parameter when calling sysfs_add_file_mode_ns(). This caused some
> sysfs attribute files to not be added correctly to certain groups.
>
> Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users")
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>
> Note, this was a regression exclusively in linux-next and never made it to
> Linus' tree. There's no need to queue it up for linux-stable.
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-29 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 21:33 [PATCH net-next] sysfs: Fix regression when adding a file to an existing group Tyler Hicks
2018-07-28 15:47 ` Heiner Kallweit
2018-07-29 20:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).