From: Quentin Schulz <quentin.schulz@bootlin.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Quentin Schulz <quentin.schulz@bootlin.com>
Subject: [PATCH 3/4] dt-bindings: net: phy: mscc: vsc8531: fix missing "/bits/ 8" in example
Date: Mon, 30 Jul 2018 15:02:35 +0200 [thread overview]
Message-ID: <20180730130236.3837-3-quentin.schulz@bootlin.com> (raw)
In-Reply-To: <20180730130236.3837-1-quentin.schulz@bootlin.com>
The "vsc8531,led-N-mode" property is read as a u8 in the driver and
there aren't a lot of modes anyway.
Without the "/bits/ 8" in front of the value of the property, the
value is stored as an u32 resulting in of_read_property_u8 to always
return 0.
Fix the example so that people using the property can actually use it.
Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
---
Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
index 664d9d0543fc..4c7d1d384df0 100644
--- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
+++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
@@ -63,6 +63,6 @@ Example:
compatible = "ethernet-phy-id0007.0570";
vsc8531,vddmac = <3300>;
vsc8531,edge-slowdown = <7>;
- vsc8531,led-0-mode = <LINK_1000_ACTIVITY>;
- vsc8531,led-1-mode = <LINK_100_ACTIVITY>;
+ vsc8531,led-0-mode = /bits/ 8 <LINK_1000_ACTIVITY>;
+ vsc8531,led-1-mode = /bits/ 8 <LINK_100_ACTIVITY>;
};
--
2.17.1
next prev parent reply other threads:[~2018-07-30 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 13:02 [PATCH net-next 1/4] net: phy: mscc: factorize code for LEDs mode Quentin Schulz
2018-07-30 13:02 ` [PATCH 2/4] dt-bindings: net: phy: mscc: vsc8531: remove compatible from required properties Quentin Schulz
2018-07-30 13:53 ` Andrew Lunn
2018-08-13 22:50 ` Rob Herring
2018-07-30 13:02 ` Quentin Schulz [this message]
2018-07-30 13:58 ` [PATCH 3/4] dt-bindings: net: phy: mscc: vsc8531: fix missing "/bits/ 8" in example Andrew Lunn
2018-07-31 9:11 ` Quentin Schulz
2018-08-13 22:54 ` Rob Herring
2018-07-30 13:02 ` [PATCH 4/4] dt-bindings: net: phy: mscc: vsc8531: factorize vsc8531,led-N-mode Quentin Schulz
2018-08-13 22:55 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730130236.3837-3-quentin.schulz@bootlin.com \
--to=quentin.schulz@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).