From: Rob Herring <robh@kernel.org>
To: Quentin Schulz <quentin.schulz@bootlin.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
mark.rutland@arm.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH 4/4] dt-bindings: net: phy: mscc: vsc8531: factorize vsc8531,led-N-mode
Date: Mon, 13 Aug 2018 16:55:24 -0600 [thread overview]
Message-ID: <20180813225524.GA19219@rob-hp-laptop> (raw)
In-Reply-To: <20180730130236.3837-4-quentin.schulz@bootlin.com>
On Mon, Jul 30, 2018 at 03:02:36PM +0200, Quentin Schulz wrote:
> VSC8584 supports 4 LEDs while VSC8531 only supports 2. Let's factorize
> the documentation for LED mode properties and give the 4 default values
> (the first two being shared between VSC8531 and VSC8584).
>
> Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
> ---
> .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2018-08-13 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 13:02 [PATCH net-next 1/4] net: phy: mscc: factorize code for LEDs mode Quentin Schulz
2018-07-30 13:02 ` [PATCH 2/4] dt-bindings: net: phy: mscc: vsc8531: remove compatible from required properties Quentin Schulz
2018-07-30 13:53 ` Andrew Lunn
2018-08-13 22:50 ` Rob Herring
2018-07-30 13:02 ` [PATCH 3/4] dt-bindings: net: phy: mscc: vsc8531: fix missing "/bits/ 8" in example Quentin Schulz
2018-07-30 13:58 ` Andrew Lunn
2018-07-31 9:11 ` Quentin Schulz
2018-08-13 22:54 ` Rob Herring
2018-07-30 13:02 ` [PATCH 4/4] dt-bindings: net: phy: mscc: vsc8531: factorize vsc8531,led-N-mode Quentin Schulz
2018-08-13 22:55 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813225524.GA19219@rob-hp-laptop \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).