* [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs
@ 2018-07-23 3:06 Viresh Kumar
2018-07-31 7:24 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-07-23 3:06 UTC (permalink / raw)
To: Wei Xu
Cc: Viresh Kumar, Vincent Guittot, Daniel Lezcano, linux-arm-kernel,
devicetree, linux-kernel
The clocks property should either be present for all the CPUs of a
cluster or none. If these are present only for a subset of CPUs of a
cluster then things will start falling apart as soon as the CPUs are
brought online in a different order. For example, this will happen
because the operating system looks for such properties in the CPU node
it is trying to bring up, so that it can register a cooling device.
Add missing clocks property.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 919d36b91bf3..aec9e371c2a7 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -99,6 +99,7 @@
reg = <0x0 0x1>;
enable-method = "psci";
next-level-cache = <&CLUSTER0_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -111,6 +112,7 @@
reg = <0x0 0x2>;
enable-method = "psci";
next-level-cache = <&CLUSTER0_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -123,6 +125,7 @@
reg = <0x0 0x3>;
enable-method = "psci";
next-level-cache = <&CLUSTER0_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -135,6 +138,7 @@
reg = <0x0 0x100>;
enable-method = "psci";
next-level-cache = <&CLUSTER1_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -147,6 +151,7 @@
reg = <0x0 0x101>;
enable-method = "psci";
next-level-cache = <&CLUSTER1_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -159,6 +164,7 @@
reg = <0x0 0x102>;
enable-method = "psci";
next-level-cache = <&CLUSTER1_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
@@ -171,6 +177,7 @@
reg = <0x0 0x103>;
enable-method = "psci";
next-level-cache = <&CLUSTER1_L2>;
+ clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
#cooling-cells = <2>; /* min followed by max */
--
2.18.0.rc1.242.g61856ae69a2c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs
2018-07-23 3:06 [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs Viresh Kumar
@ 2018-07-31 7:24 ` Viresh Kumar
2018-08-08 10:28 ` Wei Xu
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-07-31 7:24 UTC (permalink / raw)
To: Wei Xu
Cc: Vincent Guittot, Daniel Lezcano, linux-arm-kernel, devicetree,
linux-kernel
On 23-07-18, 08:36, Viresh Kumar wrote:
> The clocks property should either be present for all the CPUs of a
> cluster or none. If these are present only for a subset of CPUs of a
> cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add missing clocks property.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
@Wei: Can you please apply this one as well ?
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs
2018-07-31 7:24 ` Viresh Kumar
@ 2018-08-08 10:28 ` Wei Xu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Xu @ 2018-08-08 10:28 UTC (permalink / raw)
To: Viresh Kumar
Cc: Vincent Guittot, Daniel Lezcano, linux-arm-kernel, devicetree,
linux-kernel
Hi Viresh,
On 2018/7/31 8:24, Viresh Kumar wrote:
> On 23-07-18, 08:36, Viresh Kumar wrote:
>> The clocks property should either be present for all the CPUs of a
>> cluster or none. If these are present only for a subset of CPUs of a
>> cluster then things will start falling apart as soon as the CPUs are
>> brought online in a different order. For example, this will happen
>> because the operating system looks for such properties in the CPU node
>> it is trying to bring up, so that it can register a cooling device.
>>
>> Add missing clocks property.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
> @Wei: Can you please apply this one as well ?
Sorry for the late reply!
I will apply it after 4.19-rc1 released.
Thanks!
Best Regards,
Wei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-08 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 3:06 [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs Viresh Kumar
2018-07-31 7:24 ` Viresh Kumar
2018-08-08 10:28 ` Wei Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).