linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/9] block: Consolidate scsi sense buffer usage
@ 2018-07-31 19:51 Kees Cook
  2018-07-31 19:51 ` [PATCH v2 1/9] ide-cd: Drop unused sense buffers Kees Cook
                   ` (10 more replies)
  0 siblings, 11 replies; 29+ messages in thread
From: Kees Cook @ 2018-07-31 19:51 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Kees Cook, Christoph Hellwig, Martin K. Petersen,
	James E.J. Bottomley, Tejun Heo, Borislav Petkov,
	David S. Miller, Manoj N. Kumar, Matthew R. Ochs, Uma Krishnan,
	Nicholas A. Bellinger, Thomas Gleixner, Philippe Ombredanne,
	Stephen Boyd, Cyrille Pitchen, Juergen Gross, Viresh Kumar,
	Uwe Kleine-König, Sagar Dharia, Randy Dunlap, Vinod Koul,
	David Kershner, linux-block, linux-ide, linux-scsi, target-devel,
	linux-kernel

This is a follow-up to commit f7068114d45e ("sr: pass down correctly
sized SCSI sense buffer") which further cleans up and removes needless
sense character array buffers and "struct request_sense" usage in favor
of the common "struct scsi_sense_hdr".

First, drop a bunch of unused sense buffers:
 [PATCH 1/9] ide-cd: Drop unused sense buffers
 [PATCH 2/9] scsi: cxlflash: Drop unused sense buffers

Next, allow the sense buffer to be usable outside SCSI tree:
 [PATCH 3/9] scsi: build scsi_common.o for all scsi passthrough request users
 [PATCH 4/9] target: don't depend on SCSI

Then move all request_sense usage to scsi_sense_hdr:
 [PATCH 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr

And do some further cleanups for scsi_sense_hdr now that we can:
 [PATCH 6/9] ide-cd: Remove redundant sense buffer
 [PATCH 7/9] cdrom: Use struct scsi_sense_hdr internally

Finally add a build-time check to make sure we don't pass bad buffer sizes:
 [PATCH 8/9] libata-scsi: Move sense buffers onto stack
 [PATCH 9/9] scsi: Check sense buffer size at build time


-Kees

Christoph Hellwig (2):
  scsi: build scsi_common.o for all scsi passthrough request users
  target: don't depend on SCSI

Kees Cook (7):
  ide-cd: Drop unused sense buffers
  scsi: cxlflash: Drop unused sense buffers
  block: Switch struct packet_command to use struct scsi_sense_hdr
  ide-cd: Remove redundant sense buffer
  cdrom: Use struct scsi_sense_hdr internally
  libata-scsi: Move sense buffers onto stack
  scsi: Check sense buffer size at build time

 drivers/Makefile                  |  2 +-
 drivers/ata/libata-scsi.c         | 18 +++------
 drivers/block/Kconfig             |  2 +-
 drivers/block/pktcdvd.c           | 36 +++++++++---------
 drivers/cdrom/cdrom.c             | 30 ++++++++-------
 drivers/ide/ide-cd.c              | 58 ++++++++++++++---------------
 drivers/ide/ide-cd.h              |  6 +--
 drivers/ide/ide-cd_ioctl.c        | 62 +++++++++++++------------------
 drivers/scsi/Makefile             |  2 +-
 drivers/scsi/cxlflash/superpipe.c |  8 +---
 drivers/scsi/cxlflash/vlun.c      |  7 +---
 drivers/scsi/scsi_lib.c           |  6 +--
 drivers/scsi/sr_ioctl.c           | 22 +++++------
 drivers/target/Kconfig            |  5 ++-
 include/linux/cdrom.h             |  3 +-
 include/scsi/scsi_cmnd.h          |  6 +--
 include/scsi/scsi_device.h        | 14 ++++++-
 17 files changed, 136 insertions(+), 151 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2018-08-07  5:39 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-31 19:51 [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Kees Cook
2018-07-31 19:51 ` [PATCH v2 1/9] ide-cd: Drop unused sense buffers Kees Cook
2018-07-31 21:29   ` David Miller
2018-07-31 19:51 ` [PATCH v2 2/9] scsi: cxlflash: " Kees Cook
2018-07-31 19:51 ` [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users Kees Cook
2018-07-31 20:01   ` Bart Van Assche
2018-07-31 20:12     ` hch
2018-07-31 20:18       ` Bart Van Assche
2018-08-01 19:50         ` Kees Cook
2018-07-31 19:51 ` [PATCH v2 4/9] target: don't depend on SCSI Kees Cook
2018-08-06 23:38   ` Randy Dunlap
2018-08-06 23:59     ` Kees Cook
2018-08-07  0:52       ` Randy Dunlap
2018-08-07  5:44       ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Kees Cook
2018-08-01  8:22   ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 6/9] ide-cd: Remove redundant sense buffer Kees Cook
2018-07-31 21:30   ` David Miller
2018-08-01  8:23   ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally Kees Cook
2018-08-01  8:24   ` Christoph Hellwig
2018-07-31 19:51 ` [PATCH v2 8/9] libata-scsi: Move sense buffers onto stack Kees Cook
2018-08-01  8:24   ` Christoph Hellwig
2018-08-01 15:45   ` Tejun Heo
2018-07-31 19:51 ` [PATCH v2 9/9] scsi: Check sense buffer size at build time Kees Cook
2018-08-01  8:25   ` Christoph Hellwig
2018-08-02 20:21 ` [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Martin K. Petersen
2018-08-02 21:24 ` Jens Axboe
2018-08-02 21:56   ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).