linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, mingo@kernel.org, peterz@infradead.org,
	luto@kernel.org, x86@kernel.org, efault@gmx.de,
	dave.hansen@intel.com, Rik van Riel <riel@surriel.com>
Subject: [PATCH 06/11] mm,x86: skip cr4 and ldt reload when mm stays the same
Date: Wed,  1 Aug 2018 06:02:50 -0400	[thread overview]
Message-ID: <20180801100255.4278-7-riel@surriel.com> (raw)
In-Reply-To: <20180801100255.4278-1-riel@surriel.com>

When switching back from lazy TLB mode to a thread of the same process
that switched into lazy TLB mode, we still have the cr4 (and sometimes
LDT) of that process loaded, and there is no need to reload it.

When there was no TLB flush while the CPU was in lazy TLB mode, the
current code in switch_mm_irqs_off already avoids the reload, by
returning early.

However, when the TLB contents on the CPU are out of date, and we
flush the TLB for the task, we fall through to the regular context
switching code. This patch teaches that code to skip the cr4 and LDT
flushes when switching back to the same mm after a flush.

Suggested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Rik van Riel <riel@surriel.com>
Acked-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/mm/tlb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 671cc66df801..149fb64e4bf4 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -367,8 +367,10 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
 	this_cpu_write(cpu_tlbstate.loaded_mm, next);
 	this_cpu_write(cpu_tlbstate.loaded_mm_asid, new_asid);
 
-	load_mm_cr4(next);
-	switch_ldt(real_prev, next);
+	if (next != real_prev) {
+		load_mm_cr4(next);
+		switch_ldt(real_prev, next);
+	}
 }
 
 /*
-- 
2.14.4


  parent reply	other threads:[~2018-08-01 10:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 10:02 [PATCH v2 0/11] x86,tlb,mm: more lazy TLB cleanups & optimizations Rik van Riel
2018-08-01 10:02 ` [PATCH 01/11] x86,tlb: clarify memory barrier in switch_mm_irqs_off Rik van Riel
2018-08-01 10:02 ` [PATCH 02/11] smp: use __cpumask_set_cpu in on_each_cpu_cond Rik van Riel
2018-08-01 10:02 ` [PATCH 03/11] smp,cpumask: introduce on_each_cpu_cond_mask Rik van Riel
2018-08-01 10:02 ` [PATCH 04/11] x86,mm: use on_each_cpu_cond for TLB flushes Rik van Riel
2018-08-01 10:02 ` [PATCH 05/11] mm,tlb: turn dummy defines into inline functions Rik van Riel
2018-08-01 10:02 ` Rik van Riel [this message]
2018-08-01 10:02 ` [PATCH 07/11] x86,mm: remove leave_mm cpu argument Rik van Riel
2018-08-01 10:02 ` [PATCH 08/11] arch,mm: add config variable to skip lazy TLB mm refcounting Rik van Riel
2018-08-01 10:02 ` [PATCH 09/11] mm,x86: shoot down lazy TLB references at exit_mmap time Rik van Riel
2018-08-01 10:02 ` [PATCH 10/11] x86,tlb: really leave mm on shootdown Rik van Riel
2018-08-01 10:02 ` [PATCH 11/11] mm,sched: conditionally skip lazy TLB mm refcounting Rik van Riel
2018-08-03 15:56   ` Peter Zijlstra
2018-08-03 16:40     ` Rik van Riel
2018-08-03 17:25       ` Peter Zijlstra
2018-08-03 17:39         ` Rik van Riel
2018-08-06 17:50           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801100255.4278-7-riel@surriel.com \
    --to=riel@surriel.com \
    --cc=dave.hansen@intel.com \
    --cc=efault@gmx.de \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).