From: Rik van Riel <riel@surriel.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, mingo@kernel.org, peterz@infradead.org,
luto@kernel.org, x86@kernel.org, efault@gmx.de,
dave.hansen@intel.com, Rik van Riel <riel@surriel.com>
Subject: [PATCH 07/11] x86,mm: remove leave_mm cpu argument
Date: Wed, 1 Aug 2018 06:02:51 -0400 [thread overview]
Message-ID: <20180801100255.4278-8-riel@surriel.com> (raw)
In-Reply-To: <20180801100255.4278-1-riel@surriel.com>
The function leave_mm does not use its cpu argument, but always works on
the CPU where it is called. Change the argument to a void *, so leave_mm
can be called directly from smp_call_function_mask, and stop looking up the
CPU number in current leave_mm callers.
Signed-off-by: Rik van Riel <riel@surriel.com>
---
arch/x86/include/asm/mmu.h | 2 +-
arch/x86/mm/tlb.c | 2 +-
arch/x86/xen/mmu_pv.c | 2 +-
drivers/acpi/processor_idle.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/mmu.h b/arch/x86/include/asm/mmu.h
index 5ff3e8af2c20..ec27966f338f 100644
--- a/arch/x86/include/asm/mmu.h
+++ b/arch/x86/include/asm/mmu.h
@@ -61,6 +61,6 @@ typedef struct {
.ctx_id = 1, \
}
-void leave_mm(int cpu);
+void leave_mm(void * dummy);
#endif /* _ASM_X86_MMU_H */
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 149fb64e4bf4..ea4ef5ceaba2 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -121,7 +121,7 @@ static void load_new_mm_cr3(pgd_t *pgdir, u16 new_asid, bool need_flush)
write_cr3(new_mm_cr3);
}
-void leave_mm(int cpu)
+void leave_mm(void *dummy)
{
struct mm_struct *loaded_mm = this_cpu_read(cpu_tlbstate.loaded_mm);
diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 52206ad81e4b..3402d2bf4ae0 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -984,7 +984,7 @@ static void drop_mm_ref_this_cpu(void *info)
struct mm_struct *mm = info;
if (this_cpu_read(cpu_tlbstate.loaded_mm) == mm)
- leave_mm(smp_processor_id());
+ leave_mm(NULL);
/*
* If this cpu still has a stale cr3 reference, then make sure
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index abb559cd28d7..675ffacdd82b 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -714,7 +714,7 @@ static DEFINE_RAW_SPINLOCK(c3_lock);
static void acpi_idle_enter_bm(struct acpi_processor *pr,
struct acpi_processor_cx *cx, bool timer_bc)
{
- acpi_unlazy_tlb(smp_processor_id());
+ acpi_unlazy_tlb(NULL);
/*
* Must be done before busmaster disable as we might need to
--
2.14.4
next prev parent reply other threads:[~2018-08-01 10:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:02 [PATCH v2 0/11] x86,tlb,mm: more lazy TLB cleanups & optimizations Rik van Riel
2018-08-01 10:02 ` [PATCH 01/11] x86,tlb: clarify memory barrier in switch_mm_irqs_off Rik van Riel
2018-08-01 10:02 ` [PATCH 02/11] smp: use __cpumask_set_cpu in on_each_cpu_cond Rik van Riel
2018-08-01 10:02 ` [PATCH 03/11] smp,cpumask: introduce on_each_cpu_cond_mask Rik van Riel
2018-08-01 10:02 ` [PATCH 04/11] x86,mm: use on_each_cpu_cond for TLB flushes Rik van Riel
2018-08-01 10:02 ` [PATCH 05/11] mm,tlb: turn dummy defines into inline functions Rik van Riel
2018-08-01 10:02 ` [PATCH 06/11] mm,x86: skip cr4 and ldt reload when mm stays the same Rik van Riel
2018-08-01 10:02 ` Rik van Riel [this message]
2018-08-01 10:02 ` [PATCH 08/11] arch,mm: add config variable to skip lazy TLB mm refcounting Rik van Riel
2018-08-01 10:02 ` [PATCH 09/11] mm,x86: shoot down lazy TLB references at exit_mmap time Rik van Riel
2018-08-01 10:02 ` [PATCH 10/11] x86,tlb: really leave mm on shootdown Rik van Riel
2018-08-01 10:02 ` [PATCH 11/11] mm,sched: conditionally skip lazy TLB mm refcounting Rik van Riel
2018-08-03 15:56 ` Peter Zijlstra
2018-08-03 16:40 ` Rik van Riel
2018-08-03 17:25 ` Peter Zijlstra
2018-08-03 17:39 ` Rik van Riel
2018-08-06 17:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801100255.4278-8-riel@surriel.com \
--to=riel@surriel.com \
--cc=dave.hansen@intel.com \
--cc=efault@gmx.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).