From: Steven Rostedt <rostedt@goodmis.org>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <mingo@redhat.com>, <peterz@infradead.org>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static
Date: Fri, 3 Aug 2018 09:21:05 -0400 [thread overview]
Message-ID: <20180803092105.3dd68f05@gandalf.local.home> (raw)
In-Reply-To: <1533300002-27105-1-git-send-email-zhongjiang@huawei.com>
On Fri, 3 Aug 2018 20:40:02 +0800
zhong jiang <zhongjiang@huawei.com> wrote:
> Fix the following warning.
>
> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
This should go via the trivial tree.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> kernel/kthread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index 087d18d..3c661a0 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
> }
> EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>
> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
> struct kthread_delayed_work *dwork,
> unsigned long delay)
Although, one could say you should align the parameters too, but that's
not a big deal. Anyway...
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> {
next prev parent reply other threads:[~2018-08-03 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 12:40 [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static zhong jiang
2018-08-03 13:21 ` Steven Rostedt [this message]
2018-08-05 13:34 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803092105.3dd68f05@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).