* [PATCH] drm: Remove drm_fbdev_cma_set_suspend()
@ 2018-07-30 19:23 Souptick Joarder
2018-08-06 6:07 ` Souptick Joarder
2018-08-06 8:39 ` Daniel Vetter
0 siblings, 2 replies; 3+ messages in thread
From: Souptick Joarder @ 2018-07-30 19:23 UTC (permalink / raw)
To: gustavo, maarten.lankhorst, seanpaul, airlied; +Cc: dri-devel, linux-kernel
drm_fbdev_cma_set_suspend() is not getting called from
any other places. If there is no plan to use it in future
we can remove this API.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 15 ---------------
include/drm/drm_fb_cma_helper.h | 1 -
2 files changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index 186d00a..4c283d9 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma)
EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);
/**
- * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend
- * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
- * @state: desired state, zero to resume, non-zero to suspend
- *
- * Calls drm_fb_helper_set_suspend, which is a wrapper around
- * fb_set_suspend implemented by fbdev core.
- */
-void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state)
-{
- if (fbdev_cma)
- drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state);
-}
-EXPORT_SYMBOL(drm_fbdev_cma_set_suspend);
-
-/**
* drm_fbdev_cma_set_suspend_unlocked - wrapper around
* drm_fb_helper_set_suspend_unlocked
* @fbdev_cma: The drm_fbdev_cma struct, may be NULL
diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
index d532f88a..52f09dc 100644
--- a/include/drm/drm_fb_cma_helper.h
+++ b/include/drm/drm_fb_cma_helper.h
@@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev,
void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma);
void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma);
-void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);
void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
bool state);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove drm_fbdev_cma_set_suspend()
2018-07-30 19:23 [PATCH] drm: Remove drm_fbdev_cma_set_suspend() Souptick Joarder
@ 2018-08-06 6:07 ` Souptick Joarder
2018-08-06 8:39 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Souptick Joarder @ 2018-08-06 6:07 UTC (permalink / raw)
To: Gustavo Padovan, Maarten Lankhorst, Sean Paul, airlied
Cc: dri-devel, linux-kernel
On Tue, Jul 31, 2018 at 12:53 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> drm_fbdev_cma_set_suspend() is not getting called from
> any other places. If there is no plan to use it in future
> we can remove this API.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
Any comment on this patch ?
> drivers/gpu/drm/drm_fb_cma_helper.c | 15 ---------------
> include/drm/drm_fb_cma_helper.h | 1 -
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index 186d00a..4c283d9 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma)
> EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);
>
> /**
> - * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend
> - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
> - * @state: desired state, zero to resume, non-zero to suspend
> - *
> - * Calls drm_fb_helper_set_suspend, which is a wrapper around
> - * fb_set_suspend implemented by fbdev core.
> - */
> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state)
> -{
> - if (fbdev_cma)
> - drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state);
> -}
> -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend);
> -
> -/**
> * drm_fbdev_cma_set_suspend_unlocked - wrapper around
> * drm_fb_helper_set_suspend_unlocked
> * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> index d532f88a..52f09dc 100644
> --- a/include/drm/drm_fb_cma_helper.h
> +++ b/include/drm/drm_fb_cma_helper.h
> @@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev,
>
> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma);
> void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma);
> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);
> void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
> bool state);
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Remove drm_fbdev_cma_set_suspend()
2018-07-30 19:23 [PATCH] drm: Remove drm_fbdev_cma_set_suspend() Souptick Joarder
2018-08-06 6:07 ` Souptick Joarder
@ 2018-08-06 8:39 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-08-06 8:39 UTC (permalink / raw)
To: Souptick Joarder
Cc: gustavo, maarten.lankhorst, seanpaul, airlied, linux-kernel, dri-devel
On Tue, Jul 31, 2018 at 12:53:26AM +0530, Souptick Joarder wrote:
> drm_fbdev_cma_set_suspend() is not getting called from
> any other places. If there is no plan to use it in future
> we can remove this API.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
cma version of fbdev helpers are indeed getting subsumed by fbdev helpers
at large, so this makes sense I think.
Applied for 4.20, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 15 ---------------
> include/drm/drm_fb_cma_helper.h | 1 -
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index 186d00a..4c283d9 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -516,21 +516,6 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma)
> EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);
>
> /**
> - * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend
> - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
> - * @state: desired state, zero to resume, non-zero to suspend
> - *
> - * Calls drm_fb_helper_set_suspend, which is a wrapper around
> - * fb_set_suspend implemented by fbdev core.
> - */
> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state)
> -{
> - if (fbdev_cma)
> - drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state);
> -}
> -EXPORT_SYMBOL(drm_fbdev_cma_set_suspend);
> -
> -/**
> * drm_fbdev_cma_set_suspend_unlocked - wrapper around
> * drm_fb_helper_set_suspend_unlocked
> * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> index d532f88a..52f09dc 100644
> --- a/include/drm/drm_fb_cma_helper.h
> +++ b/include/drm/drm_fb_cma_helper.h
> @@ -32,7 +32,6 @@ struct drm_fbdev_cma *drm_fbdev_cma_init(struct drm_device *dev,
>
> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma);
> void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma);
> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);
> void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
> bool state);
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-06 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 19:23 [PATCH] drm: Remove drm_fbdev_cma_set_suspend() Souptick Joarder
2018-08-06 6:07 ` Souptick Joarder
2018-08-06 8:39 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).