From: Rob Herring <robh@kernel.org> To: Sibi S <sibis@codeaurora.org> Cc: Philipp Zabel <p.zabel@pengutronix.de>, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ohad@wizery.com, mark.rutland@arm.com, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org, ilina@codeaurora.org Subject: Re: [PATCH 1/4] dt-bindings: reset: Add PDC reset binding for SDM845 SoCs Date: Tue, 7 Aug 2018 12:16:59 -0600 Message-ID: <20180807181659.GA20659@rob-hp-laptop> (raw) In-Reply-To: <28f34ddf-03b2-0baa-c04f-15e546ef3f75@codeaurora.org> On Tue, Jul 31, 2018 at 06:27:24PM +0530, Sibi S wrote: > Hi Philipp, > Thanks for the review! > > On 07/31/2018 02:12 PM, Philipp Zabel wrote: > > Hi Sibi, > > > > On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: > > > Add SDM845 PDC (Power Domain Controller) reset controller binding > > > > > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > > > --- > > > .../bindings/reset/qcom,pdc-reset.txt | 52 +++++++++++++++++++ > > > include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++++++ > > > 2 files changed, 72 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/reset/qcom,pdc-reset.txt > > > create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h > > > > > > diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-reset.txt b/Documentation/devicetree/bindings/reset/qcom,pdc-reset.txt > > > new file mode 100644 > > > index 000000000000..85e159962e08 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-reset.txt > > > @@ -0,0 +1,52 @@ > > > +PDC Reset Controller > > > +====================================== > > > + > > > +This binding describes a reset-controller found on PDC-Global(Power Domain > > > +Controller) block for Qualcomm Technologies Inc SDM845 SoCs. > > > + > > > +Required properties: > > > +- compatible: > > > + Usage: required > > > + Value type: <string> > > > + Definition: must be: > > > + "qcom,sdm845-pdc-global" > > > + > > > +- reg: > > > + Usage: required > > > + Value type: <prop-encoded-array> > > > + Definition: must specify the base address and size of the register > > > + space. > > > + > > > +- #reset-cells: > > > + Usage: required > > > + Value type: <uint> > > > + Definition: must be 1; cell entry represents the reset index. > > > + > > > +Example: > > > + > > > +pdc_reset: reset-controller@b2e0000 { > > > > Is this really just a reset controller? > > > > The name makes it sound like a driver binding to this should also > > provide pm_genpd and the binding should probably call this a power- > > controller: Documentation/devicetree/bindings/power/power_domain.txt. > > > > The PDC-global reg space which is a part of PDC-wrapper reg space seems > to be only used for the reset lines. > > Couple of other drivers use other parts of the PDC-wrapper reg space: > https://patchwork.kernel.org/patch/10223701/ (PDC-Interrupt controller) > https://patchwork.kernel.org/patch/10255767/ (GMU-PDC incorrectly tries > to occupy the entire pdc-wrapper reg space) > > since it couldn't be logically mapped into pdc-interrupt driver, it had > to be included as a separate reset driver. You can't have overlapping regions in DT (well, you can because we have to work-around existing DTs that do, but you shouldn't). A single node can be multiple providers such as interrupt controller and reset controller. It's an OS problem to split that into multiple drivers. > > > + compatible = "qcom,sdm845-pdc-global"; > > > + reg = <0xb2e0000 0x20000>; > > > > This looks like this is the register space of the complete PDC, not just > > the reset register? > > > > The entire register space was chosen because it is only used for its > reset lines (had a good look at the downstream kernel and had a conversation > with Lina) and to ensure break backward compatibility for > the for the dt entry if the reg-space was used for other purposes in > the future. Why do you want to ensure breaking backwards compatibility? Rob
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-27 15:28 Sibi Sankar 2018-07-27 15:28 ` [PATCH 2/4] reset: qcom: PDC (Power Domain Controller) reset controller Sibi Sankar 2018-07-31 8:51 ` Philipp Zabel 2018-07-31 13:00 ` Sibi S 2018-08-21 22:17 ` Bjorn Andersson 2018-07-27 15:28 ` [PATCH 3/4] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line Sibi Sankar 2018-07-31 8:57 ` Philipp Zabel 2018-07-31 13:11 ` Sibi S 2018-07-27 15:28 ` [PATCH 4/4] remoteproc: qcom: q6v5-pil: Add PDC restart for modem on SDM845 SoCs Sibi Sankar 2018-07-31 8:54 ` Philipp Zabel 2018-07-31 13:13 ` Sibi S 2018-08-07 18:18 ` Rob Herring 2018-08-08 15:45 ` Sibi Sankar 2018-08-21 22:33 ` Bjorn Andersson 2018-07-31 8:42 ` [PATCH 1/4] dt-bindings: reset: Add PDC reset binding for " Philipp Zabel 2018-07-31 12:57 ` Sibi S 2018-08-07 18:16 ` Rob Herring [this message] 2018-08-08 15:44 ` Sibi Sankar 2018-08-08 21:37 ` Jordan Crouse 2018-08-08 22:48 ` Jordan Crouse 2018-08-21 22:08 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180807181659.GA20659@rob-hp-laptop \ --to=robh@kernel.org \ --cc=akdwived@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilina@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=ohad@wizery.com \ --cc=p.zabel@pengutronix.de \ --cc=sibis@codeaurora.org \ --cc=sricharan@codeaurora.org \ --cc=tsoni@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git